FeedbackTest failing on cros + viz |
||||||
Issue descriptionAfter switching Layer CopyOutputRequests to execute in the Viz Service the FeedbackTest test began failing on Chrome OS builds. CL that switched: https://chromium-review.googlesource.com/#/c/890339/ First failing build: https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/26748 This can be reproduced locally by: ./out/cros/browser_tests --gtest_filter=FeedbackTest.* --enable-features=VizDisplayCompositor Though there seems to be some flakiness, as not all 5 tests fail each time. Stack Trace: 1182:1182:0208/055730.766613:FATAL:viz_process_transport_factory.cc(350)] Check failed: false. #0 0x000003ec190c base::debug::StackTrace::StackTrace() #1 0x000003edbb5c logging::LogMessage::~LogMessage() #2 0x000002c7390c content::VizProcessTransportFactory::GetGLHelper() #3 0x000002c12af0 content::AuraWindowCaptureMachine::ProcessCopyOutputResponse() #4 0x000002c125ca content::AuraWindowCaptureMachine::DidCopyOutput() #5 0x000002c13efb _ZN4base8internal13FunctorTraitsIMN7content24AuraWindowCaptureMachineEFv13scoped_refptrIN5media10VideoFrameEENS_9TimeTicksES8_RKNS_17RepeatingCallbackIFvS7_S8_bEEENSt3__110unique_ptrIN3viz16CopyOutputResultENSE_14default_deleteISH_EEEEEvE6InvokeINS_7WeakPtrIS3_EEJS7_S8_S8_SB_SK_EEEvSM_OT_DpOT0_ #6 0x000002c13e0a _ZN4base8internal7InvokerINS0_9BindStateIMN7content24AuraWindowCaptureMachineEFv13scoped_refptrIN5media10VideoFrameEENS_9TimeTicksES9_RKNS_17RepeatingCallbackIFvS8_S9_bEEENSt3__110unique_ptrIN3viz16CopyOutputResultENSF_14default_deleteISI_EEEEEJNS_7WeakPtrIS4_EES8_S9_S9_SC_EEEFvSL_EE7RunOnceEPNS0_13BindStateBaseEOSL_ #7 0x00000242983c (anonymous namespace)::CopyOutputResultSenderImpl::SendResult() #8 0x00000242323f viz::mojom::CopyOutputResultSenderStubDispatch::Accept() #9 0x0000051d280b mojo::InterfaceEndpointClient::HandleValidatedMessage() #10 0x0000051d23f6 mojo::FilterChain::Accept() #11 0x0000051d3b75 mojo::InterfaceEndpointClient::HandleIncomingMessage() #12 0x0000051d97dd mojo::internal::MultiplexRouter::ProcessIncomingMessage() #13 0x0000051d8d1c mojo::internal::MultiplexRouter::Accept() #14 0x0000051d23f6 mojo::FilterChain::Accept() #15 0x0000051d05b5 mojo::Connector::ReadSingleMessage() #16 0x0000051d0ed1 mojo::Connector::ReadAllAvailableMessages() #17 0x0000051d0d79 mojo::Connector::OnHandleReadyInternal() #18 0x000002529bd7 mojo::SimpleWatcher::DiscardReadyState() #19 0x0000051cb2c6 mojo::SimpleWatcher::OnHandleReady() #20 0x0000051cb7e1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #21 0x000003ec20c5 base::debug::TaskAnnotator::RunTask() #22 0x000003f7a2e9 base::internal::IncomingTaskQueue::RunTask() #23 0x000003ee351b base::MessageLoop::RunTask() #24 0x000003ee38b3 base::MessageLoop::DeferOrRunPendingTask() #25 0x000003ee3b46 base::MessageLoop::DoWork() #26 0x000003ee5c09 base::MessagePumpLibevent::Run() #27 0x000003ee2e19 base::MessageLoop::Run() #28 0x000003f0e339 base::RunLoop::Run() #29 0x00000454acb3 content::RunMessageLoop() #30 0x000003faf6dc InProcessBrowserTest::QuitBrowsers() #31 0x000003faf566 InProcessBrowserTest::PostRunTestOnMainThread() #32 0x0000045128c3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #33 0x000003ff575c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #34 0x000003ff44fd ChromeBrowserMainParts::PreMainMessageLoopRun() #35 0x000001992be8 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #36 0x000002753ec1 content::BrowserMainLoop::PreMainMessageLoopRun() #37 0x000002b946d5 content::StartupTaskRunner::RunAllTasksNow() #38 0x00000275247d content::BrowserMainLoop::CreateStartupTasks() #39 0x000002756993 content::BrowserMainRunnerImpl::Initialize() #40 0x000002750052 content::BrowserMain() #41 0x000003e8cb52 content::ContentMainRunnerImpl::Run() #42 0x00000617ebfb service_manager::Main() #43 0x000003e8b134 content::ContentMain() #44 0x00000451235f content::BrowserTestBase::SetUp() #45 0x000003fae1ac InProcessBrowserTest::SetUp() #46 0x000001d138b1 testing::Test::Run() #47 0x000001d14480 testing::TestInfo::Run() #48 0x000001d14967 testing::TestCase::Run() #49 0x000001d1be97 testing::internal::UnitTestImpl::RunAllTests() #50 0x000001d1bae7 testing::UnitTest::Run() #51 0x000003fc2832 base::TestSuite::Run() #52 0x000003eb57c9 ChromeTestSuiteRunner::RunTestSuite() #53 0x00000454749d content::LaunchTests() #54 0x000003eb5c94 LaunchChromeTests() #55 0x000003eb53dd main #56 0x7f00e4ffcf45 __libc_start_main #57 0x0000005c8eba _start
,
Feb 8 2018
Ironically, the change that landed and broke this test is one piece that is needed for Aura Window capture in the VIZ world. I'll mark this as blocked by bug 806366 so I can revisit and make sure this test it working again.
,
Feb 20 2018
,
Mar 8 2018
Issue 796594 has been merged into this issue.
,
Mar 12 2018
The test listed in #1 is currently blocked on issue 806366 There are a few other remaining failures in the Tap Capture space. It is likely that several of these will be addressed by fixing that issue. - TabCaptureApiPixelTest.OffscreenTab* - Flaky timeouts on CrOS - ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad - Failure: chrome/browser/thumbnails/thumbnail_browsertest.cc:336: Failure Actual function call count doesn't match EXPECT_CALL(*thumbnail_service(), SetPageThumbnail(Field(&ThumbnailingContext::url, red_url), ImageColorIs(static_cast<SkColor>(0xFFFF0000))))... Expected: to be called once Actual: never called - unsatisfied and active - ThumbnailTest.ShouldCaptureOnNavigatingAwayExplicitWait - times out attempting to acquire a thread lock
,
Jun 4 2018
,
Jun 20 2018
I saw what may have been a flake of FeedbackTest.ExtraDiagnostics also on Linux: [137267:137311:0620/172254.711536:FATAL:bus.cc(178)] Check failed: !connection_. #0 0x7f33f97b90bc base::debug::StackTrace::StackTrace() #1 0x7f33f970264b logging::LogMessage::~LogMessage() #2 0x7f33f31fd393 dbus::Bus::~Bus() #3 0x7f33f31fd64e dbus::Bus::~Bus() #4 0x7f33f3216253 dbus::ObjectProxy::~ObjectProxy() #5 0x7f33f321629e dbus::ObjectProxy::~ObjectProxy() #6 0x7f33f321b01a _ZN4base8internal9BindStateIMN4dbus11ObjectProxyEFbRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEESC_NS_17RepeatingCallbackIFvPNS2_6SignalEEEEEJ13scoped_refptrIS3_ESA_SA_SH_EED2Ev #7 0x7f33f321afa3 _ZN4base8internal9BindStateIMN4dbus11ObjectProxyEFbRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEESC_NS_17RepeatingCallbackIFvPNS2_6SignalEEEEEJ13scoped_refptrIS3_ESA_SA_SH_EE7DestroyEPKNS0_13BindStateBaseE #8 0x7f33f32152d6 base::internal::ReturnAsParamAdapter<>() #9 0x7f33f32153eb _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFbvEEEPbEJS5_S6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #10 0x7f33f977fdf0 base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() #11 0x7f33f9780289 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #12 0x7f33f96e2f40 base::debug::TaskAnnotator::RunTask() #13 0x7f33f9774a69 base::internal::TaskTracker::RunOrSkipTask() #14 0x7f33f97cd95b base::internal::TaskTrackerPosix::RunOrSkipTask() #15 0x7f33f9773bec base::internal::TaskTracker::RunAndPopNextTask() #16 0x7f33f97694dd base::internal::SchedulerWorker::RunWorker() #17 0x7f33f97692a4 base::internal::SchedulerWorker::RunSharedWorker() #18 0x7f33f97ce27f base::(anonymous namespace)::ThreadFunc() #19 0x7f33edd67494 start_thread #20 0x7f33ebcbaa8f clone They all seem to work on Chrome OS now. LoginFeedbackTest.Basic seems to be working again on ChromeOS. TabCaptureApiPixelTest.OffscreenTabEndToEnd & OffscreenTabEvilTestsseems to pass on ChromeOS, but fail on Linux with a timeout in extensions::ResultCatcher::GetNextResult() I'll shortly split these out into their own bugs. Assigning to myself to update the filters
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56cbde5b3287d78e31f474baf9b619998819af13 commit 56cbde5b3287d78e31f474baf9b619998819af13 Author: jonross <jonross@chromium.org> Date: Wed Jun 20 23:03:10 2018 Update Viz Browser Test Filter A series of tab capture related failures in Viz, tracked in 810389, have since been resolved. This reenables them. Further a previous Mac failure was fixed, but not re-enabled in IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed. This re-enables it. Furthermore we had disabled ConstrainedWebDialogBrowserTest as a part of initial speculation of all Mac browser_tests failures. However that variant is currently offline as the errors were more widespread than first thought. This removes it from the filter as is was not a Viz failure, and the Mac config currently doesn't run. TBR=kylechar@chromium.org TEST=viz_browser_tests FeedbackTest.* LoginFeedbackTest.Basic IndependentOTRProfileManagerTest.DeleteImmediatelyWhenBrowsersAlreadyClosed ConstrainedWebDialogBrowserTest.* Bug: 810389 Change-Id: I0c20b38bde95215a81155b0bc2f13f876be57528 Reviewed-on: https://chromium-review.googlesource.com/1109023 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569070} [modify] https://crrev.com/56cbde5b3287d78e31f474baf9b619998819af13/testing/buildbot/filters/viz.browser_tests.filter
,
Jun 20 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jonr...@chromium.org
, Feb 8 2018