New issue
Advanced search Search tips

Issue 810384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Remove RuntimeEnabledFlag for FeaturePolicy

Project Member Reported by iclell...@chromium.org, Feb 8 2018

Issue description

https://crbug.com/806362 was a crash caused (in part) by the fact that the feature policy flag was assumed to be on at all times, and the disabled state is not generally being tested by developers.

Following the guidance in runtime_enabled_features.json5 ("anything which we've shipped stable can have its runtime flag removed soon after.") we should remove that flag, and the corresponding entry in chrome://flags
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5130214053f83b415a1cd7f9997ff88b05397520

commit 5130214053f83b415a1cd7f9997ff88b05397520
Author: Ian Clelland <iclelland@chromium.org>
Date: Fri Feb 09 14:01:53 2018

Remove FeaturePolicy runtime flag

This removes the RuntimeEnabledFeatures flag, as well as the
base::Feature and the corresponding entry in chrome://flags

Bug:  810384 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icecbe35a6af6d85c7f130512aaf9f00a695df2af
Reviewed-on: https://chromium-review.googlesource.com/908711
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535700}
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/chrome/browser/about_flags.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/chrome/browser/usb/usb_tab_helper.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/content/browser/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/content/child/runtime_features.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/content/public/common/content_features.cc
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/content/public/common/content_features.h
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/e37f4616439d872a777af832e61ac282b1f60820/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/README.txt
[delete] https://crrev.com/e37f4616439d872a777af832e61ac282b1f60820/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-allowed-by-container-policy-expected.txt
[delete] https://crrev.com/e37f4616439d872a777af832e61ac282b1f60820/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate-expected.txt
[delete] https://crrev.com/e37f4616439d872a777af832e61ac282b1f60820/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-disabled-expected.txt
[delete] https://crrev.com/e37f4616439d872a777af832e61ac282b1f60820/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/fullscreen-enabledforall-expected.txt
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/5130214053f83b415a1cd7f9997ff88b05397520/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Status: Fixed (was: Started)

Sign in to add a comment