New issue
Advanced search Search tips

Issue 810375 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

list of web pages displayed on long press of forward button in NTP is not being dismissed

Project Member Reported by rakurati@chromium.org, Feb 8 2018

Issue description

App Version: 65.0.3325,53 Beta
iOS Version: 11.3 beta and 10.3.3
Device: iPhone and iPad

Steps to reproduce:
1. Launch chrome 
2. Launch any webpage or tap on any article from content suggestions
3. Go back to NTP page and long press on the enabled forward button until the recently visited page is displayed in menu
4. Scroll down to today’s view 
5. Tap on the new search button

Observed results:
Notice that cursor is highlighted in the omnibox but the list box opened on long press is not dismissed

Expected results:
The list should be dismissed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on M64
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M65

Link to video/image:
https://drive.google.com/file/d/1dMIS5c8qzsQTL-S6FsZ7lWCQR40os8ZT/view?usp=sharing

 

Comment 1 by pkl@chromium.org, Feb 12 2018

Cc: stkhapugin@chromium.org sczs@chromium.org
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Toolbar: Goes to gambard and cc a few others.
Components: -UI>Browser>NewTabPage UI>Browser>Navigation
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da7e0fe38fb090d03bd64b0b10a6fca5a68efca6

commit da7e0fe38fb090d03bd64b0b10a6fca5a68efca6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Feb 14 07:56:33 2018

Dismiss navigation menu when clearing presented state

When the app is foregrouneded, the presented state is cleared,
dismissing all the presented modals. The navigation popup wasn't
dismissed. This CL fixes it.

Bug:  810375 
Change-Id: Iddd42daeb722f6b0f03bb387f816bc0629493d8c
Reviewed-on: https://chromium-review.googlesource.com/916041
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536673}
[modify] https://crrev.com/da7e0fe38fb090d03bd64b0b10a6fca5a68efca6/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/da7e0fe38fb090d03bd64b0b10a6fca5a68efca6/ios/chrome/browser/ui/commands/history_popup_commands.h
[modify] https://crrev.com/da7e0fe38fb090d03bd64b0b10a6fca5a68efca6/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on M66.0.3351.0 canary
iPhoneX, iOS11.3
Navigation menu is dismissed correctly and omnibox is focused.

Sign in to add a comment