New issue
Advanced search Search tips

Issue 810371 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-02-12
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

During audio pipeline issues, delay estimation realignment causes echo leakage when AEC3 is used

Project Member Reported by peah@chromium.org, Feb 8 2018

Issue description

When there are audio pipeline issues that results in echo path delay adjustments, the resulting realignments done in AEC3 may cause echo leakage. 
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f4d1134bdcfece4e81e9a988a547090b7b0f6e81

commit f4d1134bdcfece4e81e9a988a547090b7b0f6e81
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Feb 08 14:40:29 2018

Adjusted tunings to increase AEC3 robustness against pipeline issues


Bug:  chromium:810371 , webrtc:8862 
Change-Id: I2bfd3601c41caf608c21bec27133a175e3a7f2c5
Reviewed-on: https://webrtc-review.googlesource.com/49782
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21958}
[modify] https://crrev.com/f4d1134bdcfece4e81e9a988a547090b7b0f6e81/modules/audio_processing/include/audio_processing.h

Comment 2 by peah@chromium.org, Feb 8 2018

Labels: Merge-Request-65
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: Less than 22 days to go before AppStore submit on M65
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Before we approve merge to M65, could you pls confirm followings?

Is this M65 regression and critical to merge?
Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge?
Any other imp details to justify the merge.

Please note M65 is already promoted to Beta so merge bar is very high. Thank you.

Comment 5 by peah@chromium.org, Feb 8 2018

The change significantly reduces the increased sensitivity to audio pipeline issues that was introduced in AEC3 in M65. Without this change, audio pipeline issues causes echo bursts and since there is a problem with frequent such issues the impact of this regression is significant.

It has been thoroughly tested on recordings and local Chromium build on Linux but not in Canary. Since it anyway missed the Beta build it won't hurt if it bakes in Canary for some more days.
NextAction: 2018-02-12
Ok, pls update the bug with canary result on Monday. Thank you.
The NextAction date has arrived: 2018-02-12

Comment 8 by gov...@chromium.org, Feb 12 2018

How is the change looking in canary?

Comment 9 by peah@chromium.org, Feb 13 2018

The results for the change looks good in UMA for canary.
Labels: -Merge-Review-65 Merge-Approved-65
Approving merge to M65 branch 3325 based on comments #5 and #9. Please merge ASAP so we can pick it up for tomorrow's beta release. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 13 2018

Labels: merge-merged-65
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a298c261a79c272840b100b3d940ab0e7ca58121

commit a298c261a79c272840b100b3d940ab0e7ca58121
Author: Per Åhgren <peah@webrtc.org>
Date: Tue Feb 13 19:44:27 2018

Merge to M65: Adjusted tunings to increase AEC3 robustness against ...

TBR=gustaf@webrtc.org,henrik.lundin@webrtc.org
(cherry picked from commit f4d1134bdcfece4e81e9a988a547090b7b0f6e81)

Bug:  chromium:810371 , webrtc:8862 
Change-Id: I2bfd3601c41caf608c21bec27133a175e3a7f2c5
Reviewed-on: https://webrtc-review.googlesource.com/49782
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#21958}
Reviewed-on: https://webrtc-review.googlesource.com/52642
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/65@{#18}
Cr-Branched-From: 3ac67a736bb200ecf7c116a88b2f8d5c542973c8-refs/heads/master@{#21637}
[modify] https://crrev.com/a298c261a79c272840b100b3d940ab0e7ca58121/modules/audio_processing/include/audio_processing.h

Comment 12 by peah@chromium.org, Feb 13 2018

Labels: M-65
Status: Fixed (was: Assigned)
Labels: -M-65 -Merge-Approved-65
Status: Assigned (was: Fixed)
Removing "Merge-Approved-65" label as it is already merged to M65 at #11. Thank you.

Comment 14 by peah@chromium.org, Feb 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment