New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810362 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Seriff-o-Matic does not show notifications for Win7 Tests (dbg) exceptions

Project Member Reported by olka@chromium.org, Feb 8 2018

Issue description

Builder:
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/

The last 30+ builds ended with an exception, but there are no notifications in SoM.

Example of a build with an exception:
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66211

(also filed http://crbug.com/810347 for an exception itself)
 

Comment 1 by olka@chromium.org, Feb 8 2018

Labels: Sheriff-Chromium
Sheriff-Chromium label FYI
Cc: st...@chromium.org
Components: -Infra Tools>Test>FindIt
Shuotao, you're working on Sheriff-o-matic and related things, no?

Comment 3 by st...@chromium.org, Feb 8 2018

Cc: seanmccullough@chromium.org
Components: -Tools>Test>FindIt Infra>Sheriffing>SheriffOMatic
Sean owns Sheriff-o-Matic. I'm working on Findit and flakiness detection/analysis/etc :)

Comment 4 by olka@chromium.org, Feb 9 2018

Owner: seanmccullough@chromium.org
Status: Assigned (was: Untriaged)
Log example from SoM's analyzer:

error getting build chromium.win/Win7 Tests (dbg)(1)/66234: Post https://luci-milo.appspot.com/prpc/milo.Buildbot/GetBuildbotBuildJSON: context deadline exceeded

So it's unable to analyze these builds because it can't get their build records in time from milo. 

This repro's locally, so I can dig into that.
I think I have a fix for this. Out for review: https://chromium-review.googlesource.com/c/infra/infra/+/912350


Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/be81ac0c17d1874c191e9ad6d43d57bc6b36e1f4

commit be81ac0c17d1874c191e9ad6d43d57bc6b36e1f4
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Feb 09 21:06:35 2018

[som] Increase RPC deadlines

Bug:810362
Change-Id: I2a795f51b316cf3843e59082f7545ec66b0fc3aa
Reviewed-on: https://chromium-review.googlesource.com/912350
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/be81ac0c17d1874c191e9ad6d43d57bc6b36e1f4/go/src/infra/appengine/sheriff-o-matic/som/client/client.go

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7227dbef5e5bd514ed7d626b9f00825730a2f868

commit 7227dbef5e5bd514ed7d626b9f00825730a2f868
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Fri Feb 09 21:19:18 2018

[som] Update RELNOTES.md for an off-schedule push.

TBR=zhangtiff

Bug:  810362 
Change-Id: I5616d3b6b0177a9856dc787f2be917fedbe812d3
Reviewed-on: https://chromium-review.googlesource.com/912366
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/7227dbef5e5bd514ed7d626b9f00825730a2f868/go/src/infra/appengine/sheriff-o-matic/RELNOTES.md

Comment 11 by olka@chromium.org, Feb 12 2018

Status: Verified (was: Started)
Thanks a ton!

Sign in to add a comment