New issue
Advanced search Search tips

Issue 810335 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 17
Cc:
atotic@chromium.org
ikilpatrick@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[LayoutNG] Quirky margin behavior not quirky enough

Project Member Reported by mstensho@chromium.org, Feb 8 2018 
LayoutTests/fast/block/float/003.html fails in LayoutNG because the bottom margin of an empty OL element at the beginning of a quirky container (BODY in this case) isn't ignored. See tc.html

Our html.css stylesheet defines an OL's top margin as quirky, while the bottom margin is not. P elements, on the other hand, define both the top and bottom margins as quirky. All other elements that have quirky margins actually only define their top margin as quirky. It's just P that wants both its margins to be quirky, apparently.

I traced this behavior way back to the early 2000s and gave up.
tc.html
241 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4794a33ef0d1670121259703ffd3e8adf1f14b2

commit f4794a33ef0d1670121259703ffd3e8adf1f14b2
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Feb 08 15:27:02 2018

[LayoutNG] Dedicated bug for fast/block/float/003.html

TBR=atotic@chromium.org

Bug:  810335 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6e20a233e2dab7a71e5a82b101a33daf2169ae5e
Reviewed-on: https://chromium-review.googlesource.com/908463
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535386}
[modify] https://crrev.com/f4794a33ef0d1670121259703ffd3e8adf1f14b2/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/f4794a33ef0d1670121259703ffd3e8adf1f14b2/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b25664053b94fd4fc4e6784e9796c7038fe968f

commit 4b25664053b94fd4fc4e6784e9796c7038fe968f
Author: Peter Mayo <petermayo@chromium.org>
Date: Mon Jul 16 21:05:40 2018

Re-enable Quirky Margin test.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=block%2Ffloat%2F003.html

show that this test has been consistently passing for a while now.

This looks like it was fixed here
https://chromium-review.googlesource.com/1124071 but the Expectations
were not fixed in the main expectations too.


Bug:  810335 
Change-Id: Id01dcb0032e57cd191da746275b4ca4d9438c1e6
Reviewed-on: https://chromium-review.googlesource.com/1138733
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575418}
[modify] https://crrev.com/4b25664053b94fd4fc4e6784e9796c7038fe968f/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by e...@chromium.org, Jul 17

Status: Fixed (was: Available)
Closing as per comment 2.
►

Sign in to add a comment