Thanks for the report.  That's pretty weird.

I can reproduce this too (also on Mac; I didn't try other platforms).

I think I know what's happening.  Sometimes the omnibox decides to display suggestions when the user focuses on the box.  In this suggestion list, the current page URL always appears first.  It appears if you focus the box and paste in it fast enough, you can get in a state where the box is showing the on-focus suggestions while the text displayed is the pasted text.

To repro:
1. have a profile where on-focus suggestions work (sync enabled, google default search engine, etc.)
2. find a page which displays those suggestions.  (Focus the omnibox, see the suggestions, click back in the content area.)
3. copy some text.
4. quickly press command-l to focus the omnibox then command-v to paste the text.

Witness the on-focus suggestions appear yet the text in the omnibox is the pasted text.

If you do step 4 slowly (say, a half second beat between command-l and command-v), then the problem doesn't reproduce.


krb@, as someone who's familiar with some focus issues, and also somewhat familiar with the Mac UI code, can you look into this?

fwiw, I can't duplicate it. On canary, I can produce a pop-up with the paste as a search in the first slot. On ToT, it doesn't want to generate results.

I'll try just speculating about the code.

> On ToT, it doesn't want to generate results.
It == ?  On-focus suggestions?  The omnibox as a whole?

> On canary, I can produce a pop-up with the paste as a search in the first slot.
Can you confirm that you're trying this on a Mac that normally would show on-focus suggestions?

Have any of your Classify() refactorings touched the Mac flow in a way that might be affected?  (Can you try to reproducing on current M-64 to make sure you're trying the same thing we are?)

> It == ?  On-focus suggestions?  The omnibox as a whole?

> Can you confirm that you're trying this on a Mac that normally would show on-focus suggestions?

Take 2: Canary produces a drop-down on focus, but all pasting does is produce suggestions for the paste. ToT doesn't produce a drop-down on focus; it only highlights the text.

> Have any of your Classify() refactorings touched the Mac flow in a way that might be affected?  (Can you try to reproducing on current M-64 to make sure you're trying the same thing we are?)

Stable doesn't produce a drop-down either. Is there some trick to it? I'm signed in everywhere and I'm visiting amazon.com.

There's no trick.  There are a lot of restrictions on when it triggers, but most (all?) of those restrictions part of your profile that is synced.  (You are syncing right, not just signed-in?)  Maybe you're in stable experiment that doesn't show the suggestions on https://amazon.com/?  Try another site like http://garydanko.com/ ?

Ok, some progress. I blew away every profile that I could find, re-logged in and got some more drop-downs to appear. (Many times it requires shutting Chrome down and re-starting. And ToT won't even let me sign in now; not sure what's up.)

So the "good" news is that I got canary to duplicate the issue. The bad news is that I got M63 to duplicate the issue. So it would appear to be a long standing race condition.

And just so I'm on the same page (and for other readers), the above video does not show the problem. Rather, for a single frame, it shows the paste along with lots of Amazon suggestions, and then is quickly replaced with suggestions for the paste, ya?

What I'm seeing stays indefinitely.

Glad you can repro!

What I'm seeing stays indefinitely too.  (I think the original reporter quickly moved on and did something else, which is why it doesn't show it staying for long.)

Re-visiting this, I'm back to not being able to reproduce it. Is it possible this was fixed by the zero suggest change?

I can no longer reproduce this in Chrome 68 (on Mac).  I think it's fixed, likely by the same solution as bug 825318.