New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Unnecessarily Google Name servers is getting selected when clicked on Learn more link in Network section of chrome://settings

Project Member Reported by kebalaji@chromium.org, Feb 8 2018

Issue description

Chrome Version: 66.0.3342.0./10384.0.0 dev-channel Kip, Peppy and Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Navigate to chrome://settings
(2)Click on Wifi name>> In Network section, Click on Learn more link beside Google name servers and Observe

Expected: Unnecessarily Google Name servers is getting selected
Actual: Google Name servers shouldn't get selected

This is a Non-Regression issue seen from M64

NOTE: 1. Issue is not seen on Windows and Linux
      2. Issue is seen on M64 beta and M65 dev also

@Stevenjb: Please confirm the issue
 
ActualLearnmore.webm
1.1 MB View Download
ExpectedLearnmorelink.webm
436 KB View Download
Labels: Inhouse-HYD-Reported
Labels: -M-66 M-65
This is confusing. Let's fix this for 65, it should be a quick/easy fix.

Status: Started (was: Assigned)

Comment 4 Deleted

Labels: Merge-Request-65
Simple / isolated fix.

Summary: Regression: Unnecessarily Google Name servers is getting selected when clicked on Learn more link in Network section of chrome://settings (was: Non-Regression: Unnecessarily Google Name servers is getting selected when clicked on Learn more link in Network section of chrome://settings )
Note: This bug was in 64 also, but it is a regression in the new Settings UI.

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35328cc5ac8aafaefff8a50077074374ff5a77a0

commit 35328cc5ac8aafaefff8a50077074374ff5a77a0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Feb 13 21:08:54 2018

Network details: nameservers: stop learn more propagation

Bug:  810328 
Change-Id: I511732bfc5429c58477b09a33fb8d83f3ba10539
Reviewed-on: https://chromium-review.googlesource.com/914925
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536472}
[modify] https://crrev.com/35328cc5ac8aafaefff8a50077074374ff5a77a0/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[modify] https://crrev.com/35328cc5ac8aafaefff8a50077074374ff5a77a0/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js

Project Member

Comment 9 by sheriffbot@chromium.org, Feb 14 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 21 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c8694caf589c8074c8bafcf4cc70c2ea7c4dd2d

commit 3c8694caf589c8074c8bafcf4cc70c2ea7c4dd2d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Feb 21 19:01:19 2018

Network details: nameservers: stop learn more propagation

TBR=stevenjb@chromium.org

(cherry picked from commit 35328cc5ac8aafaefff8a50077074374ff5a77a0)

Bug:  810328 
Change-Id: I511732bfc5429c58477b09a33fb8d83f3ba10539
Reviewed-on: https://chromium-review.googlesource.com/914925
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536472}
Reviewed-on: https://chromium-review.googlesource.com/929582
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#539}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/3c8694caf589c8074c8bafcf4cc70c2ea7c4dd2d/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html
[modify] https://crrev.com/3c8694caf589c8074c8bafcf4cc70c2ea7c4dd2d/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js

Sign in to add a comment