New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810327 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Last third digit of browsing history appears to be misaligned in remove this person overlay.

Reported by vku...@etouch.net, Feb 8 2018

Issue description

Chrome Version:66.0.3343.0 (Official Build) Revision ceb89e8235ab8b934c9cbe424543ccdd160933d4-refs/heads/master@{#535276} (32/64 bit) 
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4)

Precondition: Login into browser with credentials which has wide(long) browsing history data.

What steps will reproduce the problem?
(1)Launch chrome click on avatar icon > Manage people
(2)Click on 'remove this persion' from iron icon such that list of details appear.
(3)Observe last 3rd digit of browsing history.

Actual: Last third digit of browsing history appears to be misaligned in remove this person overlay.

Expected: Data of browsing history should be properly displayed in remove this person overlay.

This is a regression issue broken in 'M65' and below is the manual bisect info
Good Build: 65.0.3287.0 (Revision:522297)
Bad Build: 65.0.3288.0  (Revision:522666)

Note: The above issue is also seen on Dev build #65.0.3325.51



 
Actual_Result.png
126 KB View Download
Expected_Result.png
111 KB View Download

Comment 1 by vku...@etouch.net, Feb 8 2018

Labels: hasbisect-per-revision RegressedIn-65 FoundIn-66 Target-66 Target-65 FoundIn-65
Owner: mstensho@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 522407 (known good), but no later than 522408 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/8448affe3471114a8be3a25198083c6f8ab3f103..eee88582b5300e34aa2ea56bc5da17457e67aa00

Suspecting: https://chromium.googlesource.com/chromium/src/+/eee88582b5300e34aa2ea56bc5da17457e67aa00

@mstensho: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
                      
I'll be able to take a look sooner if you provide a simplified HTML test case. I don't build full Chrome that often.
Labels: Needs-Feedback
I can't get browsing history to show up when attempting to remove a person. Any other way to reproduce?

If not, please provide a reduced HTML test case.

Comment 4 by ew...@chromium.org, Feb 10 2018

Labels: -Pri-1 Pri-2
Marking this as P2, since it's not a high-traffic surface or flow.
Owner: ----
Status: Available (was: Assigned)
With no means of reproducing this, I can't do anything.

Comment 6 by vku...@etouch.net, Feb 13 2018

Labels: -Needs-Feedback
With response to comment #3:
Above issue is still reproducible on latest canary version 66.0.3346.0 (Official Build). Please refer below mentioned steps 

Precondition: Create a fresh user and do not login into browser.
Steps:
1.Launch chrome and navigate to chrome://settings/ > Import bookmarks and settings
2.Select a browser which has browsing history for e.g Firefox or IE, click on import button.
3.Click on avatar icon > Manage people, click on 'remove this person' from iron icon such that list of details appear, observe lats digit of browsing history.

Note: Browsing history range should be more then or 100 (i.e 3 digit)

Please refer attached screencast for the same

Thank you!

Comment 7 by vku...@etouch.net, Feb 13 2018

Actual_Result.mov
1.4 MB View Download

Comment 8 by vku...@etouch.net, Feb 13 2018

Please find attached long history.html file and video for reference 
Long history.html.html
113 KB View Download
Actual_html.mov
7.1 MB View Download
Owner: mstensho@chromium.org
Status: Assigned (was: Available)
Reassigning to mstensho@ and friendly ping: is this actionable now? Thanks!
Thanks! I can reproduce this.
The suspected CL in #c1 is the one.
Further reductions should be possible, such as removing word-wrap:break-word. Although that is what causes the wrapping in the Chrome UI, the root cause seems to be that preferred min/max widths aren't recalculated when table cells change their contents.
tc.html
506 bytes View Download
Labels: -OS-Linux -OS-Windows -OS-Mac
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b335696ddcf6980440759a57400c34db42a1a05

commit 6b335696ddcf6980440759a57400c34db42a1a05
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Apr 10 10:47:54 2018

Make sure table flex/grid items recalculate min/max widths.

We used to rely on this taking place lazily via
MinPreferredLogicalWidth(), but that method won't necessarily be called
if the table is a flex/grid item.

Bug:  810327 
Change-Id: Ic817bd109544d4b9e961552d0a3a38f127e6e548
Reviewed-on: https://chromium-review.googlesource.com/1000781
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549479}
[add] https://crrev.com/6b335696ddcf6980440759a57400c34db42a1a05/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox/table-as-item-change-cell.html
[modify] https://crrev.com/6b335696ddcf6980440759a57400c34db42a1a05/third_party/blink/renderer/core/layout/layout_table.cc

Status: Fixed (was: Assigned)
Cc: phanindra.mandapaka@chromium.org
 Issue 845445  has been merged into this issue.
Issue 841197 has been merged into this issue.

Sign in to add a comment