New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810311 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Regression : 'App info' overlay of one user is seen in other user in Multiple sign-in User

Project Member Reported by mmanchala@chromium.org, Feb 8 2018

Issue description

Chrome Version:  66.0.3342.0./10384.0.0 dev-channel Kip,Peppy and Reks
OS: Chrome

What steps will reproduce the problem?
1)Sign in to user -> logout -> sign in to another user -> Go to Uber tray ->click on user I'd and select 'Sign in to another user...' option for Multiple sign-in
2)Now in any user click on App launcher -> at 'All Apps' select any app(Ex: Google photos)and right click for context menu -> select 'App info' option
3)Now click on Uber Tray and observe  'App info' overlay is still seen -> now select other account form Uber Tray and observe in other account also  'App info' overlay is seen
(Please refer Video)

Expected: 
a) 'App info' overlay should get closed after clicking on Uber Tray 
b)After switching to other account 'App info' overlay of other user should not be seen

Actual: Instead
a)App info' overlay is still seen after clicking on Uber Tray 
b)After switching to other account 'App info' overlay of other user is seen

This is a Regression issue as same is working fine in 65.0.3325.56/10323.21.0 dev-channel Peppy

@omrilo: Please confirm the Issue
 
Actual_AppInfoOverlayBehavior.mp4
13.2 MB View Download
Attaching Expected video for reference
Expected_AppInfoOverlay.mp4
12.5 MB View Download
Labels: ReleaseBlock-Beta
Adding 'Beta Blocker' label, please feel free to remove the label if not required

Labels: Touch-Friendly-Launcher-Urgent
Cc: omrilio@chromium.org
Owner: newcomer@chromium.org
Status: Started (was: Assigned)
Labels: -ReleaseBlock-Beta
I have a fix for this, but it isn't really a beta blocker. Removing label!
Cc: xiy...@chromium.org
Xiyuan,

My fix for this involves making the dialog a UserSessionStateObserver.

This doesn't seem like the best fix. Is there some window clean-up involved when a user switches state, that is missing this dialog?


Re #6.

s/When a user switches state/When a user switches profiles

Comment 8 by xiy...@chromium.org, Feb 16 2018

Cc: hejq@chromium.org
The regression happens because app info dialog is no longer a child of app launcher UI. This is because the UI is going to be moved to ash but app info would stay in chrome and we don't have a way to maintain transient relationship between windows of two process. :(

Maybe we should make app info dialog to auto dismiss itself when it is no longer active, like a system tray bubble.
Labels: -Pri-1 Pri-2
Labels: -Touch-Friendly-Launcher-Urgent
Cc: newcomer@chromium.org ginko@chromium.org
Labels: -M-66 M-71
Owner: ----
Owner: weidongg@chromium.org
Status: Assigned (was: Started)
weidongg can you please triage this?
Cc: weidongg@chromium.org
Owner: ----
It's in the M-71 hotlist for our team (already triaged).
Status: Available (was: Assigned)
Components: UI>Shell>Launcher
Labels: -M-71 M-72
Labels: -M-72 M-73
Labels: -M-73 M-74

Sign in to add a comment