New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810310 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression : Clicking inactive user icon does not focus password

Project Member Reported by mmanchala@chromium.org, Feb 8 2018

Issue description

Chrome Version:  66.0.3342.0./10384.0.0 dev-channel Kip,Peppy and Reks
OS: Chrome

What steps will reproduce the problem?
1)Sign in to user(Ex: A account) -> logout -> sign in to another user(Ex: B account) -> Go to Uber tray ->In second User(B account)click on user I'd and select 'Sign in to another user...' option for Multiple sign-in
2)Now in any user -> Click on Uber Tray and select 'Lock' option
3)In Lock screen observe password field is seen missing for other User(For A account)
(Please refer Video and Screenshot)
 
Expected: Password field should be seen for both users in Lock screen
Actual: Instead password field is seen missing for other User

This is a Regression issue as issue is working fine in M-63

@wzang: Please confirm the Issue

Note: Issue is also seen on M-64 and M-65
 
Actual_PasswordFieldIsMissing.mp4
15.7 MB Download
Actual_PasswordFieldIsMissing.jpg
330 KB View Download
Attaching Expected video for reference
Expected_PasswordField.mp4
15.8 MB Download
Cc: songsuk@chromium.org
Labels: ReleaseBlock-Stable
Adding 'Stable Blocker' label, please feel free to remove the label if not required

@wzang: Could you please confirm if this should be blocking M-64 stable also?
Just follow where the box should be and see if you can log in, if not, still report it as well.

Comment 4 by wzang@chromium.org, Feb 8 2018

Cc: jdufault@chromium.org
You can still sign in, but clicking around the password field doesn't activate the pod. Have to click on the name or the image instead (Please refer to video).

+jdufault@ on how we want to address this.
VID_20180208_105906.mp4
19.4 MB Download

Comment 5 Deleted

Owner: jdufault@chromium.org
Status: Assigned (was: WontFix)
We may want to fix the issue where clicking the password field doesn't open the pod, but keeping the actual textfield hidden is an intentional design decision.
Cc: -jdufault@chromium.org wzang@chromium.org
Labels: -Pri-1 Pri-2
Summary: Regression : Clicking inactive user icon does not focus password (was: Regression : Password field is seen missing for one of the User at Lock screen in Multiple sign-in mode)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a1bf4b447082c35058966ecf45abd86bf8f6e7

commit 58a1bf4b447082c35058966ecf45abd86bf8f6e7
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Jul 10 17:44:56 2018

cros: Focus password if user clicks user that is not focused.

Right now the click does nothing, so this improves UX a bit by making it easier
to refocus password.

Also fix error message conditional in login_screen_controller, and simplify
LockContentsViewUnitTest.AuthUserSwapFocusesPassword.

Bug:  810310 
Change-Id: Idd547c32083755519f7b3121488cfcbb928a43c2
Reviewed-on: https://chromium-review.googlesource.com/1129852
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573800}
[modify] https://crrev.com/58a1bf4b447082c35058966ecf45abd86bf8f6e7/ash/login/login_screen_controller.cc
[modify] https://crrev.com/58a1bf4b447082c35058966ecf45abd86bf8f6e7/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/58a1bf4b447082c35058966ecf45abd86bf8f6e7/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/58a1bf4b447082c35058966ecf45abd86bf8f6e7/ash/login/ui/login_test_utils.cc
[modify] https://crrev.com/58a1bf4b447082c35058966ecf45abd86bf8f6e7/ash/login/ui/login_test_utils.h

Status: Fixed (was: Started)

Sign in to add a comment