New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810307 link

Starred by 1 user
Status: Fixed
Owner:
katie@chromium.org
Closed: Sep 11
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Non-Regression: No action is performed on toggle button of Highlighting section when hitting Enter key in Select-to-speak settings page

Project Member Reported by rkalavakuntla@chromium.org, Feb 8 2018 
Chrome Version:66.0.3342.0./10384.0.0 dev-channel Kip,Reks,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user ->go to chrome://settings/manageAccessibility ->In text-to Speech,enable Select-to-speak 
(2)Open Select-to-speak settings page(i.e.,chrome-extension://klbcgckkldhdhonijdbnhhaiedfkllef/options.html)
(3)Enable ChromeVox >>Keep Chromevox reader focus on toggle button of Highlighting >>Hit Enter and Observe

Actual:No action is performed when hitting Enter
Expected:Enable/disable action of toggle button should occur.

This is a Non-Regression issue seen from M-64.

Note:Issue is not seen in Linux,Windows OS

Attached the screencast for reference..
Actual.mp4
13.1 MB View Download

Comment 1 by katie@chromium.org, Sep 7

Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Comment 2 by katie@chromium.org, Sep 7

Components: -UI>Accessibility UI>Accessibility>SelectToSpeak

Comment 3 by katie@chromium.org, Sep 7

Owner: katie@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acfd829c501c6ca764a7f5ee361170f3411974a4

commit acfd829c501c6ca764a7f5ee361170f3411974a4
Author: Katie D <katie@chromium.org>
Date: Tue Sep 11 23:35:10 2018

Makes STS toggle button label clickable and work with enter key.

This copies behavior on chrome://settings pages where tapping
anywhere in the option box can change the state of the toggle,
or having keyboard focus on an toggle element and clicking 'enter'
changes the state.

Bug:  810333 , 810307 
Change-Id: Ib6edc31fff72f2e32c5b9ce73264739a3d3194c1
Reviewed-on: https://chromium-review.googlesource.com/1214366
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590530}
[modify] https://crrev.com/acfd829c501c6ca764a7f5ee361170f3411974a4/chrome/browser/resources/chromeos/select_to_speak/options.css
[modify] https://crrev.com/acfd829c501c6ca764a7f5ee361170f3411974a4/chrome/browser/resources/chromeos/select_to_speak/options.html
[modify] https://crrev.com/acfd829c501c6ca764a7f5ee361170f3411974a4/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js

Comment 5 by katie@chromium.org, Sep 11

Status: Fixed (was: Started)
►

Sign in to add a comment