test-results.appspot.com should send Content-Type: text/plain for ".txt" file extension |
|||||
Issue descriptionLayout test result viewer[1] shows failure log text in IFRAME like: <iframe class="text-file-viewer-iframe" src="https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/642517/layout-test-results/editing/selection/mixed-editability-8-actual.txt" tabindex="-1"></iframe> So far, test-results.appspot.com sends Content-Type: text/plain, but from today (not sure actual time), it sends Content-Type: text/html. This makes Blink developers hard to analyze layout test failures. [1] https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/642517/layout-test-results/results.html
,
Feb 8 2018
,
Feb 8 2018
Should this have been assigned to me? I'll take a look anyways...
,
Feb 8 2018
Should be a quick fix.
,
Feb 8 2018
(sent out https://chromium-review.googlesource.com/c/infra/infra/+/909858 which fixed locally)
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3af74197ac766370df86845086d47fa3c0b4cf4a commit 3af74197ac766370df86845086d47fa3c0b4cf4a Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Feb 08 22:38:05 2018 Test results zip handler: Set content type Bug: 810300 Change-Id: Id9527d84d70805571f5a60ebf06fa4ca2670b6bb Reviewed-on: https://chromium-review.googlesource.com/909858 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/3af74197ac766370df86845086d47fa3c0b4cf4a/go/src/infra/appengine/test-results/frontend/zip.go
,
Feb 8 2018
This works locally, but not on https://13946-3af7419-dot-test-results-test-hrd.appspot.com/data/layout_results/linux_chromium_rel_ng/642517/layout-test-results/results.html. Not sure why exactly....
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cedbdaa76fe136060e6285b23f79f4b485ef2fdf commit cedbdaa76fe136060e6285b23f79f4b485ef2fdf Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Feb 08 23:46:57 2018 Test results zip handler: Fix header order Content-Type was being set after a header was written. When testing locally, this worked fine, but it appears the response writer implementation is different in production than when testing on the development server. Bug: 810300 Change-Id: I3203ca0e50c154c9a0b40fdeef87047ba34455ad Reviewed-on: https://chromium-review.googlesource.com/910040 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/cedbdaa76fe136060e6285b23f79f4b485ef2fdf/go/src/infra/appengine/test-results/frontend/zip.go
,
Feb 9 2018
Found the issue in #8. Fix is live! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jchin...@chromium.org
, Feb 8 2018Components: -Infra>Platform>Buildbot Infra>Flakiness>Dashboard
Status: Available (was: Untriaged)