"FastUnloadTest.WindowCloseAfterBeforeUnloadCrash" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBGYXN0VW5sb2FkVGVzdC5XaW5kb3dDbG9zZUFmdGVyQmVmb3JlVW5sb2FkQ3Jhc2gM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Crashes [https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F645993%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests_on__none__GPU_on_Mac__with_patch_%2F0%2Flogs%2FFastUnloadTest.WindowCloseAfterBeforeUnloadCrash%2F0} [ RUN ] FastUnloadTest.WindowCloseAfterBeforeUnloadCrash [11774:13063:0207/150745.438491:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-02-07 15:07:45.569 browser_tests[11774:139632] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. [11774:775:0207/150745.941799:WARNING:sad_tab.cc(276)] Tab Killed: [11774:775:0207/150745.954022:FATAL:sad_tab.cc(198)] Check failed: !recorded_paint_. 0 browser_tests 0x000000010e6d182c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x000000010e6f6590 logging::LogMessage::~LogMessage() + 224 2 browser_tests 0x0000000112502398 SadTab::RecordFirstPaint() + 88 3 AppKit 0x00007fff440548b2 -[_NSViewBackingLayer display] + 407 4 QuartzCore 0x00007fff51a60d3b CA::Layer::display_if_needed(CA::Transaction*) + 633 5 QuartzCore 0x00007fff51a607f9 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 35 6 QuartzCore 0x00007fff51a5f894 CA::Context::commit_transaction(CA::Transaction*) + 326 7 QuartzCore 0x00007fff51a5f43d CA::Transaction::commit() + 487 8 AppKit 0x00007fff4480b658 __65+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayRefresh]_block_invoke + 283 9 CoreFoundation 0x00007fff46950127 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 10 CoreFoundation 0x00007fff4695004f __CFRunLoopDoObservers + 527 11 CoreFoundation 0x00007fff469326a8 __CFRunLoopRun + 1240 12 CoreFoundation 0x00007fff46931f43 CFRunLoopRunSpecific + 483 13 HIToolbox 0x00007fff45c49e26 RunCurrentEventLoopInMode + 286 14 HIToolbox 0x00007fff45c49b96 ReceiveNextEventCommon + 613 15 HIToolbox 0x00007fff45c49914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 16 AppKit 0x00007fff43f14f5f _DPSNextEvent + 2085 17 AppKit 0x00007fff446aab4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 18 browser_tests 0x000000010e8990e0 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 19 browser_tests 0x000000010e6f8f8a base::mac::CallWithEHFrame(void () block_pointer) + 10 20 browser_tests 0x000000010e899024 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 21 AppKit 0x00007fff43f09d6d -[NSApplication run] + 764 22 browser_tests 0x000000010e71639c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 23 browser_tests 0x000000010e7145fe base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 24 browser_tests 0x000000010e711039 base::MessageLoop::Run(bool) + 169 25 browser_tests 0x000000010e74efc9 base::RunLoop::Run() + 249 26 browser_tests 0x000000010efe0679 content::MessageLoopRunner::Run() + 153 27 browser_tests 0x000000010ef81101 content::CrashTab(content::WebContents*) + 209 28 browser_tests 0x000000010af700f2 FastUnloadTest_WindowCloseAfterBeforeUnloadCrash_Test::RunTestOnMainThread() + 226 29 browser_tests 0x000000010ef7f6f4 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 404 30 browser_tests 0x000000010e89f380 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4784 31 browser_tests 0x000000010e89dfce ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 32 browser_tests 0x000000010c894613 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 33 browser_tests 0x000000010cde2eb5 content::StartupTaskRunner::RunAllTasksNow() + 117 34 browser_tests 0x000000010c892c3d content::BrowserMainLoop::CreateStartupTasks() + 765 35 browser_tests 0x000000010c8972b3 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 99 36 browser_tests 0x000000010c890b62 content::BrowserMain(content::MainFunctionParams const&) + 210 37 browser_tests 0x000000010e5ccd45 content::ContentMainRunnerImpl::Run() + 565 38 browser_tests 0x000000011104ec42 service_manager::Main(service_manager::MainParams const&) + 2482 39 browser_tests 0x000000010e5cc0d4 content::ContentMain(content::ContentMainParams const&) + 68 40 browser_tests 0x000000010ef7f339 content::BrowserTestBase::SetUp() + 3193 41 browser_tests 0x000000010e7f3b79 InProcessBrowserTest::SetUp() + 505 42 browser_tests 0x000000010bad5fd1 testing::Test::Run() + 97 43 browser_tests 0x000000010bad6c70 testing::TestInfo::Run() + 288 44 browser_tests 0x000000010bad7297 testing::TestCase::Run() + 263 45 browser_tests 0x000000010badf897 testing::internal::UnitTestImpl::RunAllTests() + 903 46 browser_tests 0x000000010badf4e3 testing::UnitTest::Run() + 163 47 browser_tests 0x000000010e816367 base::TestSuite::Run() + 167 48 browser_tests 0x000000010e6b7d65 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 49 browser_tests 0x000000010efda59e content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 478 50 browser_tests 0x000000010e6b827c LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 348 51 browser_tests 0x000000010e6b7cbe main + 94 52 libdyld.dylib 0x00007fff6e245115 start + 1
Disabling it here https://chromium-review.googlesource.com/c/chromium/src/+/908549
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c648678d403fd517aa15e6fcf70caad58e788cfe commit c648678d403fd517aa15e6fcf70caad58e788cfe Author: Olga Sharonova <olka@chromium.org> Date: Thu Feb 08 13:03:37 2018 Disabling FastUnloadTest.WindowCloseAfterBeforeUnloadCrash on Mac (crashes, see the bug) TBR=avi@chromium.org Bug: 810294 Change-Id: I812baa744dd887eba9eb2087913c0df53893c261 Reviewed-on: https://chromium-review.googlesource.com/908549 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#535364} [modify] https://crrev.com/c648678d403fd517aa15e6fcf70caad58e788cfe/chrome/browser/unload_browsertest.cc
Sidney, this crash is in a DCHECK that you added in https://codereview.chromium.org/2261793002. Can you take a look?
This DCHECK is gone as of
Whoops, I didn't mean to add that comment. The M-71 tag stays, though.
Adding a blocker, to be closed later.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78267f5c868ebd407eda67c47adc1f8c5505292a commit 78267f5c868ebd407eda67c47adc1f8c5505292a Author: Avi Drissman <avi@chromium.org> Date: Wed Jan 16 21:21:42 2019 Remove Fast Tab Closure. It has been unowned and not worked on since 2013. BUG=142458, 248998 , 250305 , 250760 , 263566 , 267597 , 279267 , 301173 , 810294 Change-Id: If1f01d42aa653d754629ac69214ef835df43e821 Reviewed-on: https://chromium-review.googlesource.com/c/1410004 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#623372} [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/about_flags.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/flag-metadata.json [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/flag_descriptions.h [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/lifetime/browser_close_manager_browsertest.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/ui/browser.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/ui/browser.h [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/ui/browser_tab_strip_model_delegate.cc [delete] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/fast_unload_controller.cc [delete] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/fast_unload_controller.h [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/browser/unload_browsertest.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/common/chrome_switches.cc [modify] https://crrev.com/78267f5c868ebd407eda67c47adc1f8c5505292a/chrome/common/chrome_switches.h
"Fast Tab Closure" is now removed; this issue is now moot.
Comment 1 by olka@chromium.org
, Feb 8 2018