New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810253 link

Starred by 1 user
Status: Verified
Owner:
yhanada@chromium.org
Closed: Mar 2018
Cc:
shuchen@chromium.org
zhan...@chromium.org
█ blakeo@chromium.org
xiulingw@chromium.org
omrilio@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Floating keyboard gets wrong if switch between InputView/A11y.

Project Member Reported by xiulingw@chromium.org, Feb 8 2018 
Version 66.0.3342.0(Official build) dev (64 bit)
Platform 10383.0.0（official build) dev-channel link 
Firmware Google_Link.2695.1.169


REPRO STEPS:
1.Put cursor in any input-box
2.Switch to any Floating keyboard, e.g. US
3.Hide VK
4.Open System's Accessibility, select "On-screen keyboard"
5.Click on the input-box

Actual result: 
The Floating keyboard does not pop up anyway.

More findings:
a.The Floating keyboard still not pop up, even after disable "On-screen keyboard".
b.If switch to another keyboard, e.g. Pinyin (using short-keys): Pinyin shows on system's the low-right corner, but VK pops up with "US" showing on Space key; and Pinyin candidates pop up while tapping on this "US" VK.
c.This issue does not repro for Normal keyboard.

Note:
Errors are caught.
Floating keyboard not pops up.webm
2.2 MB View Download
Tapping on %22US%22 VK.webm
1.2 MB View Download
Error.png
594 KB View Download
Error.txt
5.3 KB View Download

Comment 1 by wuyingbing@chromium.org, Feb 28 2018

Owner: blakeo@chromium.org
Hi blakeo,
The root cause is when keyboard is hidden, then switch to A11y, Then JS will recreate the inputview.Controller.
However, when call chrome.virtualKeyboardPrivate.setMode(callback), the callback wasn't fired.
Then inputview controller wasn't initialized successfully.

If keyboard is hidden, you should not hold callback.

Comment 2 by yhanada@chromium.org, Feb 28 2018

Cc: blakeo@chromium.org
Components: UI>Input>VirtualKeyboard
Owner: yhanada@chromium.org
Status: Started (was: Assigned)
I'm preparing a CL for fixing this.

Comment 3 by yhanada@chromium.org, Mar 1 2018 

crrev.com/c/941281 is sent to review.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e5ae9d2fc306727ae525fc818f7857ab871bfa9

commit 1e5ae9d2fc306727ae525fc818f7857ab871bfa9
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Mar 01 02:44:55 2018

Invoke the passed callback of setMode() surely.

Currently we don't call the passed callback of
virtualKeyboardPrivate.setMode() when the virtual keyboard is already
hidden.
We should invoke the passed callback immediately if the virtual
keyboard is hidden because the container type is changed immediately.

Bug:  810253 
Test: Modified an unit test and followed the steps described in the linked bug.
Change-Id: Icae6a31fbd1ad11699d43cdc5cea03a4070484c9
Reviewed-on: https://chromium-review.googlesource.com/941281
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540001}
[modify] https://crrev.com/1e5ae9d2fc306727ae525fc818f7857ab871bfa9/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/1e5ae9d2fc306727ae525fc818f7857ab871bfa9/ui/keyboard/keyboard_controller_unittest.cc

Comment 5 by yhanada@chromium.org, Mar 1 2018

Status: Fixed (was: Started)

Comment 6 by yhanada@chromium.org, Mar 1 2018 

Do we need to merge this for M-65?

Comment 7 by xiulingw@chromium.org, Mar 5 2018 

Verified fixed on:
Version 67.0.3361.0 (Official build) dev (64 bit)
Platform 10459.0.0（official build) dev-channel link

Comment 8 by xiulingw@chromium.org, Mar 8 2018

Status: Verified (was: Fixed)
►

Sign in to add a comment