New issue
Advanced search Search tips

Issue 810248 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

when session restore fails, it should fail less totally

Project Member Reported by fergal@chromium.org, Feb 8 2018

Issue description

Session restore after a crash is awesome and works nearly all the time but when it fails, the result is much worse that it should be. Not only do have lose all the open tabs, we immediately sync "no tabs open" to the cloud, removing any chance of recovering state from there either.

I had 2 crashes recently where the entire system locked up and session restore failed. In both these cases it failed entirely and I was left poking around with strings and grep to recover my tabe (in today's crash even that is not helping).

It seems we could do better. For synced sessions we can notice that the cloud says we have 20 tabs open but the local disk has none (or even visibly has corruption) and offer to restore from the cloud. It would lose history and forms but it would be far better than nothing.

More generally, it would nice if the on-disk state was more resilient to OS crashes, e.g. using a log-structured DB so that when some writes don't make it to disk, I get something. Maybe not the absolute latest state but a lot more than 0. Not trivial but maybe something to think about.

 

Comment 1 by sky@chromium.org, Feb 8 2018

I think there are likely two bugs (already filed) that contribute to this:

1. At various times session restore blows away the file it streams commands to and then writes a new set. When doing this it should instead write to a temporary file and only move over the existing one once it's written the current state.

2. If you quickly exit after the restore last session restore prompt is shown you can't restore again the next time. This means if you crash once, get part way through startup and crash again you can't restore anything.
Cc: chrisha@chromium.org

Sign in to add a comment