As U2fDevice is now part of device/fido, refactor transport logic to be applicable for both CTAP and U2F protocols.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35ab570f37607fb0165cef1388804ae9bb233398 commit 35ab570f37607fb0165cef1388804ae9bb233398 Author: Jun Choi <hongjunchoi@chromium.org> Date: Tue Feb 27 00:32:18 2018 Change U2fDevice::DeviceTransact() signature Change U2fDevice::DeviceTransact() to accept std::vector<uint8_t> as input command parameter rather than U2fApduCommand. This is a preliminary CL for migrating all encoding specific logic from U2fDevice interface to U2fRequest. Bug: 810229 Change-Id: I0c063854e732074544a93f9fd1aac9d80ac3513a Reviewed-on: https://chromium-review.googlesource.com/923206 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#539345} [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/mock_u2f_device.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/mock_u2f_device.h [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_ble_device.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_ble_device.h [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_device.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_device.h [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_hid_device.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_hid_device.h [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_hid_device_unittest.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_register.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_register_unittest.cc [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_request.h [modify] https://crrev.com/35ab570f37607fb0165cef1388804ae9bb233398/device/fido/u2f_sign.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af065b9764050e6475d1b5157569aac98eba2cd commit 3af065b9764050e6475d1b5157569aac98eba2cd Author: Jun Choi <hongjunchoi@chromium.org> Date: Thu Mar 15 16:27:38 2018 Remove request logic from U2fDevice interface Move all encoding/decoding/request specific logic in U2fDevice interface to U2fRequest interface. Bug: 810229 Change-Id: I62c721fcfe5be2c3efc1bfd87920ef020ad60198 Reviewed-on: https://chromium-review.googlesource.com/927105 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#543394} [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/fido_constants.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/fido_constants.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/mock_u2f_device.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/mock_u2f_device.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_ble_device.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_ble_device.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_ble_device_unittest.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_device.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_device.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_hid_device.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_hid_device.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_hid_device_unittest.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_register.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_register.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_register_unittest.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_request.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_request.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_request_unittest.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_sign.cc [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/u2f_sign.h [modify] https://crrev.com/3af065b9764050e6475d1b5157569aac98eba2cd/device/fido/virtual_u2f_device.cc
Comment 1 by bugdroid1@chromium.org
, Feb 27 2018