New issue
Advanced search Search tips

Issue 810222 link

Starred by 1 user
Status: Duplicate
Merged: issue 752368
Owner:
w...@chromium.org
Closed: Feb 2018
Cc:
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug-Regression



Sign in to add a comment

FieldTrialListTest.TestCopyFieldTrialStateToFlags fails on Fuchsia/x64 on FYI

Project Member Reported by w...@chromium.org, Feb 8 2018 
This failed in https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/13735:

[ RUN      ] FieldTrialListTest.TestCopyFieldTrialStateToFlags
../../base/metrics/field_trial_unittest.cc:1159: Failure
Value of: command_line.HasSwitch(kFieldTrialHandleSwitch)
  Actual: false
Expected: true
../../base/metrics/field_trial_unittest.cc:1162: Failure
Expected equality of these values:
  "A,B"
  command_line.GetSwitchValueASCII(kEnableFeaturesSwitch)
    Which is: "A,B,MyFeature<Trial1"
[  FAILED  ] FieldTrialListTest.TestCopyFieldTrialStateToFlags (43 ms)

This test was previously specific to OS_WIN but enabled on other platforms by
https://chromium-review.googlesource.com/c/chromium/src/+/907593

Comment 1 by w...@chromium.org, Feb 8 2018

Mergedinto: 752368
Status: Duplicate (was: Assigned)
Looks like this test requires that shared-memory delivery of FieldTrial state is supported, which is not currently the case under Fuchsia.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c887cf2a868e141eb77fc687bcf07ec9f0b8f7eb

commit c887cf2a868e141eb77fc687bcf07ec9f0b8f7eb
Author: Wez <wez@chromium.org>
Date: Thu Feb 08 03:15:44 2018

Filter FieldTrialListTest.TestCopyFieldTrialStateToFlags under Fuchsia.

This test assumes the ability to transfer field-trial state using
shared-memory, and fails otherwise.

Bug:  810222 , 752368
Change-Id: I8dcc320e782fbd46281eab38d2f5a71e68999471
Reviewed-on: https://chromium-review.googlesource.com/906981
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535284}
[modify] https://crrev.com/c887cf2a868e141eb77fc687bcf07ec9f0b8f7eb/testing/buildbot/filters/fuchsia.base_unittests.filter
►

Sign in to add a comment