New issue
Advanced search Search tips

Issue 810218 link

Starred by 2 users
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

Make WebVR FPS alwys be reported in the WebVR metric

Project Member Reported by bsheedy@chromium.org, Feb 8 2018 
With the change to make the "WebVR FPS" tracing data actually report WebVR FPS as opposed to general VR UI FPS (https://chromium-review.googlesource.com/c/chromium/src/+/907185), the tracing data won't show up unless WebVR frames actually get submitted. This is problematic, as then a failure to submit frames will not show up in the perf dashboard as a regression.

A simple solution is to have the metric report 0 if no trace data is available.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/2eeda50e282f8c8406c88c437443689eedabeca9

commit 2eeda50e282f8c8406c88c437443689eedabeca9
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Feb 08 19:21:58 2018

Always report FPS in webvrMetric

Ensures that the webvr_fps histogram created by the webvrMetric metric
is always reported. If no actual tracing data is available, then 0 is
reported.

This is to ensure that a failure to submit frames shows up as a
regression on the perf dashboard instead of just not reporting any
new data.

Bug:  chromium:810218 
Change-Id: Ib2c9150175f0cbc9c9a9d1ade4effdb680b5d2f5
Reviewed-on: https://chromium-review.googlesource.com/908055
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>

[modify] https://crrev.com/2eeda50e282f8c8406c88c437443689eedabeca9/tracing/tracing/metrics/vr/webvr_metric_test.html
[modify] https://crrev.com/2eeda50e282f8c8406c88c437443689eedabeca9/tracing/tracing/metrics/vr/webvr_metric.html

Comment 2 by bsheedy@chromium.org, Feb 8 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 13 2018

Labels: Test-Complete

Comment 4 by btebbs@chromium.org, Jul 4

Components: Internals>XR
►

Sign in to add a comment