New issue
Advanced search Search tips

Issue 810215 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

"Try running Network Diagnostics" link does nothing on Mac

Project Member Reported by est...@chromium.org, Feb 8 2018

Issue description

Chrome Version: 63.0.3239.132, 66.0.3342.0
OS: Mac

What steps will reproduce the problem?
(1) Navigate to a domain that doesn't resolve via https, e.g. type "https://asdfasfasdfasfasd.test" in the omnibox.
(2) Click "Trying running Network Diagnostics" on the error page.

What is the expected result?

Something happens

What happens instead?

Nothing happens, the link doesn't do anything.

(Sorry, I can't find a component for net error pages or similar, so I'm putting this in Internals>Network in hopes that you all know where to put it.)
 
Summary: "Try running Network Diagnostics" link does nothing on Mac (was: "Try running Network Diagnostics" link does nothing)
Hrm...  Looks like the corresponding link still works fine on Windows.  Wonder if Apple removed the API its using.

Comment 2 by mmenke@chromium.org, Feb 14 2018

Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
Apple calls the API deprecated.  I don't know of any way to actually tell if they've created a new one to replace it, or just removed it for good.  Can't find anything with Google, but that doesn't really mean much.  Think I'll just remove the link on OSX.

Comment 3 by eroman@chromium.org, Feb 27 2018

I can also confirm that the Network Diagnostics app no longer exists in macOS High Sierra.

An alternative could be to instead launch Wireless Diagnostics app (/System/Library/CoreServices/Applications/Wireless Diagnostics.app/).

That is probably the closest non-deprecated thing.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2362d82765838a3371d3908a8cbf292b9fc4a00f

commit 2362d82765838a3371d3908a8cbf292b9fc4a00f
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Mar 02 17:45:35 2018

Remove link to network diagnostics dialog on OSX.

CFNetDiagnosticDiagnoseProblemInteractively has been deprecated, and
now apparently does nothing. We could consider using
/System/Library/CoreServices/Applications/Wireless Diagnostics.app/,
but that would require a bit more investigation and though, so just
removing the link for now.

Bug:  810215 
Change-Id: Iabe0698b17734743c092701eced0297eb71d77b7
Reviewed-on: https://chromium-review.googlesource.com/932722
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540548}
[modify] https://crrev.com/2362d82765838a3371d3908a8cbf292b9fc4a00f/chrome/browser/BUILD.gn
[delete] https://crrev.com/2a6dabd7fd299a282087a7354833e82512acf6a5/chrome/browser/net/net_error_diagnostics_dialog_mac.cc
[rename] https://crrev.com/2362d82765838a3371d3908a8cbf292b9fc4a00f/chrome/browser/net/net_error_diagnostics_dialog_posix.cc

Cc: -juliatut...@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment