VolumeManager source_path() is empty |
||||||||||||||||
Issue descriptionAs described here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/volume_manager.h?l=175&gs=kythe%253A%252F%252Fchromium%253Flang%253Dc%25252B%25252B%253Fpath%253Dsrc%252Fchrome%252Fbrowser%252Fchromeos%252Ffile_manager%252Fvolume_manager.h%2523ol3qgmgLWdkBpMamREiP9a%25252FRZtCOwFhw6dAbIMu050I%25253D&gsn=source_path_&ct=xref_usages source_path_ should contain the full path to the archive for the file system. But it is currently empty. This may be a regression introduced from moving to the new zip unpacker.
,
Feb 28 2018
,
Feb 28 2018
There are several ways to mount a zip file: - native, AVFS-based archive mounter (for .rar files, and .zip files when --disable-new-zip-unpacker and --disable-zip-archiver-unpacker) - ZIP unpacker component extension (.zip when --disable-zip-archiver-unpacker) - Zip Archiver component extension (.zip by default) AFAIK this happens only with Zip Archiver.
,
Feb 28 2018
,
Mar 1 2018
+weifangsun - this is actually blocking some core Zip bugs (eg preventing mounting duplicate archives, etc), and I've already started looking at it so I think we could aim it for M-67.
,
Mar 1 2018
,
Mar 6 2018
Implementation plan: If the file system provider's source is set to FILE in the manifest, the source File object can be passed to fileSystemProvider.mount(). Then, in the browser process, we resolve the source path of that file and set it in Volume::CreateForProvidedFileSystem(). This adds a new field to MountOptions, FileSystemURL fileUrl (or similar), or better, [instanceof=Entry] object[] fileEntry and convert it to a URL under the hood.
,
Mar 7 2018
,
Apr 5 2018
,
Apr 12 2018
,
Apr 12 2018
,
May 24 2018
,
May 24 2018
Hi Noel, assigning to you as new owner of Zip, I've done some work on these so we can catch up about them if needed.
,
Aug 16
,
Oct 17
,
Nov 19
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by sashab@chromium.org
, Feb 15 2018Labels: -Pri-1 CrOS-FilesApp-Zip Pri-3