New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810201 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

telemetry_perf_unittests failing in PerfDataGeneratorTest

Project Member Reported by steve...@chromium.org, Feb 8 2018

Issue description

First failing build:
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/5033

Failing in:
PerfDataGeneratorTest.testGenerateTelemetryTestForReferenceBuild
PerfDataGeneratorTest.testGenerateTelemetryTestForNonReferenceBuild

Only "perf" related CL is this (but doesn't seem like it should be the cause):

Increase benchmark I/O timeout to 20 minutes

This is a bandaid fix to address the problem that some story whose trace processing
takes more than 10 minutes to process.

crbug.com/810060 is opened for tracking reducing the time of trace processing.

Bug:805922
Change-Id: Id7b8a860f26460d49901ef4ebe0fee536b0029fd

I will see if I can repro locally and bisect.

 
Owner: nednguyen@chromium.org
Status: Assigned (was: Untriaged)
It looks like this is 1390163857ff2a4cff7b64888ded712a39b8dcd9. The tests appear to look for a specific timeout, so it should be a simple enough fix I think?


~/Work/chrome/src ((bfd0aa3ca7b9...)) $ git checkout 1390163857ff2a4cff7b64888ded712a39b8dcd9 && gclient sync && ninjar telemetry_perf_unittests && ./tools/perf/run_tests -v --browser=exact --browser-executable=./out/Release/test_chrome core.perf_data_generator_unittest.PerfDataGeneratorTest.testGenerateTelemetryTestForReferenceBuild
Previous HEAD position was bfd0aa3ca7b9 Roll src/third_party/pdfium/ b3a3eaab0..c0c32b0a3 (1 commit)
HEAD is now at 1390163857ff Increase benchmark I/O timeout to 20 minutes
Syncing projects: 100% (156/156), done.                                                        
Running hooks: 100% (56/56), done.                                
ninja -C out/Release telemetry_perf_unittests -j 960 -l 48
ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
[579/579] STAMP obj/chrome/test/telemetry_perf_unittests.stamp
WARNING:root:Unable to import cv2 due to: libjpeg.so.8: cannot open shared object file: No such file or directory
INFO:devil.utils.cmd_helper:[host]> /usr/local/google/home/stevenjb/Work/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
INFO:devil.utils.cmd_helper:[host]> /usr/local/google/home/stevenjb/Work/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
INFO:devil.utils.cmd_helper:[host]> /usr/local/google/home/stevenjb/Work/chrome/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb kill-server
WARNING:root:Chrome build location for linux_x86_64 not found. Browser will be run without Flash.
INFO:root:Chose browser: PossibleDesktopBrowser(type=exact, executable=./out/Release/test_chrome, flash=None)
ERROR:root:Dependency flash could not be found or fetched from cloud storage for platform linux_x86_64. Error: None
ERROR:root:Error when trying to prefetch paths for linux_x86_64: No file could be found locally, and no file to download from cloud storage for flash on platform linux_x86_64
INFO:root:Downloading WPR archives. This can take a long time.
INFO:root:All WPR archives are downloaded, took 0.0148060321808 seconds.
INFO:root:Downloading WPR archives. This can take a long time.
INFO:root:All WPR archives are downloaded, took 0.0144522190094 seconds.
[1/1] core.perf_data_generator_unittest.PerfDataGeneratorTest.testGenerateTelemetryTestForReferenceBuild failed unexpectedly 0.0020s:
  Traceback (most recent call last):
    File "/usr/local/google/home/stevenjb/Work/chrome/src/tools/perf/core/perf_data_generator_unittest.py", line 123, in testGenerateTelemetryTestForReferenceBuild
      self.assertEquals(test, expected_generated_test)
  AssertionError: {'override_compile_targets': ['telemetry_perf_tests'], 'args': ['speedometer', ' [truncated]... != {'isolate_name': 'telemetry_perf_tests', 'args': ['speedometer', '-v', '--upload [truncated]...
    {'args': ['speedometer',
              '-v',
              '--upload-results',
              '--browser=reference',
              '--output-format=chartjson',
              '--max-failures=5',
              '--output-trace-tag=_ref'],
     'isolate_name': 'telemetry_perf_tests',
     'name': 'speedometer.reference',
     'override_compile_targets': ['telemetry_perf_tests'],
     'swarming': {'can_use_on_swarming_builders': True,
                  'dimension_sets': [{'id': 'T-850',
                                      'os': 'SkyNet',
                                      'pool': 'T-RIP'}],
                  'expiration': 36000,
                  'hard_timeout': 10800,
                  'ignore_task_failure': True,
  -               'io_timeout': 1200,
  ?                             ^^
  
  +               'io_timeout': 600,
  ?                             ^
  
                  'upload_test_results': True}}
0 tests passed in 0.5s, 0 skipped, 1 failure.
**Non zero exit code**
If you don't see any error stack, this could have been a native crash. Consider installing faulthandler (https://faulthandler.readthedocs.io/) for more useful error message


Since the CL says "This is a bandaid fix to address the problem that some story whose trace processing takes more than 10 minutes to process" I'll try to avoid a revert.


Status: WontFix (was: Assigned)
The CL was already reverted: https://chromium-review.googlesource.com/c/chromium/src/+/907908

Sign in to add a comment