New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810193 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: ARC OOBE ToS empty content

Project Member Reported by khmel@chromium.org, Feb 7 2018

Issue description

Chrome Version: M65, M66

This is regression, ToS content is not displayed (it is blank) in case of ARC OOBE OptIn. 
 

Comment 1 by khmel@chromium.org, Feb 8 2018

Regression was introduced: 10321.0.0/65.0.3324.0
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0f5f75db3249839c3cfe9431f12497e46fb6c98

commit d0f5f75db3249839c3cfe9431f12497e46fb6c98
Author: khmel <khmel@google.com>
Date: Thu Feb 08 23:07:14 2018

arc: Fix hidden ToS content in case OOBE opt in.

This fixes the issue in case optimized flow for ToS content
loading document is left hidden.

Test: Manually
Bug:  810193 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3840b1e37346721e9ed6d6369d4476d47411159e
Reviewed-on: https://chromium-review.googlesource.com/909802
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#535561}
[modify] https://crrev.com/d0f5f75db3249839c3cfe9431f12497e46fb6c98/chrome/browser/resources/chromeos/arc_support/playstore.js

Comment 3 by uekawa@google.com, Feb 9 2018

Cc: wzang@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 809372  has been merged into this issue.

Comment 4 by khmel@chromium.org, Feb 13 2018

Cc: bhthompson@chromium.org
Labels: Merge-Request-65
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 13 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 20 2018

Labels: -merge-approved-65 merge-merged-3322
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32abf528eefbec689278de134ae15ff4fc8415be

commit 32abf528eefbec689278de134ae15ff4fc8415be
Author: khmel <khmel@google.com>
Date: Tue Feb 20 20:12:23 2018

[Merge M65] arc: Fix hidden ToS content in case OOBE opt in.

This fixes the issue in case optimized flow for ToS content
loading document is left hidden.

TBR=khmel@google.com

(cherry picked from commit d0f5f75db3249839c3cfe9431f12497e46fb6c98)

Test: Manually
Bug:  810193 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3840b1e37346721e9ed6d6369d4476d47411159e
Reviewed-on: https://chromium-review.googlesource.com/909802
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#535561}
Reviewed-on: https://chromium-review.googlesource.com/927114
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3322@{#10}
Cr-Branched-From: 4522efba74e35026b0f62cb1c97d793a92a0d5da-refs/heads/master@{#529187}
[modify] https://crrev.com/32abf528eefbec689278de134ae15ff4fc8415be/chrome/browser/resources/chromeos/arc_support/playstore.js

Comment 8 by khmel@chromium.org, Feb 20 2018

Status: Fixed (was: Started)

Sign in to add a comment