New issue
Advanced search Search tips

Issue 810192 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 161072



Sign in to add a comment

Web Locks API: reserve prefix for system lock names

Project Member Reported by jsb...@chromium.org, Feb 7 2018

Issue description

Per discussion at https://github.com/inexorabletash/web-locks/issues/29 and suggested by @slightlyoff, names starting with '-' will be reserved.

This will allow future APIs to mint locks that can't be squatted on by userspace locks.


 
Blocking: 161072
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fb52cc8901b50d703983e251597d75904dd441

commit e3fb52cc8901b50d703983e251597d75904dd441
Author: Joshua Bell <jsbell@chromium.org>
Date: Thu Feb 08 01:45:00 2018

Web Locks API: Reserve '-' prefix for system-minted locks

Per suggestion by slightlyoff@, reserve a namespace for system locks.
We might come up with a different scheme in the future, but it's
easier to do this now than try and hack it in later. Requests for
locks starting with '-' will fail, similar to other invalid option
combinations.

Discussion: https://github.com/inexorabletash/web-locks/issues/29

Bug:  810192 
Change-Id: I87a902a5923bca720c6d3db3b833373f70bc16df
Reviewed-on: https://chromium-review.googlesource.com/907791
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535243}
[modify] https://crrev.com/e3fb52cc8901b50d703983e251597d75904dd441/content/browser/locks/lock_manager.cc
[modify] https://crrev.com/e3fb52cc8901b50d703983e251597d75904dd441/third_party/WebKit/LayoutTests/http/tests/locks/resource-names.html
[modify] https://crrev.com/e3fb52cc8901b50d703983e251597d75904dd441/third_party/WebKit/Source/modules/locks/LockManager.cpp

Status: Fixed (was: Started)

Sign in to add a comment