New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810187 link

Starred by 1 user
Status: Fixed
Owner:
█ mariakho...@chromium.org
Left Chrome team
Closed: Feb 2018
Cc:
█ shobana@google.com
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Record reason instant app eligible page didn't show app banner

Project Member Reported by mariakho...@chromium.org, Feb 7 2018 
Record break down of the reasons the app banner wasn't shown on an instant apps page.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7b99cff4ce5b301972914eb89edde679778fced

commit b7b99cff4ce5b301972914eb89edde679778fced
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Feb 21 00:34:01 2018

[Instant Apps] Add banner show metrics.

Logs the reason the banner was/wasn't shown for an instant apps page.

Bug:  810187 
Change-Id: I2bd06b21d3328944bf596e9428d461353a2b1818
Reviewed-on: https://chromium-review.googlesource.com/909328
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537958}
[modify] https://crrev.com/b7b99cff4ce5b301972914eb89edde679778fced/chrome/BUILD.gn
[modify] https://crrev.com/b7b99cff4ce5b301972914eb89edde679778fced/chrome/android/BUILD.gn
[modify] https://crrev.com/b7b99cff4ce5b301972914eb89edde679778fced/chrome/browser/android/instantapps/instant_apps_settings.cc
[modify] https://crrev.com/b7b99cff4ce5b301972914eb89edde679778fced/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b7b99cff4ce5b301972914eb89edde679778fced/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/5e7f0b05fb8757c6ad5a981edf111efc3cdcc89c

commit 5e7f0b05fb8757c6ad5a981edf111efc3cdcc89c
Author: Maria Khomenko <mariakhomenko@google.com>
Date: Wed Feb 21 20:10:47 2018

Comment 3 by mariakho...@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment