New issue
Advanced search Search tips

Issue 810182 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Allow binaries to be run under single-core Fuchsia VM

Project Member Reported by w...@chromium.org, Feb 7 2018

Issue description

Our test & executable runner scripts are currently hard-wired to launch QEMU configured to emulate four logical cores.

Multi-core emulation leads to significant performance overhead due to Inter-Process-Interrupt emulation, so being able to run single-core more easily (i.e. without hacking the script) would be useful.

For test binaries we rely upon a set of filters at present, to disable running of some known-bad tests - the filtering is implemented by TestLauncher, along with stdio eliding, and neither are applied to single-job test runs. We should consider modifying TestLauncher to only run the suite directly in the explicit case of the caller passing the --single-process-tests flag.
 

Comment 1 by w...@chromium.org, Feb 8 2018

Labels: M-67
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f82ff53b00299b65dd812fc97b03e49d2ddfe7b7

commit f82ff53b00299b65dd812fc97b03e49d2ddfe7b7
Author: Wez <wez@chromium.org>
Date: Fri Feb 09 00:04:05 2018

Add --vm-cpu-cores option to legacy {test|exe}_runner.py scripts.

This option controls the number of CPU cores made available to the
Fuchsia guest when running under QEMU. We continue to default to
running VMs with four cores available.

It is also used to set the default number of test-launcher-jobs, for
both QEMU and on-device runs.

Bug:  810182 
Change-Id: I6e52e581769faf42a8777c4c3c110ba05a8504d4
Reviewed-on: https://chromium-review.googlesource.com/907790
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535582}
[modify] https://crrev.com/f82ff53b00299b65dd812fc97b03e49d2ddfe7b7/build/fuchsia/exe_runner.py
[modify] https://crrev.com/f82ff53b00299b65dd812fc97b03e49d2ddfe7b7/build/fuchsia/runner_common.py
[modify] https://crrev.com/f82ff53b00299b65dd812fc97b03e49d2ddfe7b7/build/fuchsia/test_runner.py

Comment 3 by w...@chromium.org, May 23 2018

Labels: -M-67 M-69
Labels: -M-69 M-70
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6ec355cf297e348e6c5ed72e72165957b7d3407

commit c6ec355cf297e348e6c5ed72e72165957b7d3407
Author: Wez <wez@chromium.org>
Date: Thu Aug 30 02:32:19 2018

Add --qemu-cpu-cores argument to runners

Bug:  810182 
Change-Id: Iebc05e7cff0e937c73baa0b8a385a6cdeca61b24
Reviewed-on: https://chromium-review.googlesource.com/1196021
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587424}
[modify] https://crrev.com/c6ec355cf297e348e6c5ed72e72165957b7d3407/build/fuchsia/common_args.py
[modify] https://crrev.com/c6ec355cf297e348e6c5ed72e72165957b7d3407/build/fuchsia/qemu_target.py

Status: Fixed (was: Started)

Sign in to add a comment