New issue
Advanced search Search tips

Issue 810181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Views-based shelf ripple does not go away after clicking a button

Project Member Reported by jdufault@chromium.org, Feb 7 2018

Issue description

Views-based shelf ripple does not go away after clicking a button

This is very visible when using gaia enrollment on login.
 
Labels: M-61
Labels: -M-61 M-66
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9bf332694f083c6767416b69d0f8539d1c44707

commit b9bf332694f083c6767416b69d0f8539d1c44707
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Feb 08 18:56:10 2018

cros: Hide ripple after clicking on views-based shelf button.

Also make the ripple use rounded corners to better match status area ripple.

Bug:  810181 
Change-Id: I5fefc8852c305ec7ea25247928d3c05834d2bfca
Reviewed-on: https://chromium-review.googlesource.com/906847
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535461}
[modify] https://crrev.com/b9bf332694f083c6767416b69d0f8539d1c44707/ash/shelf/login_shelf_view.cc

Components: UI>Shell>Shelf
Status: Fixed (was: Started)

Sign in to add a comment