New issue
Advanced search Search tips

Issue 810176 link

Starred by 3 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 829571


Sign in to add a comment

DevTools: side-effect-free global evaluation

Project Member Reported by l...@chromium.org, Feb 7 2018 
- Add "throwOnSideEffect" flag to Runtime.evaluate() (currently exists for Debugger.evaluateOnCallFrame())
- Investigate ways to use throwOnSideEffect on the frontend
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85

commit bcbdcea734fe8e969e8d2cd161e0bc393b29ab85
Author: Erik Luo <luoe@chromium.org>
Date: Fri Feb 16 19:56:20 2018

Set RuntimeAgent evaluate to use DebugEvaluate::Global

Bug:  chromium:810176 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I330fa0bdf81d0bb926cf6db794736e89c069f8f2
Reviewed-on: https://chromium-review.googlesource.com/907707
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51333}
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/src/api.cc
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/src/debug/debug-evaluate.cc
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/src/debug/debug-interface.h
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/src/inspector/v8-runtime-agent-impl.cc
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/cctest/test-debug.cc
[add] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/inspector/debugger/eval-without-codegen-expected.txt
[add] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/inspector/debugger/eval-without-codegen.js
[modify] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/inspector/inspector-test.cc
[add] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/inspector/runtime/evaluate-run-microtasks-expected.txt
[add] https://crrev.com/bcbdcea734fe8e969e8d2cd161e0bc393b29ab85/test/inspector/runtime/evaluate-run-microtasks.js
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0cf89dd1bea706581e18e01144186e68cb01005f

commit 0cf89dd1bea706581e18e01144186e68cb01005f
Author: Erik Luo <luoe@chromium.org>
Date: Mon Feb 19 08:08:45 2018

[debug] move side-effect tests into subfolder

Bug:  chromium:810176 
Change-Id: I089a1678dfbe0c3bb664e54818a6853f66d364b2
Reviewed-on: https://chromium-review.googlesource.com/923387
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51347}
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-async.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins-2.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-control.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-iife.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-ops.js
[rename] https://crrev.com/0cf89dd1bea706581e18e01144186e68cb01005f/test/debugger/debug/side-effect/debug-evaluate-no-side-effect.js
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/28c81eeef7c3eea13f75d6af876bb9edd1e2239e

commit 28c81eeef7c3eea13f75d6af876bb9edd1e2239e
Author: Erik Luo <luoe@chromium.org>
Date: Thu Feb 22 08:57:41 2018

Revert "[debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns"

This reverts commit ba5bac8cebe91c585024c67687ced8fe1baed833.

Reason for revert: Breaks the build, needs investigation

Original change's description:
> [debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns
> 
> Adds more whitelisted methods in debug-evaluate for:
> Array, TypedArray, ArrayBuffer, DataView, WeakMap, WeakSet
> 
> Bug:  chromium:810176 
> Change-Id: I502776ad3191ccc2a355e5684b5f885a5f58d186
> Reviewed-on: https://chromium-review.googlesource.com/923414
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#51456}

TBR=yangguo@chromium.org,luoe@chromium.org

Change-Id: I864e5747fa3277e27feffba08a50c8c241291f41
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:810176 
Reviewed-on: https://chromium-review.googlesource.com/929922
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51457}
[modify] https://crrev.com/28c81eeef7c3eea13f75d6af876bb9edd1e2239e/src/debug/debug-evaluate.cc
[modify] https://crrev.com/28c81eeef7c3eea13f75d6af876bb9edd1e2239e/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-async.js
[modify] https://crrev.com/28c81eeef7c3eea13f75d6af876bb9edd1e2239e/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins-2.js
[modify] https://crrev.com/28c81eeef7c3eea13f75d6af876bb9edd1e2239e/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins.js
[modify] https://crrev.com/28c81eeef7c3eea13f75d6af876bb9edd1e2239e/test/debugger/debug/side-effect/debug-evaluate-no-side-effect.js
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/be270c15ad02a44789bf44879aed7da5ce184469

commit be270c15ad02a44789bf44879aed7da5ce184469
Author: Erik Luo <luoe@chromium.org>
Date: Thu Feb 22 19:45:51 2018

Reland "[debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns"

This is a reland of ba5bac8cebe91c585024c67687ced8fe1baed833.

Original change's description:
> [debug] add tests, mark side-effect-free (Typed)Array, WeakMap/Set fns
> 
> Adds more whitelisted methods in debug-evaluate for:
> Array, TypedArray, ArrayBuffer, DataView, WeakMap, WeakSet
> 
> Bug:  chromium:810176 
> Change-Id: I502776ad3191ccc2a355e5684b5f885a5f58d186
> Reviewed-on: https://chromium-review.googlesource.com/923414
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#51456}

Bug:  chromium:810176 
Change-Id: I64ff0aa632ddf77ad683de76b61ebe4e85d5f879
Reviewed-on: https://chromium-review.googlesource.com/931987
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51483}
[modify] https://crrev.com/be270c15ad02a44789bf44879aed7da5ce184469/src/debug/debug-evaluate.cc
[modify] https://crrev.com/be270c15ad02a44789bf44879aed7da5ce184469/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-async.js
[modify] https://crrev.com/be270c15ad02a44789bf44879aed7da5ce184469/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins-2.js
[modify] https://crrev.com/be270c15ad02a44789bf44879aed7da5ce184469/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins.js
[modify] https://crrev.com/be270c15ad02a44789bf44879aed7da5ce184469/test/debugger/debug/side-effect/debug-evaluate-no-side-effect.js
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0d2c85b70b44ffdfe3d66c947e754fe0a23de564

commit 0d2c85b70b44ffdfe3d66c947e754fe0a23de564
Author: Erik Luo <luoe@chromium.org>
Date: Wed Feb 28 23:54:46 2018

[inspector] expose throwOnSideEffect for Runtime.evaluate

Bug:  chromium:810176 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I16e4148434f5cbf44058e1aa5f01693bcba82d0a
Reviewed-on: https://chromium-review.googlesource.com/932943
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51640}
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/api.cc
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/debug/debug-evaluate.cc
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/debug/debug-evaluate.h
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/debug/debug-interface.h
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/inspector/js_protocol.json
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/inspector/js_protocol.pdl
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/inspector/v8-runtime-agent-impl.cc
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/inspector/v8-runtime-agent-impl.h
[modify] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/src/runtime/runtime-debug.cc
[add] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/test/inspector/runtime/evaluate-without-side-effects-expected.txt
[add] https://crrev.com/0d2c85b70b44ffdfe3d66c947e754fe0a23de564/test/inspector/runtime/evaluate-without-side-effects.js

Comment 8 by l...@chromium.org, Apr 5 2018

Blockedon: 829571
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4e2376b1cbe1e4a19ccfa5816b19b4b2501e06d1

commit 4e2376b1cbe1e4a19ccfa5816b19b4b2501e06d1
Author: Erik Luo <luoe@chromium.org>
Date: Tue Apr 10 17:15:25 2018

[debug] whitelist Function, BigInt methods as side-effect-free

This whitelists Function-related builtins used by Blink callbacks at
the DOM wrapping stage, and other BigInt methods.

Bug:  chromium:810176 
Change-Id: If036114cd7f133f2c30247dff836698c2eb16a51
Reviewed-on: https://chromium-review.googlesource.com/1004000
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52530}
[modify] https://crrev.com/4e2376b1cbe1e4a19ccfa5816b19b4b2501e06d1/src/accessors.h
[modify] https://crrev.com/4e2376b1cbe1e4a19ccfa5816b19b4b2501e06d1/src/debug/debug-evaluate.cc
[modify] https://crrev.com/4e2376b1cbe1e4a19ccfa5816b19b4b2501e06d1/test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins-2.js
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/363996f7ab7a9ac696e9354e1778147439e5127f

commit 363996f7ab7a9ac696e9354e1778147439e5127f
Author: Erik Luo <luoe@chromium.org>
Date: Mon Apr 23 22:06:07 2018

[inspector] whitelist side-effect-free console API callbacks

This CL whitelists Console Command Line API callbacks on the V8 side.

Bug:  chromium:810176 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7afdd6bd4263cb4cb18bdf02b37ab3e822ae5c96
Reviewed-on: https://chromium-review.googlesource.com/1016094
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52747}
[modify] https://crrev.com/363996f7ab7a9ac696e9354e1778147439e5127f/src/inspector/v8-console.cc
[add] https://crrev.com/363996f7ab7a9ac696e9354e1778147439e5127f/test/inspector/runtime/command-line-api-without-side-effects-expected.txt
[add] https://crrev.com/363996f7ab7a9ac696e9354e1778147439e5127f/test/inspector/runtime/command-line-api-without-side-effects.js
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3839bd01d4428fb8ee450d0df94b85c6a9fd1ec1

commit 3839bd01d4428fb8ee450d0df94b85c6a9fd1ec1
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Apr 23 23:02:46 2018

[DevTools] needs rebase http/tests/devtools/runtime/evaluate-timeout.js

After V8 roll this test will behave properly.

TBR: luoe@chromium.org
Bug:  chromium:810176 
Change-Id: Ieb64794bde43bca4c345220c70b83f02996c00c2
Reviewed-on: https://chromium-review.googlesource.com/1025033
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552879}
[modify] https://crrev.com/3839bd01d4428fb8ee450d0df94b85c6a9fd1ec1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3839bd01d4428fb8ee450d0df94b85c6a9fd1ec1/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f450ef832e7a3833c04f84a2c23f13ca893f57c

commit 5f450ef832e7a3833c04f84a2c23f13ca893f57c
Author: Erik Luo <luoe@chromium.org>
Date: Sun Apr 29 19:18:13 2018

DevTools: support timeout option in Debugger.evaluateOnCallFrame

We previously disabled ExecutionContext.p.evaluate() from running
with 'timeout' option while paused. Now that it is supported by
inspector-protocol, we can allow these evaluations to run.

Bug:  810176 
Change-Id: Icf81da3d533c719a347f49b3ccd63106e30412c7
Reviewed-on: https://chromium-review.googlesource.com/1033995
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554672}
[modify] https://crrev.com/5f450ef832e7a3833c04f84a2c23f13ca893f57c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5f450ef832e7a3833c04f84a2c23f13ca893f57c/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt
[modify] https://crrev.com/5f450ef832e7a3833c04f84a2c23f13ca893f57c/third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout.js
[modify] https://crrev.com/5f450ef832e7a3833c04f84a2c23f13ca893f57c/third_party/blink/renderer/devtools/front_end/sdk/DebuggerModel.js
Project Member

Comment 15 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcaafdd756b1aef4f8244474e37be9ee12c75284

commit fcaafdd756b1aef4f8244474e37be9ee12c75284
Author: Erik Luo <luoe@chromium.org>
Date: Tue May 01 19:26:52 2018

DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect

Allow Console to evaluate without throwOnSideEffect when the entire
expression meets the same strict conditions used by JSAutocomplete.

Bug:  810176 
Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
Reviewed-on: https://chromium-review.googlesource.com/1028934
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555142}
[add] https://crrev.com/fcaafdd756b1aef4f8244474e37be9ee12c75284/third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check-expected.txt
[add] https://crrev.com/fcaafdd756b1aef4f8244474e37be9ee12c75284/third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check.js
[modify] https://crrev.com/fcaafdd756b1aef4f8244474e37be9ee12c75284/third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/fcaafdd756b1aef4f8244474e37be9ee12c75284/third_party/blink/renderer/devtools/front_end/formatter/FormatterWorkerPool.js
[modify] https://crrev.com/fcaafdd756b1aef4f8244474e37be9ee12c75284/third_party/blink/renderer/devtools/front_end/formatter_worker/FormatterWorker.js
Project Member

Comment 16 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c4b089fbb62cc5986b98129dadfab5f69fcc97

commit 67c4b089fbb62cc5986b98129dadfab5f69fcc97
Author: Erik Luo <luoe@chromium.org>
Date: Wed May 02 01:16:09 2018

Revert "DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect"

This reverts commit fcaafdd756b1aef4f8244474e37be9ee12c75284.

Reason for revert: we'd like to be more strict about side effects

Original change's description:
> DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect
> 
> Allow Console to evaluate without throwOnSideEffect when the entire
> expression meets the same strict conditions used by JSAutocomplete.
> 
> Bug:  810176 
> Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
> Reviewed-on: https://chromium-review.googlesource.com/1028934
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555142}

TBR=dgozman@chromium.org,einbinder@chromium.org,luoe@chromium.org

Change-Id: Iec31996445e98945a0a9a9b67e572d17bafdcbeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  810176 
Reviewed-on: https://chromium-review.googlesource.com/1039063
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555269}
[delete] https://crrev.com/dedd5ba345b0ff8a60143bfa78d606682e35a20d/third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check-expected.txt
[delete] https://crrev.com/dedd5ba345b0ff8a60143bfa78d606682e35a20d/third_party/WebKit/LayoutTests/http/tests/devtools/unit/needs-side-effect-check.js
[modify] https://crrev.com/67c4b089fbb62cc5986b98129dadfab5f69fcc97/third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/67c4b089fbb62cc5986b98129dadfab5f69fcc97/third_party/blink/renderer/devtools/front_end/formatter/FormatterWorkerPool.js
[modify] https://crrev.com/67c4b089fbb62cc5986b98129dadfab5f69fcc97/third_party/blink/renderer/devtools/front_end/formatter_worker/FormatterWorker.js
Project Member

Comment 17 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f577c90e5521bc91afd2aa25c2fa84d630a49b

commit 65f577c90e5521bc91afd2aa25c2fa84d630a49b
Author: Erik Luo <luoe@chromium.org>
Date: Sat May 05 06:00:35 2018

DevTools: unhide console prompt experiment and fix focus

Turns the console below-prompt UI experiment from hidden to
visible.

Clicking on the preview element will now focus the prompt
editor, unless it has a selection.

Bug:  810176 
Change-Id: I28cb5fa9c375ab4ae5cbfdf5043d03c7d8c71057
Reviewed-on: https://chromium-review.googlesource.com/1043464
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556316}
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt-expected.txt
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt.js
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-stick-to-bottom-with-large-prompt.js
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/65f577c90e5521bc91afd2aa25c2fa84d630a49b/third_party/blink/renderer/devtools/front_end/main/Main.js
Project Member

Comment 18 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1

commit 93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1
Author: Erik Luo <luoe@chromium.org>
Date: Tue May 08 08:59:22 2018

DevTools: convert below prompt experiment into setting

The new setting is in the toolbar behind the gear.
Screenshot: https://imgur.com/a/09myIJH

Bug:  810176 
Change-Id: Ifbd2a2bfc6712e2f2415e384c040f5520b1e2347
Reviewed-on: https://chromium-review.googlesource.com/1045180
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556734}
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/WebKit/LayoutTests/http/tests/devtools/console/viewport-testing/console-runtime-result-below-prompt.js
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/blink/renderer/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/blink/renderer/devtools/front_end/console/module.json
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/blink/renderer/devtools/front_end/main/Main.js
[modify] https://crrev.com/93eb26e6cbda0437be38d2d4f00f0ab2b9b411c1/third_party/blink/renderer/devtools/front_end/text_editor/TextEditorAutocompleteController.js

Comment 20 by l...@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
Closing this for now, as the main functionality is complete.

Still open:
https://bugs.chromium.org/p/chromium/issues/detail?id=845734
https://bugs.chromium.org/p/chromium/issues/detail?id=845852
►

Sign in to add a comment