New issue
Advanced search Search tips

Issue 810175 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Both --branch and -b on cbuildbot_launch and cbuildbot command lines?

Project Member Reported by dgarr...@chromium.org, Feb 7 2018

Issue description

It looks like we often list the branch twice WITH DIFFERENT VALUES in both cbuildbot_launch invocation, and when invoking cbuildbot.

Since we list the real value second, this works, but is confusing and ugly.

Swarming example:

Cmd:
  cros tryjob --swarming -g 858174 --branch release-R65-10323.B lumpy-compile-only-pre-cq

Build:
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8955209776461890624

cbuildbot_launch:
  /b/swarming/w/ir/kitchen-workdir/chromite/scripts/cbuildbot_launch --buildroot /b/swarming/w/ir/cache/cbuild --branch master --buildbucket-id 8955209776461890624 --git-cache-dir /b/swarming/w/ir/cache/git --goma_dir /b/swarming/w/ir/cache/goma_client --goma_client_json /creds/service_accounts/service-account-goma-client.json --remote-trybot -b release-R65-10323.B -g 858174 lumpy-compile-only-pre-cq

 
The first value comes from the recipe per-waterfall value "chromite_branch", which defaults to "master" if not specified.

The second value comes from the command line arguments explicitly passed in by "cros tryjob".

We still use the "chromite_branch" configuration value for a variety of buildbot waterfalls.

Status: Assigned (was: Started)
After we finish moving to swarming, we can remove the per-waterfall configuration logic and simplify things.

Until then, the double arguments on the command line don't really hurt anything.
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Sign in to add a comment