Remove kShowNonMdLogin switch. |
||||
Issue descriptionThe non-md webui version of lock/login is no longer used and the switch can be removed. The css/html/js files associated with NonMd can be removed as well.
,
Feb 7 2018
We should note any remaining examples where both md_ and non md_ versions exist and file a separate issue to clean that up.
,
Feb 7 2018
,
Feb 7 2018
Not all of them can be removed. Many are used in both versions. I'd start by removing methods that appear to no longer be called.
,
Feb 7 2018
The login screen is still using some of the md_* files as well. Those should go away when views-login launches.
,
Feb 8 2018
The files I am suggesting to delete are: and there corresponding .js and .css files. header_bar.html - [1] only included by screen_container.html lock.html login.html - [4] these two are attached as a resource which is no longer used once switch is gone. lock_screens.html login_screens.html - [5] not sure about these two, they are including as [OOBE]_screens.html in *screen_container.html. login_shared.html - [2] only included by lock.html & login.html screen_container.html - [3] only included by lock.html & login.html [1] https://cs.chromium.org/search/?q=%5Cbheader_bar.html&type=cs [2] https://cs.chromium.org/search/?q=%5Cblogin_shared.html&type=cs [3] https://cs.chromium.org/search/?q=%5Cbscreen_container.html&type=cs [4] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc?rcl=ecdb1462f5e9e86a0115e145abdbd6ffa442304e&l=148 [5] https://cs.chromium.org/search/?q=_screens.html&type=cs fwiw, it passes the trybots
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681287281efc60e4505f92108b3f7fc626744083 commit 681287281efc60e4505f92108b3f7fc626744083 Author: Sammie Quon <sammiequon@google.com> Date: Tue Feb 13 23:43:25 2018 cros: Remove kShowNonMdLogin switch. Delete the resources files later. Test: trybots Bug: 810170 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8f956cb00ba2dcbe7f581f96115bef9a601e9fac Reviewed-on: https://chromium-review.googlesource.com/907690 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#536553} [modify] https://crrev.com/681287281efc60e4505f92108b3f7fc626744083/chrome/browser/browser_resources.grd [modify] https://crrev.com/681287281efc60e4505f92108b3f7fc626744083/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/681287281efc60e4505f92108b3f7fc626744083/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/681287281efc60e4505f92108b3f7fc626744083/chromeos/chromeos_switches.cc [modify] https://crrev.com/681287281efc60e4505f92108b3f7fc626744083/chromeos/chromeos_switches.h
,
Mar 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Feb 7 2018