New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810167 link

Starred by 1 user
Status: Fixed
Owner:
rsorokin@chromium.org
Closed: Apr 2018
Cc:
█ bauerb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Implement removing of AD users from profile.info_cache by AccountId.

Project Member Reported by alemate@chromium.org, Feb 7 2018 
It turns out that there is not enough identity information in profile.info_cache to identify cache entries when only AccountId is known.

We need to fix this and implement cache cleanup when AD users are removed.

This should be a followup to https://chromium-review.googlesource.com/c/chromium/src/+/905751/ .

Comment 1 by rsorokin@chromium.org, Feb 13 2018

Labels: M-66 Chromad
Status: Started (was: Assigned)

Comment 2 by rsorokin@chromium.org, Mar 7 2018

Labels: -M-66 M-67

Comment 3 by rsorokin@chromium.org, Mar 27 2018

Labels: -Pri-1 Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0

commit 8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Apr 16 15:58:58 2018

Remove profile info cache for Active Directory profiles

BUG= chromium:810167 

Change-Id: I030f296e0cf1379d65f9dfba759163896f4319b5
Reviewed-on: https://chromium-review.googlesource.com/928721
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550975}
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_attributes_storage.h
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_attributes_storage_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache.h
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_list_desktop_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_window_browsertest.cc

Comment 5 by rsorokin@chromium.org, Apr 16 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0

commit 8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Apr 16 15:58:58 2018

Remove profile info cache for Active Directory profiles

BUG= chromium:810167 

Change-Id: I030f296e0cf1379d65f9dfba759163896f4319b5
Reviewed-on: https://chromium-review.googlesource.com/928721
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550975}
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_attributes_storage.h
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_attributes_storage_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache.h
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_info_cache_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_list_desktop_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
[modify] https://crrev.com/8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0/chrome/browser/profiles/profile_window_browsertest.cc
►

Sign in to add a comment