New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Solve skia/gl state synchronization once and for all

Project Member Reported by junov@chromium.org, Feb 7 2018

Issue description

Currently, there is a requirement to call GrContext::resetContext(...)
whenever the gl interface is used directly and the gl state is changed without skia's knowledge.

This way of doing things is very error prone and often results in flaky failures with esoteric repro steps.  The resulting bugs are often very hard to bisect due to flaky repro, and hard to investigate.

What we need is a systematic approach to either:
a) automatically detect out of sync state,
b) automatically invalidate the GrContext when state-changing GL calls are made, or
c) automatically update skia's state cache
 

Comment 1 by junov@chromium.org, Feb 7 2018

I am going to make a design doc to review different alternatives.  Stay tuned.

Comment 2 by junov@chromium.org, Feb 14 2018

After discussing with several colleagues, I am opting for option b)

The design, in a nutshell is to modify viz::ContextProvider::ContextGL() so that instead of returning a GLES2Interface*, it will return a scoped object that that automatically calls GrContext::resetContext with the right bits upon destruction.

In order to track which state bits need to be flagged, we'll use a subclass of GLES2Implementation that intercepts calls that change state that skia cares about.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8f117ce2885070675675564dc39be7e92c6853d

commit c8f117ce2885070675675564dc39be7e92c6853d
Author: Justin Novosad <junov@chromium.org>
Date: Sun Mar 18 07:48:52 2018

Automate calls to GrContext::resetContext

The purpose of this change is to prevent the re-occurrence of flaky
rendering bugs caused by missing calls to GrContext::resetContext. This
change uses a new subclass of GLES2Implementation called
GLES2ImplementationWithGrContextSupport, which takes care of calling
GrContext::resetContext() whenever the gl state is changed. These
calls are lightweight: they just perform an 'or' on an integer.

To avoid calling GrContext::resetContext() when gl calls are made from
within skia, the bindings were modified in CreateGLES2InterfaceBindings
in order to signal the GLES2ImplementationWithGrContextSupport so that
it knows the the current GL call is made from skia.

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I59470a8188df235a36d6de0e9aaff57b69ff9d6a
Bug:  807974 ,  810159 
Reviewed-on: https://chromium-review.googlesource.com/924616
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543955}
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/android_webview/browser/aw_render_thread_context_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/android_webview/browser/aw_render_thread_context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/raster/scoped_gpu_raster.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gl_helper.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gl_helper.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gpu/context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gpu/in_process_context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/common/gpu/raster_context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/test/test_context_provider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/test/test_context_support.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/components/viz/test/test_context_support.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/content/test/layouttest_support.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/command_buffer/client/implementation_base.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/command_buffer/client/implementation_base.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/ipc/BUILD.gn
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/BUILD.gn
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h
[add] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/gles2_implementation_with_grcontext_support.cc
[add] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/gles2_implementation_with_grcontext_support.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/grcontext_for_gles2_interface.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/gpu/skia_bindings/grcontext_for_gles2_interface.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/services/ui/public/cpp/gpu/context_provider_command_buffer.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/gpu/GraphicsContext3DUtils.cpp
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/ui/compositor/test/in_process_context_provider.cc
[modify] https://crrev.com/c8f117ce2885070675675564dc39be7e92c6853d/ui/compositor/test/in_process_context_provider.h

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5

commit 7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5
Author: Justin Novosad <junov@chromium.org>
Date: Tue Mar 27 18:55:38 2018

Reland "Automate calls to GrContext::resetContext"

This reverts commit 60f840e7e212c79d76e5e7fa32667214e050e20b.
This re-land resolves rendering regression in AndroidWebView by
restoring a context reset in ScopedGpuRaster, which was the cause of
crbug.com/823232, and the reason for the revert.

TBR=piman@chromium.org

Bug:  807974 ,  810159 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8112ab4e25c9dbf40aa386368815b986e7d4a9d9
Reviewed-on: https://chromium-review.googlesource.com/982098
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546189}
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/android_webview/browser/aw_render_thread_context_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/android_webview/browser/aw_render_thread_context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/raster/scoped_gpu_raster.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gl_helper.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gl_helper.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gpu/context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gpu/in_process_context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/common/gpu/raster_context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/test/test_context_provider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/test/test_context_support.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/components/viz/test/test_context_support.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/media_capture_from_element/canvas_capture_handler.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/webgraphicscontext3d_provider_impl.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/renderer/webgraphicscontext3d_provider_impl.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/test/gpu_browsertest_helpers.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/content/test/layouttest_support.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/command_buffer/client/context_support.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/command_buffer/client/implementation_base.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/command_buffer/client/implementation_base.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/command_buffer/client/raster_implementation_gles_unittest.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/ipc/BUILD.gn
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/BUILD.gn
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h
[add] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/gles2_implementation_with_grcontext_support.cc
[add] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/gles2_implementation_with_grcontext_support.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/grcontext_for_gles2_interface.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/gpu/skia_bindings/grcontext_for_gles2_interface.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/media/renderers/paint_canvas_video_renderer.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/services/ui/public/cpp/gpu/context_provider_command_buffer.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/services/ui/public/cpp/gpu/context_provider_command_buffer.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/gpu/GraphicsContext3DUtils.cpp
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/Source/platform/graphics/test/FakeWebGraphicsContext3DProvider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/third_party/WebKit/public/platform/WebGraphicsContext3DProvider.h
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/ui/compositor/test/in_process_context_provider.cc
[modify] https://crrev.com/7d3d2502e2e1dbcb42aec4b8f50b2677c1c29ed5/ui/compositor/test/in_process_context_provider.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/905b8cac7b58d60a0003c4c413da212b37889e53

commit 905b8cac7b58d60a0003c4c413da212b37889e53
Author: Roger Johannesson <rogerj@vewd.com>
Date: Thu May 31 13:28:54 2018

Enable GrContext support in the shared main thread context provider

This prevents a DCHECK when running with either --show-fps-counter or
--show-paint-rects together with --enable-gpu-rasterization. The DCHECK
is triggered by cc::HeadsUpDisplayLayerImpl::UpdateHudTexture that makes
use of the GrContext when gpu rasterization is enabled.

Bug:  837246 ,  810159 
Change-Id: I74d2b1390d975dd783736bb1c12114ed4c7cbb0a
Reviewed-on: https://chromium-review.googlesource.com/1078267
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#563207}
[modify] https://crrev.com/905b8cac7b58d60a0003c4c413da212b37889e53/content/renderer/render_thread_impl.cc

Comment 6 by junov@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)

Sign in to add a comment