New issue
Advanced search Search tips

Issue 810141 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 827423



Sign in to add a comment

lucifer: Move STARTING into lucifer

Project Member Reported by ayatane@chromium.org, Feb 7 2018

Issue description

See title
 
Showing comments 17 - 116 of 116 Older
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0d4322b156b22b815f1099c38c8253a4b1288a22

commit 0d4322b156b22b815f1099c38c8253a4b1288a22
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 17 03:10:12 2018

[autotest] Add _run_{autotest,lucifer}_job()

BUG= chromium:810141 
TEST=None

Change-Id: Ic23bbb9fcfb0b92e93f99ea83ac7ab2a99828c2b
Reviewed-on: https://chromium-review.googlesource.com/912749
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/0d4322b156b22b815f1099c38c8253a4b1288a22/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a6458b3c836ca07d8dd1a303c0fcda2bc7dfc1ef

commit a6458b3c836ca07d8dd1a303c0fcda2bc7dfc1ef
Author: Allen Li <ayatane@chromium.org>
Date: Tue Feb 20 22:05:23 2018

[autotest] Rename -x-hosts flag to -hosts

-x-hosts is deprecated and replaced with latter.

BUG= chromium:810141 
TEST=None

Change-Id: I90fb9dfe404bb8e75d450cbaff7c379cd053e0c8
Reviewed-on: https://chromium-review.googlesource.com/919003
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/a6458b3c836ca07d8dd1a303c0fcda2bc7dfc1ef/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4aafca5d5afa3dc8d3bfcda3cad977b83b41ef2f

commit 4aafca5d5afa3dc8d3bfcda3cad977b83b41ef2f
Author: Allen Li <ayatane@chromium.org>
Date: Tue Feb 20 22:05:24 2018

[autotest] Remove jobx.working_directory

Wont use, code exists elsewhere in a reusable location.

BUG= chromium:810141 
TEST=None

Change-Id: Ia36e1088b9ebfee02cc47459c93cdab288d5b26f
Reviewed-on: https://chromium-review.googlesource.com/920882
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4aafca5d5afa3dc8d3bfcda3cad977b83b41ef2f/venv/lucifer/jobx.py

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c13a7a5daa80bf40ac2e7fa80b36c76a3a75c389

commit c13a7a5daa80bf40ac2e7fa80b36c76a3a75c389
Author: Allen Li <ayatane@chromium.org>
Date: Tue Feb 20 22:05:24 2018

[autotest] Add location of original implementation

BUG= chromium:810141 
TEST=None

Change-Id: Ie110e9e3ce3e5fb66bd74310a295dd55d402d561
Reviewed-on: https://chromium-review.googlesource.com/920883
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/c13a7a5daa80bf40ac2e7fa80b36c76a3a75c389/venv/lucifer/jobx.py

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/f33f2c3d98603c529ee542cccb5cb21357c5aac1

commit f33f2c3d98603c529ee542cccb5cb21357c5aac1
Author: Allen Li <ayatane@google.com>
Date: Wed Feb 21 22:20:04 2018

Fix typo in flag name

BUG= chromium:810141 
TEST=None

Change-Id: Iff21cd06ab4cf3f0c9a2817a6076e859a3630b42
Reviewed-on: https://chromium-review.googlesource.com/927863
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/f33f2c3d98603c529ee542cccb5cb21357c5aac1/src/chromiumos/infra/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/45c2fdf4005cd257d8870401759173303350b88f

commit 45c2fdf4005cd257d8870401759173303350b88f
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 22 20:21:40 2018

[autotest] Stop passing flags directly to lucifer

Passing flags directly through to lucifer is confusing, since some
flags come from job_reporter, some come from monitor_db.

This adds some redundant argument parsing to job_reporter, but is much
easier to grok.

Move -autotestdir, -watcherpath, and -resultsdir first.  Gathering has
its own flags, migrate those later.

BUG= chromium:810141 
TEST=None

Change-Id: Ic716bdabfa97e8f1fe024924ff62551af1dc7ec9
Reviewed-on: https://chromium-review.googlesource.com/920921
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/45c2fdf4005cd257d8870401759173303350b88f/venv/lucifer/cmd/job_reporter.py
[modify] https://crrev.com/45c2fdf4005cd257d8870401759173303350b88f/scheduler/luciferlib.py
[modify] https://crrev.com/45c2fdf4005cd257d8870401759173303350b88f/venv/lucifer/autotest.py

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cbbdc8d505b42e0c0fa3eb4b7b529b4623a86f97

commit cbbdc8d505b42e0c0fa3eb4b7b529b4623a86f97
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 22 20:21:41 2018

[autotest] Make job_reporter --results-dir required

BUG= chromium:810141 
TEST=None

Change-Id: I66eb2e38f668c5d05c5fde8e7aeeb815506317e6
Reviewed-on: https://chromium-review.googlesource.com/927821
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/cbbdc8d505b42e0c0fa3eb4b7b529b4623a86f97/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a22a974228f972c2d4198505305429bb6ef4fd26

commit a22a974228f972c2d4198505305429bb6ef4fd26
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 22 20:24:29 2018

[autotest] [1/2] Pass lucifer level option

BUG= chromium:810141 
TEST=None

Change-Id: I2af80fbbc684ca54c148b1355996ba5653bd7fbe
Reviewed-on: https://chromium-review.googlesource.com/927210
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/a22a974228f972c2d4198505305429bb6ef4fd26/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c7cd1de94f558bdb0530af619d6a228880b3ef49

commit c7cd1de94f558bdb0530af619d6a228880b3ef49
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 22 20:24:29 2018

[autotest] [2/2] Pass lucifer level option

Hard code the level because these two entry points will always be at
this level.

There will be new entry points for future levels.

BUG= chromium:810141 
TEST=None

Change-Id: I9bbd68c43ce316360bafff02748e10b083eeb048
Reviewed-on: https://chromium-review.googlesource.com/927211
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/c7cd1de94f558bdb0530af619d6a228880b3ef49/scheduler/luciferlib.py

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bf4b370a6f979d4803d953e9918532fa8a2f54b4

commit bf4b370a6f979d4803d953e9918532fa8a2f54b4
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 22 23:59:16 2018

[autotest] Pass -x-resultsdir instead of -resultsdir

The latter is deprecated.

See https://chromium-review.googlesource.com/#/c/919538/

BUG= chromium:810141 
TEST=None

Change-Id: I009860c19bf8f89ba94b9d92a8564564561cef7f
Reviewed-on: https://chromium-review.googlesource.com/927384
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/bf4b370a6f979d4803d953e9918532fa8a2f54b4/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3710b6d8242804a74dbf8b9a19854fd51c40c7bb

commit 3710b6d8242804a74dbf8b9a19854fd51c40c7bb
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 24 02:19:43 2018

[autotest] Add lucifer STARTING shims

BUG= chromium:810141 
TEST=None

Change-Id: I737b4f93e7373f3cf97afbb342f64c869ba2930f
Reviewed-on: https://chromium-review.googlesource.com/912559
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/3710b6d8242804a74dbf8b9a19854fd51c40c7bb/scheduler/luciferlib.py
[modify] https://crrev.com/3710b6d8242804a74dbf8b9a19854fd51c40c7bb/scheduler/monitor_db.py

Project Member

Comment 29 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bdd96af8aebeb585dbcd6958d7083f730b244639

commit bdd96af8aebeb585dbcd6958d7083f730b244639
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 24 02:19:41 2018

[autotest] Stop passing event arg to handlers

Originally included in case a handler needed to explicitly check the
event.

Actually, that should not ever be needed.

BUG= chromium:810141 
TEST=None

Change-Id: I7ada8ff5cada8436aa1de27a9a2597a58a3cfcb3
Reviewed-on: https://chromium-review.googlesource.com/927616
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/bdd96af8aebeb585dbcd6958d7083f730b244639/venv/lucifer/handlers.py

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fe4c57743d1611442e2e077d6a8d5761356ff03d

commit fe4c57743d1611442e2e077d6a8d5761356ff03d
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 24 02:19:42 2018

[autotest] Add initial host state handlers

The logic behind host status changes is complex and skylab should not
implement it.  That logic should be moved into lucifer proper.

To prepare for that, move the details of how to update host status
into standalone handlers. _handle_x_tests_done will only contain
business logic (what state to change and not how to change it), and
lucifer can start emitting the new events instead of x_tests_done.

BUG= chromium:810141 
TEST=Run dummy suite locally

Change-Id: I610417ff185df1145fccf6b2860b4ae698d36a70
Reviewed-on: https://chromium-review.googlesource.com/927617
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/fe4c57743d1611442e2e077d6a8d5761356ff03d/venv/lucifer/handlers.py
[modify] https://crrev.com/fe4c57743d1611442e2e077d6a8d5761356ff03d/venv/lucifer/eventlib.py
[modify] https://crrev.com/fe4c57743d1611442e2e077d6a8d5761356ff03d/venv/lucifer/jobx.py

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bc6599ce133dea0af938fe0fb76d82726b3dcd35

commit bc6599ce133dea0af938fe0fb76d82726b3dcd35
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 24 02:19:43 2018

[autotest] Make --lucifer-level required

BUG= chromium:810141 
TEST=None

Change-Id: Ieb501493cc1ce69dc6051887d7597432e4c1bad9
Reviewed-on: https://chromium-review.googlesource.com/932550
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/bc6599ce133dea0af938fe0fb76d82726b3dcd35/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e0376f423a9b4920f548115921b7cb7809c7b4db

commit e0376f423a9b4920f548115921b7cb7809c7b4db
Author: Allen Li <ayatane@chromium.org>
Date: Sat Feb 24 02:19:44 2018

[autotest] Remove flags passed directly to lucifer

BUG= chromium:810141 
TEST=None

Change-Id: I3769cf32f7ce88451b9b8e201936c1007deb356c
Reviewed-on: https://chromium-review.googlesource.com/932652
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/e0376f423a9b4920f548115921b7cb7809c7b4db/scheduler/luciferlib.py

Project Member

Comment 33 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d84961d5381dbd629636859fd789868f78b943dd

commit d84961d5381dbd629636859fd789868f78b943dd
Author: Allen Li <ayatane@chromium.org>
Date: Mon Feb 26 19:41:26 2018

[autotest] [1/2] Don't passthrough lucifer gathering flags

BUG= chromium:810141 
TEST=None

Change-Id: I67e42acf49ea29f34e072601e53fc106c2d7f0ac
Reviewed-on: https://chromium-review.googlesource.com/932653
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/d84961d5381dbd629636859fd789868f78b943dd/venv/lucifer/cmd/job_reporter.py
[modify] https://crrev.com/d84961d5381dbd629636859fd789868f78b943dd/scheduler/luciferlib.py

Project Member

Comment 34 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e2c9842ea96f40aa6ed3637eba47dc092b406dbc

commit e2c9842ea96f40aa6ed3637eba47dc092b406dbc
Author: Allen Li <ayatane@chromium.org>
Date: Mon Feb 26 19:41:27 2018

[autotest] [2/2] Don't passthrough lucifer gathering flags

BUG= chromium:810141 
TEST=None

Change-Id: I0882ff610b8ad52fa367d35dd77da85d7161ab1f
Reviewed-on: https://chromium-review.googlesource.com/932654
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/e2c9842ea96f40aa6ed3637eba47dc092b406dbc/scheduler/luciferlib.py

Project Member

Comment 35 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/645fa2aff1eed7ec5ddb43264b4be16d6275839e

commit 645fa2aff1eed7ec5ddb43264b4be16d6275839e
Author: Allen Li <ayatane@chromium.org>
Date: Mon Feb 26 19:41:27 2018

[autotest] Disallow passthrough lucifer args

BUG= chromium:810141 
TEST=None

Change-Id: I8de19c97a04f2b7e5cb0927db263fa3ffc1e036b
Reviewed-on: https://chromium-review.googlesource.com/932655
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/645fa2aff1eed7ec5ddb43264b4be16d6275839e/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 36 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/1f5426400223b9c18fa432a3f6ae7daa71be7b46

commit 1f5426400223b9c18fa432a3f6ae7daa71be7b46
Author: Allen Li <ayatane@google.com>
Date: Mon Feb 26 22:10:07 2018

[1/2] Change lucifer path

Use shorter path per Chromium OS policy:

chromiumos/infra/lucifer -> lucifer

Policy is to use a top level name if the package isnt planned to be
reused.  I mistakenly entertained the idea of making the code suitable
for reuse as a library with a namespaced path.  The chances of that
happening are zero; if there is reusable code, that code can be moved
to a separate repo or even a separate namespaced package within this
repo.  As it is, this just makes the paths long and unwieldy.

Need to first copy the packages and then update the ebuild with the
new package path before deleting the old files.

BUG= chromium:810141 
TEST=None

Change-Id: Iea8da29304ba59c6d724f3495fa07508becb86a1
Reviewed-on: https://chromium-review.googlesource.com/930136
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/abortsock/abortsock_test.go
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/event/event_test.go
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/cmd/lucifer_run_job/main.go
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/abortsock/abortsock.go
[modify] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/Makefile
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/multierror/multierror.go
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/multierror/multierror_test.go
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/cmd/lucifer_watcher/main.go
[modify] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/README.md
[add] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/lucifer/event/event.go

Project Member

Comment 37 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/39ae75c859340bf515128784dd27de17adf6473a

commit 39ae75c859340bf515128784dd27de17adf6473a
Author: Allen Li <ayatane@chromium.org>
Date: Tue Feb 27 06:07:34 2018

lucifer: Change binary paths

BUG= chromium:810141 
TEST=None
CQ-DEPEND=CL:930136

Change-Id: Ib4ce79670decab13a70494bffa8cd9ee4eb976af
Reviewed-on: https://chromium-review.googlesource.com/930138
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/39ae75c859340bf515128784dd27de17adf6473a/chromeos-base/lucifer/lucifer-9999.ebuild

Project Member

Comment 38 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/2e3ae8fd5f1ab491d24a68d2859756c7e6e15a56

commit 2e3ae8fd5f1ab491d24a68d2859756c7e6e15a56
Author: Allen Li <ayatane@google.com>
Date: Wed Feb 28 23:21:09 2018

[2/2] Change lucifer path

Use shorter path per Chromium OS policy:

chromiumos/infra/lucifer -> lucifer

Policy is to use a top level name if the package isnt planned to be
reused.  I mistakenly entertained the idea of making the code suitable
for reuse as a library with a namespaced path.  The chances of that
happening are zero; if there is reusable code, that code can be moved
to a separate repo or even a separate namespaced package within this
repo.  As it is, this just makes the paths long and unwieldy.

Need to first copy the packages and then update the ebuild with the
new package path before deleting the old files.

BUG= chromium:810141 
TEST=None
CQ-DEPEND=CL:930138

Change-Id: I13bab5efe0f18d39d7b5bc096e91f7cd10fd4713
Reviewed-on: https://chromium-review.googlesource.com/930137
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/event/event.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/multierror/multierror_test.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/cmd/lucifer_watcher/main.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/multierror/multierror.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/event/event_test.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/cmd/lucifer_run_job/main.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/abortsock/abortsock_test.go
[delete] https://crrev.com/1f5426400223b9c18fa432a3f6ae7daa71be7b46/src/chromiumos/infra/lucifer/abortsock/abortsock.go

Project Member

Comment 39 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/7c28b78132460bae661052ce6fc94f2bfd09fe75

commit 7c28b78132460bae661052ce6fc94f2bfd09fe75
Author: Allen Li <ayatane@google.com>
Date: Thu Mar 01 05:29:48 2018

Remove -x-hosts flag

BUG= chromium:810141 
TEST=None

Change-Id: Ia7af5f883644976a195a1547a3eaa1590e528b0e
Reviewed-on: https://chromium-review.googlesource.com/932642
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/7c28b78132460bae661052ce6fc94f2bfd09fe75/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 40 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3b5b1f8f527d21d94865f06941eac4d3c998344f

commit 3b5b1f8f527d21d94865f06941eac4d3c998344f
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 18:00:04 2018

[autotest] Add new lucifer events

These events need to be recognized to be handled.

BUG= chromium:810141 
TEST=None

Change-Id: I36a1b82b7c7eac22ec4b176433c67e15204cb576
Reviewed-on: https://chromium-review.googlesource.com/941558
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/3b5b1f8f527d21d94865f06941eac4d3c998344f/venv/lucifer/handlers.py
[modify] https://crrev.com/3b5b1f8f527d21d94865f06941eac4d3c998344f/venv/lucifer/eventlib.py

Project Member

Comment 41 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a55ca4ffab66b5045a2c98f365185540055af412

commit a55ca4ffab66b5045a2c98f365185540055af412
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 18:00:05 2018

[autotest] Implement GATHERING handler

Currently, this event is emitted by jobs already in GATHERING, so this
does nothing (sets GATHERING HQEs to GATHERING).  In the future,
lucifer jobs will need to have this event handled so the HQEs get
updated along with the job.

Landing this separately to reduce review load later.

BUG= chromium:810141 
TEST=None

Change-Id: I85de2b2f0aacd0b1cd8c41f4a368527116033ac4
Reviewed-on: https://chromium-review.googlesource.com/942106
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/a55ca4ffab66b5045a2c98f365185540055af412/venv/lucifer/handlers.py

Project Member

Comment 42 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8bb357b469ed59d048c95785bec7ee5056b0a32a

commit 8bb357b469ed59d048c95785bec7ee5056b0a32a
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 18:00:06 2018

[autotest] Organize job_reporter arguments

Theres going to be more later, so organize now while they are few.

BUG= chromium:810141 
TEST=None

Change-Id: I870f809cb11999aa2f2bc4c28ef9263f6b177240
Reviewed-on: https://chromium-review.googlesource.com/942107
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/8bb357b469ed59d048c95785bec7ee5056b0a32a/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 43 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/292b4ca373d34bdb3dd1383e7f98c15216f6def9

commit 292b4ca373d34bdb3dd1383e7f98c15216f6def9
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 18:00:07 2018

[autotest] Organize lucifer argument construction

Theres going to be more later, so organize now while they are few.

BUG= chromium:810141 
TEST=None

Change-Id: I3cc8e6fe9023abe07158097fe10c0dce19f622fe
Reviewed-on: https://chromium-review.googlesource.com/942108
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/292b4ca373d34bdb3dd1383e7f98c15216f6def9/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 44 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/56d818f804e3f1d353b47318c39a290453b8cc0e

commit 56d818f804e3f1d353b47318c39a290453b8cc0e
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 19:52:15 2018

[autotest] Fix handler order

Logically, running comes before gathering.  I munged the order while
rebasing.  Commit separately for ease of review.

BUG= chromium:810141 
TEST=None

Change-Id: I32a7e33c2c58831ffb04c63507856bb35e6a4e21
Reviewed-on: https://chromium-review.googlesource.com/942462
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/56d818f804e3f1d353b47318c39a290453b8cc0e/venv/lucifer/handlers.py

Project Member

Comment 45 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/518762318e82d16ee7507221614135cdddb2fe46

commit 518762318e82d16ee7507221614135cdddb2fe46
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 21:32:50 2018

[autotest] Replace autoserv_exit check

tl;dr New code path will not pass autoserv_exit, keep assertion for
old code path for good measure.

In terms of design, no state should be passed to EventHandler at all.
However, the old code path used an experimental path which kept some
business logic inside EventHandler (which is bad).

But I cant be bothered to fix it for the old code path, which is
being replaced by the new code path, and to avoid breaking the current
prod code path (no touch, no new bugs).

So in the interim, autoserv_exit will exist, and the old
_handle_x_tests_done path will exist.

Ultimately, these will be purged from EventHandler.

BUG= chromium:810141 
TEST=None

Change-Id: I51cc8d18c72b62c7237878ba5eb291ebdc8f1159
Reviewed-on: https://chromium-review.googlesource.com/942467
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/518762318e82d16ee7507221614135cdddb2fe46/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 46 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/27002fe39c70f2684ee77ac3102ed2a16020812f

commit 27002fe39c70f2684ee77ac3102ed2a16020812f
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 21:32:51 2018

[autotest] Fix class reference

BUG= chromium:810141 
TEST=None

Change-Id: Ie47cbcb772002b8c37c3d1b4279a6891cd64edec
Reviewed-on: https://chromium-review.googlesource.com/944614
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/27002fe39c70f2684ee77ac3102ed2a16020812f/scheduler/monitor_db.py

Project Member

Comment 47 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d459bc09d7a09837b2bc5fc1d6a08883658f5cfc

commit d459bc09d7a09837b2bc5fc1d6a08883658f5cfc
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 21:32:51 2018

[autotest] Fix is_hostless logic error

BUG= chromium:810141 
TEST=None

Change-Id: I3809eb0dc7536fb2a6708937d17f4146d841ccf6
Reviewed-on: https://chromium-review.googlesource.com/944615
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d459bc09d7a09837b2bc5fc1d6a08883658f5cfc/venv/lucifer/jobx.py

Project Member

Comment 48 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0b80a4b092a837d5a3bf00760b3a881bff15ecbe

commit 0b80a4b092a837d5a3bf00760b3a881bff15ecbe
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 05 21:32:52 2018

[autotest] Add earliest argument reporting

Use the entire arg vector, making it easy to run the exact
job_reporter command outside of Autotest scheduler for testing.

BUG= chromium:810141 
TEST=None

Change-Id: I46d48c9d9db0d79e9d477e7fe71ec799249f3075
Reviewed-on: https://chromium-review.googlesource.com/944616
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/0b80a4b092a837d5a3bf00760b3a881bff15ecbe/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 49 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/c6a5704ba0a0ca1e1b7d82c9237561cb49adef5b

commit c6a5704ba0a0ca1e1b7d82c9237561cb49adef5b
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 07 01:22:21 2018

Factor out autoservCmd

Constructing this command is rocket science.  Wrap this with a Go API
to reuse for running the test autoserv.

BUG= chromium:810141 
TEST=None

Change-Id: I74b63425d6b46575071755c29de74b7b79f7ee03
Reviewed-on: https://chromium-review.googlesource.com/942165
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/c6a5704ba0a0ca1e1b7d82c9237561cb49adef5b/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 50 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/bfa5bf3d703c4385e6b79798329a2231c507138c

commit bfa5bf3d703c4385e6b79798329a2231c507138c
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 07 01:22:23 2018

Add autoserv arguments needed for running tests

BUG= chromium:810141 
TEST=None

Change-Id: I938c4f7746eb9faa37998aae741afc5d9d4060da
Reviewed-on: https://chromium-review.googlesource.com/942166
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/bfa5bf3d703c4385e6b79798329a2231c507138c/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 51 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/814ab938cabe703b30097bf7812618e3addbb339

commit 814ab938cabe703b30097bf7812618e3addbb339
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 07 01:22:24 2018

Add extra flags needed for lucifer STARTING

Theres a ton of these, so committing separately so its easier to
review.

BUG= chromium:810141 
TEST=None

Change-Id: If1f374cef4c6ad3323dca7d97f4871bb6241007e
Reviewed-on: https://chromium-review.googlesource.com/942362
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/814ab938cabe703b30097bf7812618e3addbb339/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 52 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/885908524794df90a20e73dded1738212148b387

commit 885908524794df90a20e73dded1738212148b387
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 07 01:22:21 2018

Document parseArgs error behavior

sys.Exit() behavior from flags is convenient, but document to avoid
surprises.

BUG= chromium:810141 
TEST=None

Change-Id: Ide3e556e57c9d624b02e369cd4ede9402670b74c
Reviewed-on: https://chromium-review.googlesource.com/942363
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/885908524794df90a20e73dded1738212148b387/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 53 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/294dcb3ac2ac75441fe7d715d1e29508966c2c6f

commit 294dcb3ac2ac75441fe7d715d1e29508966c2c6f
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 07 01:22:22 2018

Add Host events

Extra events that need to be emitted and handled.

BUG= chromium:810141 
TEST=None

Change-Id: Ice71d822088158be5993f17c3d44424279808b60
Reviewed-on: https://chromium-review.googlesource.com/942366
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/294dcb3ac2ac75441fe7d715d1e29508966c2c6f/src/lucifer/event/event.go

Project Member

Comment 54 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/deb5d3bb3df646a1c2493129168b459d923b5fac

commit deb5d3bb3df646a1c2493129168b459d923b5fac
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 07 22:26:25 2018

[autotest] Fix argument help typo

BUG= chromium:810141 
TEST=None

Change-Id: Ib3c0dfaa25d972ef3d45e08c13f3d1be732cfa29
Reviewed-on: https://chromium-review.googlesource.com/952094
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/deb5d3bb3df646a1c2493129168b459d923b5fac/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 55 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7096f9892dba4343ab5e0bb0a20198462840e434

commit 7096f9892dba4343ab5e0bb0a20198462840e434
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 07 22:26:26 2018

[autotest] Improve jobx functions

BUG= chromium:810141 
TEST=None

Change-Id: Iabc5e4735440e00d610e342cc3c51263311ac6bb
Reviewed-on: https://chromium-review.googlesource.com/952095
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/7096f9892dba4343ab5e0bb0a20198462840e434/venv/lucifer/jobx.py

Project Member

Comment 56 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4e058e33d55ed6099312702788e61ad89de85dac

commit 4e058e33d55ed6099312702788e61ad89de85dac
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 10 03:20:42 2018

[autotest] Add STARTING support to monitor_db

BUG= chromium:810141 
TEST=None

Change-Id: Ia0761c793a48abb7e33dca66d53b4750e82df93b
Reviewed-on: https://chromium-review.googlesource.com/912560
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4e058e33d55ed6099312702788e61ad89de85dac/scheduler/luciferlib.py

Project Member

Comment 57 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/164e8ebe9569dd40ce0338c2c9dbd76acb4f6311

commit 164e8ebe9569dd40ce0338c2c9dbd76acb4f6311
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 10 03:20:42 2018

[autotest] Add STARTING support to job_reporter

This is one (large) half of adding STARTING support on the Autotest
side (the other half is adding monitor_db support for calling
job_reporter at STARTING level).

Landing this separately to reduce cognitive load during review, since
everything here is independent of the monitor_db half except the
flags/args passed.

BUG= chromium:810141 
TEST=None

Change-Id: Ie59836d8c63d2db3af5b6bae6fe64af3b4f8f2c8
Reviewed-on: https://chromium-review.googlesource.com/942109
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/164e8ebe9569dd40ce0338c2c9dbd76acb4f6311/venv/lucifer/cmd/job_reporter.py
[modify] https://crrev.com/164e8ebe9569dd40ce0338c2c9dbd76acb4f6311/venv/lucifer/jobx.py

Project Member

Comment 58 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6c17f1d49b689729c1543e5cb3da353079d6d810

commit 6c17f1d49b689729c1543e5cb3da353079d6d810
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 10 03:20:40 2018

[autotest] Pass job object through job_reporter

It turns out this needs to be used a lot, so its worth adding a cache
parameter everywhere to avoid hitting the database repeatedly.

BUG= chromium:810141 
TEST=None

Change-Id: Ie27dd66cce6f68928709c7fc09309eb86766b312
Reviewed-on: https://chromium-review.googlesource.com/952096
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/6c17f1d49b689729c1543e5cb3da353079d6d810/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 59 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/34dc9c86768df8870fc1b5f8f55d8bd781d2a494

commit 34dc9c86768df8870fc1b5f8f55d8bd781d2a494
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 10 03:20:41 2018

[autotest] Add test status events

These are used to get autoserv_exit information to job_reporter from
lucifer.

BUG= chromium:810141 
TEST=None

Change-Id: I390bb147129a12a91562f27c2f0ec793b2536904
Reviewed-on: https://chromium-review.googlesource.com/952243
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/34dc9c86768df8870fc1b5f8f55d8bd781d2a494/venv/lucifer/handlers.py
[modify] https://crrev.com/34dc9c86768df8870fc1b5f8f55d8bd781d2a494/venv/lucifer/eventlib.py

Project Member

Comment 60 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/e33ca5b3b85d24993209a7d339b6993c4eb72f2c

commit e33ca5b3b85d24993209a7d339b6993c4eb72f2c
Author: Allen Li <ayatane@google.com>
Date: Sat Mar 10 06:59:15 2018

Remove deprecated -resultsdir flag

BUG= chromium:810141 
TEST=None

Change-Id: I0fc309e8750a8804ff5b8c06ddbf42ffb41edbc1
Reviewed-on: https://chromium-review.googlesource.com/952089
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/e33ca5b3b85d24993209a7d339b6993c4eb72f2c/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 61 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/073295dbfa3f81d5c85f4d7d4e400faa2d3ff6b9

commit 073295dbfa3f81d5c85f4d7d4e400faa2d3ff6b9
Author: Allen Li <ayatane@google.com>
Date: Sat Mar 10 06:59:16 2018

Fix -x-run-reset flag description

BUG= chromium:810141 
TEST=None

Change-Id: Icbf59bd4a8c1781192f41191206cbdc7ff021533
Reviewed-on: https://chromium-review.googlesource.com/952090
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/073295dbfa3f81d5c85f4d7d4e400faa2d3ff6b9/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 62 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/bf067b01b15e0ce2bb065c9b88fb45a838bc96e5

commit bf067b01b15e0ce2bb065c9b88fb45a838bc96e5
Author: Allen Li <ayatane@google.com>
Date: Mon Mar 12 19:52:38 2018

Add more flags for lucifer STARTING

BUG= chromium:810141 
TEST=None

Change-Id: I6a1f360c874a8a8cdbabd2c54e9867908c1a7a66
Reviewed-on: https://chromium-review.googlesource.com/952091
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/bf067b01b15e0ce2bb065c9b88fb45a838bc96e5/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 63 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/739315d2be505b7f7d2394b08e70d48b6967f5c6

commit 739315d2be505b7f7d2394b08e70d48b6967f5c6
Author: Allen Li <ayatane@google.com>
Date: Mon Mar 12 22:24:34 2018

Create autotest package

BUG= chromium:810141 
TEST=None

Change-Id: Ibe27521a5229bde2b52955b95724b2b9d1b8645f
Reviewed-on: https://chromium-review.googlesource.com/952218
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[add] https://crrev.com/739315d2be505b7f7d2394b08e70d48b6967f5c6/src/lucifer/autotest/autotest.go
[modify] https://crrev.com/739315d2be505b7f7d2394b08e70d48b6967f5c6/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 64 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/c40dce382bb03b580d02566f22b5bcb73e942a0c

commit c40dce382bb03b580d02566f22b5bcb73e942a0c
Author: Allen Li <ayatane@google.com>
Date: Mon Mar 12 22:24:35 2018

Add sendHostStatus

This will be convenient for sending host statuses.  Commit separately
for sanity.

BUG= chromium:810141 
TEST=None

Change-Id: Ia29b18a500b39764c7b185941e694068ecf86063
Reviewed-on: https://chromium-review.googlesource.com/952219
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/c40dce382bb03b580d02566f22b5bcb73e942a0c/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 65 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/b4427fdfbcb73765f4624ba5a706bad4275fb591

commit b4427fdfbcb73765f4624ba5a706bad4275fb591
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 13 01:05:11 2018

Add test status events

These will be used to signal whether tests passed or failed
independent of completed status.

The immediate use case is signaling that autoserv failed and to mark
the autotest job as failed.

This is intended to be general enough to support reporting
individual test pass or failure while lucifer is still running and
notably before parsing, even though there is no mechanism to really
act on that early information yet.

BUG= chromium:810141 
TEST=None

Change-Id: Ibbfe70035afd718ca3a90e091bcabb709b1d08b8
Reviewed-on: https://chromium-review.googlesource.com/952220
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/b4427fdfbcb73765f4624ba5a706bad4275fb591/src/lucifer/event/event.go

Project Member

Comment 66 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/6cc15be5fcce3838aae668d087b9c790a3f7580a

commit 6cc15be5fcce3838aae668d087b9c790a3f7580a
Author: Allen Li <ayatane@google.com>
Date: Tue Mar 13 03:56:53 2018

Add STARTING support

BUG= chromium:810141 
TEST=None

Change-Id: Ic33d297eb73687e5d3a8cfcba7c10e9b56012a47
Reviewed-on: https://chromium-review.googlesource.com/907689
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/6cc15be5fcce3838aae668d087b9c790a3f7580a/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 67 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dbf56d4a971c6fe272eba6c26d30df6618084a19

commit dbf56d4a971c6fe272eba6c26d30df6618084a19
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 21 22:55:43 2018

[autotest] Remove unused _abort_jobs_if_timedout

No grep hits in autotest code base.

BUG= chromium:810141 
TEST=None

Change-Id: Icb94eb40242500cb9401214701a08620a7b24745
Reviewed-on: https://chromium-review.googlesource.com/972553
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/dbf56d4a971c6fe272eba6c26d30df6618084a19/server/cros/dynamic_suite/job_status.py

Project Member

Comment 68 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/897b754feb15c5aafeda9f0345afb042425818f8

commit 897b754feb15c5aafeda9f0345afb042425818f8
Author: Allen Li <ayatane@chromium.org>
Date: Thu Mar 22 01:30:35 2018

[autotest] Move _handle_x_tests_done

Its better organized this way

BUG= chromium:810141 
TEST=None

Change-Id: Ide9ddee515e5cf4c9eb7b3d2bc7b14d1c8017b0c
Reviewed-on: https://chromium-review.googlesource.com/972554
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/897b754feb15c5aafeda9f0345afb042425818f8/venv/lucifer/handlers.py

Project Member

Comment 69 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a83d52223777f8dca18c3657d9524247b6537f89

commit a83d52223777f8dca18c3657d9524247b6537f89
Author: Allen Li <ayatane@chromium.org>
Date: Thu Mar 22 01:30:36 2018

[autotest] Factor out _mark_job_complete()

BUG= chromium:810141 
TEST=None

Change-Id: Ia1820d66014821a3279d312172b3632e139546ed
Reviewed-on: https://chromium-review.googlesource.com/972555
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/a83d52223777f8dca18c3657d9524247b6537f89/venv/lucifer/handlers.py

Project Member

Comment 70 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6d351230e3536c1b431519e939a0b1b7212e1ee6

commit 6d351230e3536c1b431519e939a0b1b7212e1ee6
Author: Allen Li <ayatane@chromium.org>
Date: Thu Mar 22 01:30:37 2018

[autotest] Factor out _mark_hqes_complete()

BUG= chromium:810141 
TEST=None

Change-Id: Id8b70aafee149884315914030b1628599ebe01bb
Reviewed-on: https://chromium-review.googlesource.com/972556
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/6d351230e3536c1b431519e939a0b1b7212e1ee6/venv/lucifer/handlers.py

Project Member

Comment 71 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4e88b418b2d70cd431a2f2c701622a0baad3be67

commit 4e88b418b2d70cd431a2f2c701622a0baad3be67
Author: Allen Li <ayatane@chromium.org>
Date: Thu Mar 22 01:30:38 2018

[autotest] Factor out _release_job_if_sharded()

BUG= chromium:810141 
TEST=None

Change-Id: I0c0bf28097b6f8bd0da8e6418a1b967bfbdd2409
Reviewed-on: https://chromium-review.googlesource.com/972557
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/4e88b418b2d70cd431a2f2c701622a0baad3be67/venv/lucifer/handlers.py

Project Member

Comment 72 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eab3425132432475701db2586dec5c28cdcaee2a

commit eab3425132432475701db2586dec5c28cdcaee2a
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 24 00:42:51 2018

[autotest] Factor out _stop_job_if_necessary()

BUG= chromium:810141 
TEST=None

Change-Id: I08f3f4975f92fa2fc13081300dcc69d59a10f424
Reviewed-on: https://chromium-review.googlesource.com/972558
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/eab3425132432475701db2586dec5c28cdcaee2a/venv/lucifer/handlers.py

Project Member

Comment 73 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d36796658e16f25799f0ca639b9601fe17bbc077

commit d36796658e16f25799f0ca639b9601fe17bbc077
Author: Allen Li <ayatane@chromium.org>
Date: Sat Mar 24 02:21:40 2018

[autotest] Add abort event

BUG= chromium:810141 
TEST=None

Change-Id: I51ca5abfafd869a794066ee99543133f4c4c4ada
Reviewed-on: https://chromium-review.googlesource.com/972559
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d36796658e16f25799f0ca639b9601fe17bbc077/venv/lucifer/eventlib.py

Project Member

Comment 74 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5efcde30b410a6bb7562cd5442b3cf7147212805

commit 5efcde30b410a6bb7562cd5442b3cf7147212805
Author: Allen Li <ayatane@chromium.org>
Date: Mon Mar 26 23:57:28 2018

[autotest] Add abort event handler

BUG= chromium:810141 
TEST=None

Change-Id: Ieb0d79348e4e8fa2f5b1f5d2d6fa55e19d6d60f4
Reviewed-on: https://chromium-review.googlesource.com/972560
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/5efcde30b410a6bb7562cd5442b3cf7147212805/venv/lucifer/handlers.py

Project Member

Comment 75 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d1a2b81532444833dd4397badc07c7aedbd1f820

commit d1a2b81532444833dd4397badc07c7aedbd1f820
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:23 2018

[autotest] Use Django update_fields

Our version, Django 1.5, has this feature.  It should help performance.

BUG= chromium:810141 
TEST=None

Change-Id: Ib569222a9c563cb4ed0b8167d370fea5a60e5421
Reviewed-on: https://chromium-review.googlesource.com/972561
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/d1a2b81532444833dd4397badc07c7aedbd1f820/venv/lucifer/handlers.py

Project Member

Comment 76 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4a46e86e2af1c89f320d0a2af790c199b54ad28c

commit 4a46e86e2af1c89f320d0a2af790c199b54ad28c
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:24 2018

[autotest] Factor out _mark_hqe_aborted()

BUG= chromium:810141 
TEST=None

Change-Id: Ib109c1da2e71ac577d80ad5f0310d2cfdc5d9243
Reviewed-on: https://chromium-review.googlesource.com/972583
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/4a46e86e2af1c89f320d0a2af790c199b54ad28c/venv/lucifer/handlers.py

Project Member

Comment 77 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1a26632eefd1ea5543b15740f97c204eec38785d

commit 1a26632eefd1ea5543b15740f97c204eec38785d
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:24 2018

[autotest] Ignore lucifer jobs for aborting in scheduler

BUG= chromium:810141 
TEST=None

Change-Id: If1fe285c49200f8db6e48da4c61e392a0f707892
Reviewed-on: https://chromium-review.googlesource.com/978935
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/1a26632eefd1ea5543b15740f97c204eec38785d/scheduler/monitor_db.py

Project Member

Comment 78 by bugdroid1@chromium.org, Mar 27 2018

Project Member

Comment 79 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4115687b71ea5025fdedf7ff71aacceab3caacbc

commit 4115687b71ea5025fdedf7ff71aacceab3caacbc
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:27 2018

[autotest] Factor out _write_keyvals()

Going to start cleaning up some of the mess after adding a significant
amount of lucifer code.

Move some stuff around so that the keyvals logic can be moved to a
separate module (this logic currently lives in the scheduler, but
lucifer is taking the job running responsibility away from the
scheduler).

BUG= chromium:810141 
TEST=None

Change-Id: I4f82502d40d8e5463f8e5eff05813e0a2e55eae1
Reviewed-on: https://chromium-review.googlesource.com/978960
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/4115687b71ea5025fdedf7ff71aacceab3caacbc/venv/lucifer/jobx.py

Project Member

Comment 80 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aa9bf4c7b702616f5fe81cc02a8794903e2af515

commit aa9bf4c7b702616f5fe81cc02a8794903e2af515
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:27 2018

[autotest] Factor out _write_host_keyvals()

Move some stuff around so that the keyvals logic can be moved to a
separate module (this logic currently lives in the scheduler, but
lucifer is taking the job running responsibility away from the
scheduler).

BUG= chromium:810141 
TEST=None

Change-Id: Icfe7fc182fd7451a9fd746ed2c5b18f79e7fb7a3
Reviewed-on: https://chromium-review.googlesource.com/978961
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/aa9bf4c7b702616f5fe81cc02a8794903e2af515/venv/lucifer/jobx.py

Project Member

Comment 81 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/24a5ad7bee848aca6cb4c45c6341596dac0a261c

commit 24a5ad7bee848aca6cb4c45c6341596dac0a261c
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:28 2018

[autotest] Factor out results module

BUG= chromium:810141 
TEST=None

Change-Id: I7392540f5167f9fb11f9d3f8873b7be959af7520
Reviewed-on: https://chromium-review.googlesource.com/978962
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/24a5ad7bee848aca6cb4c45c6341596dac0a261c/venv/lucifer/jobx.py
[add] https://crrev.com/24a5ad7bee848aca6cb4c45c6341596dac0a261c/venv/lucifer/results.py

Project Member

Comment 82 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/54a139382e0044f88030bafb4bdcc067b4800414

commit 54a139382e0044f88030bafb4bdcc067b4800414
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:29 2018

[autotest] Inline _prepare_host_keyvals_files()

BUG= chromium:810141 
TEST=None

Change-Id: Ie4dd24ebb6ce7791e83498e92447cd98f7e9d017
Reviewed-on: https://chromium-review.googlesource.com/978963
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/54a139382e0044f88030bafb4bdcc067b4800414/venv/lucifer/jobx.py

Project Member

Comment 83 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f5bba2a35e1f693cee760ca258829b5fd0126166

commit f5bba2a35e1f693cee760ca258829b5fd0126166
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:29 2018

[autotest] Fix leasing docstring

Leasing is now entirely the concern for the Python code.

BUG= chromium:810141 
TEST=None

Change-Id: Icec37ff9d98dafa4939b9589231f331b0eb16a38
Reviewed-on: https://chromium-review.googlesource.com/978964
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/f5bba2a35e1f693cee760ca258829b5fd0126166/venv/lucifer/leasing.py

Project Member

Comment 84 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15b3e21c979847f448443d3a298b92b42c21106b

commit 15b3e21c979847f448443d3a298b92b42c21106b
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:30 2018

[autotest] Add future imports to lucifer modules

BUG= chromium:810141 
TEST=None

Change-Id: I2e7f535eea9107c0ff3066fc674721c194741030
Reviewed-on: https://chromium-review.googlesource.com/978965
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/15b3e21c979847f448443d3a298b92b42c21106b/venv/lucifer/jobx.py
[modify] https://crrev.com/15b3e21c979847f448443d3a298b92b42c21106b/venv/lucifer/results.py

Project Member

Comment 85 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/561cc6583a3292b64b1b3920da2df103dc2d4487

commit 561cc6583a3292b64b1b3920da2df103dc2d4487
Author: Allen Li <ayatane@chromium.org>
Date: Tue Mar 27 01:30:26 2018

[autotest] Abort HQEs atomically in lucifer

BUG= chromium:810141 
TEST=None

Change-Id: I0e2d5d4e1d720ac01f62e4a83321a982d76f19af
Reviewed-on: https://chromium-review.googlesource.com/979036
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/561cc6583a3292b64b1b3920da2df103dc2d4487/venv/lucifer/handlers.py

Project Member

Comment 86 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/75273a7c06b839dc53b4501ba84cdd3f91bf68a4

commit 75273a7c06b839dc53b4501ba84cdd3f91bf68a4
Author: Allen Li <ayatane@chromium.org>
Date: Wed Mar 28 17:47:04 2018

[autotest] Allow other test status events than autoserv

These are used by skylab to distinguish test failures.  Autotest
doesnt care since we get the individual test results from TKO.

BUG= chromium:810141 
TEST=None

Change-Id: I2a901773501d66a24fadb6a87201f84d38e1ce68
Reviewed-on: https://chromium-review.googlesource.com/981679
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/75273a7c06b839dc53b4501ba84cdd3f91bf68a4/venv/lucifer/handlers.py

Project Member

Comment 87 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/250fe81a169b08e4cfcab31c948eeb1a04787f46

commit 250fe81a169b08e4cfcab31c948eeb1a04787f46
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:26 2018

Simplify error handling

Be more disciplined in error handling and also get rid of some
annoying boilerplate.

The idea is to handle errors conclusively instead of logging them and
passing a large stack of errors around.

The guiding principles used here:

1. Return an error if
   a. the caller is expecting something to be done and needs to be
      notified if that thing is not done (e.g., opening a file fails), and
   b. a parent caller could potentially handle that error
      meaningfully.

2. If an error is handled by logging it, then the error is handled and
   theres no need to pass that error around "in case" something
   "might" want to examine or introspect it.  Nothing is going to
   introspect a multierror and handle it, realistically speaking.

BUG= chromium:810141 
TEST=None

Change-Id: I1fa43d14f0fdce6d321fd2bfa47485c464e05ca2
Reviewed-on: https://chromium-review.googlesource.com/974316
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/250fe81a169b08e4cfcab31c948eeb1a04787f46/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 88 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/a1e2a0239b011ce68ad7217fece2322ad2665052

commit a1e2a0239b011ce68ad7217fece2322ad2665052
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:32 2018

Add aborting

BUG= chromium:810141 
TEST=None

Change-Id: If2c48f7728a4ab6eb8cfa7d126582ca644dfe63f
Reviewed-on: https://chromium-review.googlesource.com/974317
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/a1e2a0239b011ce68ad7217fece2322ad2665052/src/lucifer/cmd/lucifer_run_job/main.go
[modify] https://crrev.com/a1e2a0239b011ce68ad7217fece2322ad2665052/src/lucifer/event/event.go

Project Member

Comment 89 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/4ae4f9c18336468c9b8025846753c24191bf0041

commit 4ae4f9c18336468c9b8025846753c24191bf0041
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:27 2018

Factor out doParsingStep

BUG= chromium:810141 
TEST=None

Change-Id: Id702d261435dd4090ba451a105a1ce9931b8bf42
Reviewed-on: https://chromium-review.googlesource.com/974465
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4ae4f9c18336468c9b8025846753c24191bf0041/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 90 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/034a8448b2b552b39c73e484a54afefb93ddf44e

commit 034a8448b2b552b39c73e484a54afefb93ddf44e
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:28 2018

Pass jobState by pointer everywhere.

Its just less confusing this way.  As an added justification,
jobState is a little big to be passing it on the stack.

BUG= chromium:810141 
TEST=None

Change-Id: I7fd74b35c762e731f141c30ed1f2b6701a92bdb7
Reviewed-on: https://chromium-review.googlesource.com/974466
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/034a8448b2b552b39c73e484a54afefb93ddf44e/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 91 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/204ea95b31ecd5b2596de69e619dac0a044bcb68

commit 204ea95b31ecd5b2596de69e619dac0a044bcb68
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:29 2018

Factor out doRunningStep

BUG= chromium:810141 
TEST=None

Change-Id: I6696e186de15094758c4490829b82a4de1746d0f
Reviewed-on: https://chromium-review.googlesource.com/974701
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/204ea95b31ecd5b2596de69e619dac0a044bcb68/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 92 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/9f93500331c2f44a063a30e068915a90df141fb4

commit 9f93500331c2f44a063a30e068915a90df141fb4
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:29 2018

Factor out doGatheringStep

BUG= chromium:810141 
TEST=None

Change-Id: I4995c154cd957c48cbe9c30ddd3444a7eedf35be
Reviewed-on: https://chromium-review.googlesource.com/974702
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/9f93500331c2f44a063a30e068915a90df141fb4/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 93 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/973e0fcec8e29cb896f37d91dca16963aad66342

commit 973e0fcec8e29cb896f37d91dca16963aad66342
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:30 2018

Add unwatchedCommand for AutoservCommand

autoserv implements its own process group management, so theres no
point using our watcher.

BUG= chromium:810141 
TEST=None

Change-Id: I8f06340cce8acc1b9e0f27c3a295a5579a065d55
Reviewed-on: https://chromium-review.googlesource.com/974703
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/973e0fcec8e29cb896f37d91dca16963aad66342/src/lucifer/autotest/autotest.go

Project Member

Comment 94 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/7a71e9fcd989aca7c5d27412e2901d67a618df10

commit 7a71e9fcd989aca7c5d27412e2901d67a618df10
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:31 2018

Factor out doHost{Less,}RunningStep

BUG= chromium:810141 
TEST=None

Change-Id: I0217cc280e00f57762cecf33f3c9305ebd0386f1
Reviewed-on: https://chromium-review.googlesource.com/974704
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/7a71e9fcd989aca7c5d27412e2901d67a618df10/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 95 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/ba145b2f98fae85c54a70cdb7702914064f943a9

commit ba145b2f98fae85c54a70cdb7702914064f943a9
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:33 2018

Write job finished keyval

BUG= chromium:810141 
TEST=None

Change-Id: Id7cf706c27e4d6294f8f0da327912e83c12fa91d
Reviewed-on: https://chromium-review.googlesource.com/978787
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/ba145b2f98fae85c54a70cdb7702914064f943a9/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 96 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/8059177b3b8ba6d394e072d751f1c4022bd220d9

commit 8059177b3b8ba6d394e072d751f1c4022bd220d9
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:35 2018

Describe timeout parameter in runWithAbort

BUG= chromium:810141 
TEST=None

Change-Id: I902bfe4896e41b7e1757d447467cdf9d9e596e4e
Reviewed-on: https://chromium-review.googlesource.com/981449
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/8059177b3b8ba6d394e072d751f1c4022bd220d9/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 97 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/db4e750a15a6cb2f62b92f6463f7965ae189bedb

commit db4e750a15a6cb2f62b92f6463f7965ae189bedb
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:33 2018

Internalize handleTest error handling

BUG= chromium:810141 
TEST=None

Change-Id: I3ad2a8e3dd5cd13be86d63e606359949b2111162
Reviewed-on: https://chromium-review.googlesource.com/981455
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/db4e750a15a6cb2f62b92f6463f7965ae189bedb/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 98 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/b42f684517348865027c2c4895c3b7e63be6191d

commit b42f684517348865027c2c4895c3b7e63be6191d
Author: Allen Li <ayatane@google.com>
Date: Wed Mar 28 23:40:34 2018

Inline doHost{less,}RunningStep

Removing the error handling tilts the complexity scale for these
function in the other direction.

BUG= chromium:810141 
TEST=None

Change-Id: I8b9919305d1c52300a8716cd9840e0666a10e97d
Reviewed-on: https://chromium-review.googlesource.com/981456
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/b42f684517348865027c2c4895c3b7e63be6191d/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 99 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/10d18d55aadfdd67644fa5c928cb1160d2ca4d29

commit 10d18d55aadfdd67644fa5c928cb1160d2ca4d29
Author: Allen Li <ayatane@google.com>
Date: Thu Mar 29 02:34:04 2018

Handle the number of autotest test failures

BUG= chromium:810141 
TEST=None

Change-Id: I39a0a1aed24fa1dff62e1d02940420cc5a28cee4
Reviewed-on: https://chromium-review.googlesource.com/980799
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/10d18d55aadfdd67644fa5c928cb1160d2ca4d29/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 100 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/31e4dbd957dc442c78d192b033ac5ac2043f1a25

commit 31e4dbd957dc442c78d192b033ac5ac2043f1a25
Author: Allen Li <ayatane@google.com>
Date: Thu Mar 29 02:34:05 2018

Emit TestFailed for failed tests

This gives skylab a way to distinguish test failures.

BUG= chromium:810141 
TEST=None

Change-Id: I3b34d7fae6a81c2590354de64901088cdec80831
Reviewed-on: https://chromium-review.googlesource.com/981678
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/31e4dbd957dc442c78d192b033ac5ac2043f1a25/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 101 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/2c6f2cbccf35c2bbb65916a52a1c12389430210c

commit 2c6f2cbccf35c2bbb65916a52a1c12389430210c
Author: Allen Li <ayatane@google.com>
Date: Thu Mar 29 02:34:05 2018

Return non-zero for infra errors

BUG= chromium:810141 
TEST=None

Change-Id: I434c209b6bdd3a18632953e21b0ca8661685c024
Reviewed-on: https://chromium-review.googlesource.com/982650
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/2c6f2cbccf35c2bbb65916a52a1c12389430210c/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 102 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/e867ca9baed3f9bc76f305b69ea85215cdc6dc93

commit e867ca9baed3f9bc76f305b69ea85215cdc6dc93
Author: Allen Li <ayatane@chromium.org>
Date: Thu Mar 29 19:12:07 2018

Project Member

Comment 103 by bugdroid1@chromium.org, Mar 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/4f670d2da60f403146583e421f9350cc7474e8e6

commit 4f670d2da60f403146583e421f9350cc7474e8e6
Author: Allen Li <ayatane@google.com>
Date: Sat Mar 31 01:14:29 2018

Blockedon: 827423
Project Member

Comment 105 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/9eeb51ea713c3e7390a8f69899741df9f628943b

commit 9eeb51ea713c3e7390a8f69899741df9f628943b
Author: Allen Li <ayatane@google.com>
Date: Mon Apr 02 22:21:07 2018

Use autoserv pidfile instead of parse pidfile

We need to get the number of failed tests before parsing runs; the
wrong file was being used.

BUG= chromium:810141 
TEST=None

Change-Id: I560a8dd25008f6e03c2b55620cc36c993231e008

[modify] https://crrev.com/9eeb51ea713c3e7390a8f69899741df9f628943b/src/lucifer/cmd/lucifer_run_job/main.go

Project Member

Comment 106 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/ff94b1898dc8c5e337206b1d7f40f433b50730ba

commit ff94b1898dc8c5e337206b1d7f40f433b50730ba
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 03 01:05:02 2018

Project Member

Comment 107 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1ff598fba282616c846a3bc51f38d745a128ec03

commit 1ff598fba282616c846a3bc51f38d745a128ec03
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 05 03:55:32 2018

autotest-server: Roll out Lucifer STARTING

BUG= chromium:810141 
TEST=Tested locally and in staging lab

Change-Id: I1eccf8a512f0c1dc8ae4b62cd0499013f1cafba1
Reviewed-on: https://chromium-review.googlesource.com/996753
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/1ff598fba282616c846a3bc51f38d745a128ec03/chromeos-base/autotest-server/files/autotest_setup.conf

Project Member

Comment 108 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/28ace445e8aea714b267486e5b21755d6e7dab3d

commit 28ace445e8aea714b267486e5b21755d6e7dab3d
Author: Allen Li <ayatane@chromium.org>
Date: Thu Apr 05 17:41:41 2018

Project Member

Comment 109 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/ca72bc5c5401d690b227aba2be6c1f07bb5a1aa3

commit ca72bc5c5401d690b227aba2be6c1f07bb5a1aa3
Author: Allen Li <ayatane@google.com>
Date: Fri Apr 06 23:48:48 2018

Project Member

Comment 110 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/16d0ef87b954070be142bb1ede1c95f476ca7fe7

commit 16d0ef87b954070be142bb1ede1c95f476ca7fe7
Author: Allen Li <ayatane@chromium.org>
Date: Tue Apr 10 18:06:59 2018

[autotest] Fix indentation

BUG= chromium:810141 
TEST=None

Change-Id: I7ac10ddb4c2ce08e377b406cbbf8688b081a0f22
Reviewed-on: https://chromium-review.googlesource.com/999174
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/16d0ef87b954070be142bb1ede1c95f476ca7fe7/scheduler/luciferlib.py

Project Member

Comment 111 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/03558ba51794722c869e01e529490e91e5339bdb

commit 03558ba51794722c869e01e529490e91e5339bdb
Author: Allen Li <ayatane@chromium.org>
Date: Wed Apr 11 20:10:55 2018

Project Member

Comment 113 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e865651785406fa72549fe4f8e039656e3e8798e

commit e865651785406fa72549fe4f8e039656e3e8798e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Apr 27 04:10:10 2018

[autotest] Change lucifer default to STARTING

BUG= chromium:810141 
TEST=None

Change-Id: I721ee0d751e6e2e4b53c2ea8df23328defa3ea97
Reviewed-on: https://chromium-review.googlesource.com/999172
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/e865651785406fa72549fe4f8e039656e3e8798e/scheduler/monitor_db_unittest.py
[modify] https://crrev.com/e865651785406fa72549fe4f8e039656e3e8798e/global_config.ini

Project Member

Comment 114 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fe44fdee1ed52339aa3e6b30e6bfdbe1a3fa2fce

commit fe44fdee1ed52339aa3e6b30e6bfdbe1a3fa2fce
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 28 00:24:52 2018

[autotest] Remove more lucifer GATHERING code

BUG= chromium:810141 
TEST=None

Change-Id: Iaa171886848ccc6e45cb16de1b5c6f264a135f73
Reviewed-on: https://chromium-review.googlesource.com/1014272
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/fe44fdee1ed52339aa3e6b30e6bfdbe1a3fa2fce/venv/lucifer/cmd/job_reporter.py

Project Member

Comment 115 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/78bdada802e9ac157fb74b77c1cacc807d87d9c3

commit 78bdada802e9ac157fb74b77c1cacc807d87d9c3
Author: Allen Li <ayatane@chromium.org>
Date: Sat Apr 28 00:24:51 2018

[autotest] Remove lucifer GATHERING code

BUG= chromium:810141 
TEST=None

Change-Id: I5507c676d9eed9823a1fc12698ddf44483be47bb
Reviewed-on: https://chromium-review.googlesource.com/999173
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/78bdada802e9ac157fb74b77c1cacc807d87d9c3/scheduler/luciferlib.py
[modify] https://crrev.com/78bdada802e9ac157fb74b77c1cacc807d87d9c3/scheduler/monitor_db.py

Status: Fixed (was: Started)
Showing comments 17 - 116 of 116 Older

Sign in to add a comment