[zlib]: Enable use of HAVE_HIDDEN |
|||
Issue descriptionHidden symbols has quite a few advantages (https://gcc.gnu.org/wiki/Visibility), and zlib makes use of this compiler feature through ZLIB_INTERNAL. Issue is it seems we don't define HAVE_HIDDEN anywhere, as a result ZLIB_INTERNAL won't use __attribute__(visibility("hidden")) and will be just an empty define.
,
Feb 9 2018
Looking at the code src/third_party/zlib/zutil.h
16: #ifdef HAVE_HIDDEN
17: # define ZLIB_INTERNAL __attribute__((visibility ("hidden")))
18: #else
19: # define ZLIB_INTERNAL
20: #endif
Agree, we don't define HAVE_HIDDEN anywhere. Thank goodness for name mangling.
ZLIB_INTERNAL seems to used in zlib to indicate that an API is internal to zlib, and not part of the public API.
,
Feb 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cavalcantii@chromium.org
, Feb 7 2018