New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810121 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 672311
issue 810128



Sign in to add a comment

add browsertests for viz-hit-test

Project Member Reported by riajiang@chromium.org, Feb 7 2018

Issue description

We need to test all the browsertests in site-per-process-hit-test-browsertests with --use-viz-hit-test config turned on.

 
Blocking: 810128
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116df0e74bfda27a42fe15ef675bcfe944eea7b7

commit 116df0e74bfda27a42fe15ef675bcfe944eea7b7
Author: Ria Jiang <riajiang@chromium.org>
Date: Tue Feb 13 17:29:32 2018

Set event screen positions in site_per_process_hit_test_browsertests.

We only set blink::WebPointerProperties::position_in_widget and
ui::LocatedEvent::location in site_per_process_hit_test_browsertests.

However, in Viz hit-test, we need to use events' screen locations for
targeting. This CL sets that in all the hit-test related browsertests.

This should have no effect in current test configs. I have tested them
locally with the viz-hit-test flag set. A follow-up CL will set up the
viz-hit-test config and address any failing tests.

Bug:  810121 
Change-Id: I630933787741e61948b348000b86455cbe77969d
Reviewed-on: https://chromium-review.googlesource.com/915424
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536399}
[modify] https://crrev.com/116df0e74bfda27a42fe15ef675bcfe944eea7b7/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/116df0e74bfda27a42fe15ef675bcfe944eea7b7/content/browser/site_per_process_hit_test_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5db6e915a8cdcdda4500934959bff3d77d56fff7

commit 5db6e915a8cdcdda4500934959bff3d77d56fff7
Author: Ria Jiang <riajiang@chromium.org>
Date: Fri Feb 23 22:11:14 2018

Hit-test related site-per-process-browsertests with Viz hit-test.

This CL runs SitePerProcessHitTestBrowserTest,
SitePerProcessHighDPIHitTestBrowserTest,
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest,
SitePerProcessInternalsHitTestBrowserTest,
SitePerProcessMouseWheelHitTestBrowserTest,
SitePerProcessGestureHitTestBrowserTest with
--use-viz-hit-test-draw-quad flag turned on.

1. Updated SetWebEventPositions and UpdateEventRootLocation to compute
the correct screen coordiantes.

2. Added two TODOs for Viz hit-test in
MouseClickWithNonIntegerScaleFactor.MouseClickWithNonIntegerScaleFactor
and SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone.

Bug:  810121 
Change-Id: I8b4d470fe76a8cbb489151fe4c113462b8982243
Reviewed-on: https://chromium-review.googlesource.com/919260
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538917}
[modify] https://crrev.com/5db6e915a8cdcdda4500934959bff3d77d56fff7/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/5db6e915a8cdcdda4500934959bff3d77d56fff7/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4486d7c259f81416c4f716376a4f9d9148be97

commit dc4486d7c259f81416c4f716376a4f9d9148be97
Author: jonross <jonross@chromium.org>
Date: Mon Feb 26 14:52:07 2018

Update FYI Viz filter for Hit Tests Tests

A follow up to https://chromium-review.googlesource.com/c/chromium/src/+/919260
which updated the filter on the CQ. This updates the FYI filter to match changes
in the test naming.

TBR=riajiang@chromium.org

Bug:  810121 
Change-Id: I4d4f968204432a65cbd50caca002be809389ab53
Reviewed-on: https://chromium-review.googlesource.com/937385
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539129}
[modify] https://crrev.com/dc4486d7c259f81416c4f716376a4f9d9148be97/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment