New issue
Advanced search Search tips

Issue 810120 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge min visits set to 20 in M65

Project Member Reported by mlamouri@chromium.org, Feb 7 2018

Issue description

This is a two character change: changing the min visits from 4 to 20. It will have very little impact except changing some data sent to us via UKM/histograms. However, the goal is to simplify the merge of  bug 807268  as even if it's changing a constants, it's changing a lot of tests that are affected by this constant and the change in  bug 807268  is also changing those tetsts.
 
Labels: -Merge-Request-65 Merge-Approved-65
Approving merge to M65 branch 3325 based on offline chat. 
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1

commit 3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Feb 07 21:43:34 2018

Media Engagement: update warm up periode to 20 visits.

Bug:  810120 
Change-Id: I834310cc536a57d6a1ab0ac86dc2ee8b78856812
Reviewed-on: https://chromium-review.googlesource.com/885764
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531893}(cherry picked from commit 3dbaf64e35b4a05012d5d2b55de6b9d667ebe8ff)
Reviewed-on: https://chromium-review.googlesource.com/907551
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#373}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1/chrome/browser/media/media_engagement_autoplay_browsertest.cc
[modify] https://crrev.com/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/3b16ddf9bf38f7f9e982a4b04f969dd9cfc000c1/chrome/browser/media/media_engagement_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment