Remove titlecase strings for widget headings |
||||
Issue descriptionThis does not apply to native dialogs, specifically the Mac menu and any Cocoa surface. This style should also be documented better in living documentation.
,
Feb 13 2018
Per internal discussion, we're moving forward with unifying dialog heading strings as sentence case. This aligns with Mac message style as we're also dictating that these dialogs should have full sentences as their headings. Buttons and menu items will have duplicate .grd entries for now.
,
Feb 13 2018
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9899f618e385275abce26fa0988bbb801bff146 commit a9899f618e385275abce26fa0988bbb801bff146 Author: Peter Boström <pbos@chromium.org> Date: Wed Feb 14 00:01:21 2018 Revert "Add missing titlecase for device-chooser titles." This reverts commit 200620648d0c09e472eb3a41378ee2ce26bf693e. Reason for revert: Titlecasing bubble titles is no longer relevant. Original change's description: > Add missing titlecase for device-chooser titles. > > Adds use_titlecase entries for USB device selection, Bluetooth pairing > and device permissions. > > Bug: chromium:807886 > Change-Id: I355d944e151c14967998d283d5ad578ba512ae9d > Reviewed-on: https://chromium-review.googlesource.com/898246 > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534561} TBR=lazyboy@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:807886 , chromium:810111 Change-Id: Ib23cdfc01cedd382785c0e111faaac2507b1b95e Reviewed-on: https://chromium-review.googlesource.com/917341 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#536560} [modify] https://crrev.com/a9899f618e385275abce26fa0988bbb801bff146/chrome/app/generated_resources.grd [modify] https://crrev.com/a9899f618e385275abce26fa0988bbb801bff146/extensions/strings/extensions_strings.grd
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9074255377636e080f441d44ff83ccc851f0c1e1 commit 9074255377636e080f441d44ff83ccc851f0c1e1 Author: Peter Boström <pbos@chromium.org> Date: Wed Feb 14 22:47:28 2018 Unify dialog titles in generated_resources.grd Turns most dialog titles in generated_resources.grd into sentence case on all platforms. Password ones aren't touched yet as they require approvals for reverting a test check that verifies that "This Site" is present in the resulting string. Bug: chromium:810111 Change-Id: I94be076df5078c96e2dc700581dc50db2afda177 Reviewed-on: https://chromium-review.googlesource.com/917649 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536856} [modify] https://crrev.com/9074255377636e080f441d44ff83ccc851f0c1e1/chrome/app/generated_resources.grd
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/289e5a211c75b3c55389184116d793863ddec5ec commit 289e5a211c75b3c55389184116d793863ddec5ec Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 01:02:41 2018 Use sentence case for JS app-modal bubble titles Covers widget dialog title sentence case for app_modal_strings.grdp. This reverts the dialog titles to pre-titlecase "www.google.com says" since this no longer looks wonky when there's no titlecase version of it. Bug: chromium:810111 Change-Id: I5f72d704629dfc1da1522c4a34707c5864a44947 Reviewed-on: https://chromium-review.googlesource.com/917467 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536911} [modify] https://crrev.com/289e5a211c75b3c55389184116d793863ddec5ec/components/app_modal/javascript_dialog_manager_unittest.cc [modify] https://crrev.com/289e5a211c75b3c55389184116d793863ddec5ec/components/app_modal_strings.grdp
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90e87f6e4cfbe6580de832c8962b13e6df599a2a commit 90e87f6e4cfbe6580de832c8962b13e6df599a2a Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 14:46:40 2018 Make UX-requested changes to JS app-modal titles Also updates the desc of IDS_BEFOREUNLOAD_MESSAGEBOX_MESSAGE to make the context clearer. Bug: chromium:810111 Change-Id: I21f8022eb1e2c71eec68e17d33d45693dad11e7e Reviewed-on: https://chromium-review.googlesource.com/920787 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537013} [modify] https://crrev.com/90e87f6e4cfbe6580de832c8962b13e6df599a2a/components/app_modal_strings.grdp
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a7e32a3bb3142085386ec7f8e57f8011ad3af02 commit 7a7e32a3bb3142085386ec7f8e57f8011ad3af02 Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 14:47:53 2018 Unify some widget-title strings in chrome/app Unifies strings for titles as sentence case in bookmark_strings.grdp, chromium_strings.grd and google_chrome_strings.grd. This intentionally leaves generated_strings.grd as a separate change as it's expected to be huge. Also fixes titlecase style for an existing string. Bug: chromium:810111 Change-Id: I587928b6fd8b30cb040dbbf38dd5a2d7249517d4 Reviewed-on: https://chromium-review.googlesource.com/917216 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537014} [modify] https://crrev.com/7a7e32a3bb3142085386ec7f8e57f8011ad3af02/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/7a7e32a3bb3142085386ec7f8e57f8011ad3af02/chrome/app/chromium_strings.grd [modify] https://crrev.com/7a7e32a3bb3142085386ec7f8e57f8011ad3af02/chrome/app/google_chrome_strings.grd
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/167fdbd10f70ab135b133c0f7aafc1dc82167186 commit 167fdbd10f70ab135b133c0f7aafc1dc82167186 Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 15:47:39 2018 Update two translate / page-info title strings These were requested by UX; the translation string is just a shorter simplification and the page-info string uses a full sentence to match dialog title style (and the other titles for this bubble). Bug: chromium:810111 , chromium:812362 Change-Id: I7e7e166a246423070a0e0b3518a8acc92acabfde Reviewed-on: https://chromium-review.googlesource.com/920701 Reviewed-by: Patti <patricialor@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537026} [modify] https://crrev.com/167fdbd10f70ab135b133c0f7aafc1dc82167186/chrome/app/generated_resources.grd [modify] https://crrev.com/167fdbd10f70ab135b133c0f7aafc1dc82167186/components/page_info_strings.grdp
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77f472e2119a2379ce1a8b0f50e2447e7fd121cd commit 77f472e2119a2379ce1a8b0f50e2447e7fd121cd Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 16:10:08 2018 Use titlecase for autofill-bubble titles Covers widget dialog title sentence case for autofill_strings.grdp. Bug: chromium:810111 Change-Id: I56cbb0188c4af039f35b5ede8f1cc192a9cdc543 Reviewed-on: https://chromium-review.googlesource.com/917432 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#537033} [modify] https://crrev.com/77f472e2119a2379ce1a8b0f50e2447e7fd121cd/components/autofill_strings.grdp
,
Feb 15 2018
c#1 is addressed via go/harmony-titlecase-unification-plan (sorry, internal-only) All involved parties agree that's the proper way to go forward. Short (possibly incomplete) summary: "On macOS, dialog titles as sentences in sentence case, buttons & menu items remain in title case"
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93eb7c22fc01163cce29b5ef41f9a1f8b23232df commit 93eb7c22fc01163cce29b5ef41f9a1f8b23232df Author: Peter Boström <pbos@chromium.org> Date: Thu Feb 15 18:04:57 2018 Use sentence case for login-dialog title Covers widget dialog title sentence case for login_dialog_strings.grdp. UX also requested updates to these strings so those are done as well. TBR=blundell@chromium.org Bug: chromium:810111 , chromium:812362 Change-Id: Ib95706198a0089f1ad479c9efa917f703d9d25bd Reviewed-on: https://chromium-review.googlesource.com/917402 Reviewed-by: Rachel Blum <groby@chromium.org> Commit-Queue: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#537067} [modify] https://crrev.com/93eb7c22fc01163cce29b5ef41f9a1f8b23232df/components/login_dialog_strings.grdp
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/983bbbe49ecf6736567572d74f1e79478b18c6b9 commit 983bbbe49ecf6736567572d74f1e79478b18c6b9 Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 16 03:56:01 2018 Use sentence case for bookmark-editor title Covers widget dialog title sentence case for bookmark_component_strings.grdp. TBR=blundell@chromium.org Bug: chromium:810111 Change-Id: I7e0fda476aaaf43d7906a50e302fd4ccc9227142 Reviewed-on: https://chromium-review.googlesource.com/917424 Reviewed-by: Rachel Blum <groby@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537186} [modify] https://crrev.com/983bbbe49ecf6736567572d74f1e79478b18c6b9/components/bookmark_component_strings.grdp
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09af7df0a82d3612d2c6b8cd2e80ba65f64cbe6c commit 09af7df0a82d3612d2c6b8cd2e80ba65f64cbe6c Author: Peter Boström <pbos@chromium.org> Date: Mon Feb 26 17:51:27 2018 Use sentence case for password-manager bubbles Removes use_titlecase entries for bubble titles and reverts the corresponding prior test update. It's not a pure revert as "Password Saved" is removed as a title as well. Bug: chromium:810111 Change-Id: I1582ac05e859b8a53d19490b4ab52f47c03d7fe1 Reviewed-on: https://chromium-review.googlesource.com/932916 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539190} [modify] https://crrev.com/09af7df0a82d3612d2c6b8cd2e80ba65f64cbe6c/chrome/app/generated_resources.grd [modify] https://crrev.com/09af7df0a82d3612d2c6b8cd2e80ba65f64cbe6c/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2472475178ae563942e23c6f59a94c529287c774 commit 2472475178ae563942e23c6f59a94c529287c774 Author: Peter Boström <pbos@chromium.org> Date: Tue Feb 27 00:10:40 2018 Remove titlecasing for payments-dialog titles Keeps section labels in conditional titlecase as they can be displayed as the bubble heading and are properly titles within the dialog. It also replaces 'Your payment' with 'Review your payment' to provide a full sentence. Bug: chromium:810111 , chromium:812362 Change-Id: I4db492f772339e5a32fb92e1f3027d9aa047a67b Reviewed-on: https://chromium-review.googlesource.com/935748 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539318} [modify] https://crrev.com/2472475178ae563942e23c6f59a94c529287c774/components/payments_strings.grdp
,
Feb 27 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by shrike@chromium.org
, Feb 7 2018