New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810079 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Connecting to 802.1x with Certificate from Guest Mode does not fail with proper error.

Project Member Reported by aashuto...@chromium.org, Feb 7 2018

Issue description

Chrome Version: <From about:version: Google Chrome 10323.17.0>
Chrome OS Version: <From about:version: Platform 65.0.3325.56>
Chrome OS Platform: <Eve/Candy>
Network info: <WiFi>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
Procedure
1.Login as a guest user
2.Install the CA and client certificates for the 802.1x network
3.Try connecting to 802.1x  with EAP method TLS

Expected Result:
OS should fail with "User certificates must be hardware backed error"

Actual Result:
OS tries to connect even when the certs are not hardware backed and fails with EAP-auth error.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always
What is the impact to the user, and is there a workaround? If so, what is
it?
End user confusion, if the user can connect to cert network logged in as user but not as guest. 
 
Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Expected.png
76.8 KB View Download
current.png
297 KB View Download
Labels: -Pri-1 -ReleaseBlock-Stable -M-65 M-66 Pri-2
Status: Assigned (was: Untriaged)
Kind of an edge case, deprioritizing and removing RBS.

Labels: -M-66 M-67
Status: Started (was: Assigned)
Labels: -M-67 M-66
Moving back to 66. There were a number of certificate related edge cases that were not being handled well in the UI that are fixed in a CL currently in review.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10b1a043487cc2887111f97445b69e31cf7f6f5

commit e10b1a043487cc2887111f97445b69e31cf7f6f5
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Mar 06 01:25:22 2018

Network Config: Improve certificate UI

This CL:
* Disables non hardware backed user certs
* Displays an error message when no user certs or no hardware backed
  certs are available
* Fixes edge cases where certifiates are added or removed while the
  config UI is visible
* Adds/improves configuration event logging

Bug:  810079 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f2374d16bf2300fd2937c8ce873d40cf4c44321
Reviewed-on: https://chromium-review.googlesource.com/949442
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541018}
[modify] https://crrev.com/e10b1a043487cc2887111f97445b69e31cf7f6f5/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/e10b1a043487cc2887111f97445b69e31cf7f6f5/chromeos/network/managed_network_configuration_handler_impl.cc
[modify] https://crrev.com/e10b1a043487cc2887111f97445b69e31cf7f6f5/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/e10b1a043487cc2887111f97445b69e31cf7f6f5/ui/webui/resources/cr_components/chromeos/network/network_config.js

Labels: Merge-Request-66
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 7 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: pneubeck@chromium.org krisr@chromium.org bmahadev@chromium.org tienchang@chromium.org steve...@chromium.org
 Issue 434543  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 8 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/172735961c1e46f572ae353054a111616b930a75

commit 172735961c1e46f572ae353054a111616b930a75
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Mar 08 18:15:18 2018

Network Config: Improve certificate UI

This CL:
* Disables non hardware backed user certs
* Displays an error message when no user certs or no hardware backed
  certs are available
* Fixes edge cases where certifiates are added or removed while the
  config UI is visible
* Adds/improves configuration event logging

TBR=stevenjb@chromium.org

(cherry picked from commit e10b1a043487cc2887111f97445b69e31cf7f6f5)

Bug:  810079 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f2374d16bf2300fd2937c8ce873d40cf4c44321
Reviewed-on: https://chromium-review.googlesource.com/949442
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541018}
Reviewed-on: https://chromium-review.googlesource.com/956088
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#102}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/172735961c1e46f572ae353054a111616b930a75/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/172735961c1e46f572ae353054a111616b930a75/chromeos/network/managed_network_configuration_handler_impl.cc
[modify] https://crrev.com/172735961c1e46f572ae353054a111616b930a75/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/172735961c1e46f572ae353054a111616b930a75/ui/webui/resources/cr_components/chromeos/network/network_config.js

Verified on Eve R70-11021.23.0, 70.0.3538.28
Status: Verified (was: Fixed)

Sign in to add a comment