New issue
Advanced search Search tips

Issue 810078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[root layer scrolls] Context menu doesn't appear when scrolled

Project Member Reported by bokan@chromium.org, Feb 7 2018

Issue description

OS Version: Linux

What steps will reproduce the problem?
1. Start Chrome with --root-layer-scrolls
2. Visit a scrollable page, scroll down
3. Right click to show context menu

What is the expected result?
Context menu appears at mouse location

What happens instead of that?
Context menu appears above cursor, potentially offscreen.

Works without root-layer-scrolls. Works when not scrolled.
 

Comment 1 by bokan@chromium.org, Feb 7 2018

Blocking: 417782
Owner: chrishtr@chromium.org
Status: Assigned (was: Available)
Owner: skobes@chromium.org
I can't reproduce this on Linux at ToT.

Comment 4 by bokan@chromium.org, Feb 7 2018

I'm seeing this at r534693 on ToT
Status: Started (was: Assigned)
Seems related to device scale factor.  I can repro on high DPI.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d6ca1de73795626a71f6f3f69c73a2736738aa

commit 77d6ca1de73795626a71f6f3f69c73a2736738aa
Author: Steve Kobes <skobes@chromium.org>
Date: Thu Feb 08 17:23:12 2018

Fix mouse event coordinate computations with browser zoom.

LocalFrameView::DocumentToAbsolute expects unzoomed CSS pixels.  Two
call sites in MouseEvent are updated to use it correctly.

Bug:  810078 
Change-Id: I8cfda651c6cd5d69d44e95af3321340b50068204
Reviewed-on: https://chromium-review.googlesource.com/908113
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535419}
[add] https://crrev.com/77d6ca1de73795626a71f6f3f69c73a2736738aa/third_party/WebKit/LayoutTests/fast/events/mouse-relative-position-zoomed.html
[modify] https://crrev.com/77d6ca1de73795626a71f6f3f69c73a2736738aa/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/77d6ca1de73795626a71f6f3f69c73a2736738aa/third_party/WebKit/Source/core/events/MouseEvent.h

Status: Fixed (was: Started)

Sign in to add a comment