New issue
Advanced search Search tips

Issue 810077 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 844416



Sign in to add a comment

MessageLoopTypedTest.RecursivePosts/IO (34515 ms) flakes under Fuchsia/x64/Debug FYI bot

Project Member Reported by w...@chromium.org, Feb 7 2018

Issue description

This flaked in run https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/15962 with timings:

[00254.906] 03969.04017> [2885/2894] MessageLoopTypedTest.RunLoopQuitOrderDuring/IO (1 ms)
[00254.907] 03969.04017> [2886/2894] MessageLoopTypedTest.RunLoopQuitOrderDuring/UI (1 ms)
[00254.907] 03969.04017> [2887/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/Default (1 ms)
[00254.908] 03969.04017> [2888/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/IO (2 ms)
[00254.908] 03969.04017> [2889/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/UI (3 ms)
[00254.909] 03969.04017> [2890/2894] MessageLoopTypedTest.RecursivePosts/Default (1149 ms)
[00254.909] 03969.04017> [ RUN      ] MessageLoopTypedTest.RecursivePosts/IO
[00254.909] 03969.04017> [       OK ] MessageLoopTypedTest.RecursivePosts/IO (46366 ms)
[00254.911] 03969.04017> [ RUN      ] MessageLoopTypedTest.RecursivePosts/UI
[00254.911] 03969.04017> [       OK ] MessageLoopTypedTest.RecursivePosts/UI (12412 ms)
[00254.911] 03969.04017> [ RUN      ] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/Default
[00254.912] 03969.04017> [       OK ] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/Default (0 ms)
[00254.912] 03969.04017> [ RUN      ] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/IO
[00254.913] 03969.04017> [       OK ] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/IO (1 ms)
[00254.913] 03969.04017> [----------] 10 tests from MessageLoopTypedTest (60210 ms total)
[00254.914] 03969.04017>
[00254.914] 03969.04017> [----------] Global test environment tear-down
[00254.914] 03969.04017> [==========] 10 tests from 1 test case ran. (60233 ms total)
[00254.915] 03969.04017> [  PASSED  ] 10 tests.
[00254.915] 03969.04017> [2891/2894] MessageLoopTypedTest.RecursivePosts/IO (TIMED OUT)
[00254.916] 03969.04017> [2892/2894] MessageLoopTypedTest.RecursivePosts/UI (12412 ms)
...
[00258.289] 03969.04017> Tests took 251 seconds.

When the test passes (e.g. https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia%20%28dbg%29/15988), the reported timings from the relevant sub-process look like:

[00203.252] 03939.04001> [2885/2894] MessageLoopTypedTest.RunLoopQuitOrderDuring/IO (12 ms)
[00203.252] 03939.04001> [2886/2894] MessageLoopTypedTest.RunLoopQuitOrderDuring/UI (1 ms)
[00203.252] 03939.04001> [2887/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/Default (9 ms)
[00203.253] 03939.04001> [2888/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/IO (1 ms)
[00203.253] 03939.04001> [2889/2894] MessageLoopTypedTest.RunLoopQuitOrderAfter/UI (1 ms)
[00203.253] 03939.04001> [2890/2894] MessageLoopTypedTest.RecursivePosts/Default (1002 ms)
[00203.254] 03939.04001> [2891/2894] MessageLoopTypedTest.RecursivePosts/IO (34515 ms)
[00203.254] 03939.04001> [2892/2894] MessageLoopTypedTest.RecursivePosts/UI (9792 ms)
[00203.255] 03939.04001> [2893/2894] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/Default (0 ms)
[00203.255] 03939.04001> [2894/2894] MessageLoopTypedTest.NestableTasksAllowedAtTopLevel/IO (0 ms)
...
[00258.289] 03969.04017> Tests took 251 seconds.

This suggests that the tests are all taking ~25-50% longer in the flaking cases, e.g. due to contention with other test activity running in parallel, and that the RecursivePosts/IO test just happens to be so close to the configured timeout (45s?) that it flakes as a result.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b19e41d69b1de5c444ecfa6a6ad4fb26e7c5d3

commit 58b19e41d69b1de5c444ecfa6a6ad4fb26e7c5d3
Author: Wez <wez@chromium.org>
Date: Thu Feb 08 00:31:56 2018

Filter MessageLoopTypedTest.RecursivePosts/* tests under Fuchsia.

These tests run slowly under virtualization, especially in Debug builds,
which can lead to them timing-out depending on what other tests are
running in parallel with them.

Bug: 810077
Change-Id: I69222a59d2fc0b93bfd927854da1de82a16d4b0f
Reviewed-on: https://chromium-review.googlesource.com/907344
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535213}
[modify] https://crrev.com/58b19e41d69b1de5c444ecfa6a6ad4fb26e7c5d3/testing/buildbot/filters/fuchsia.base_unittests.filter

Comment 2 by w...@chromium.org, May 23 2018

Labels: -M-67 M-69

Comment 3 by w...@chromium.org, May 26 2018

Blockedon: 844416
Cc: w...@chromium.org
Owner: ----
Status: ExternalDependency (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62c715550ee24d8b24ef1069819719c2d3abafb0

commit 62c715550ee24d8b24ef1069819719c2d3abafb0
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Jun 18 19:36:35 2018

Filter out all remaining base tests on Fuchsia.

This removes all the remaining disabled tests in the filter file for
base tests on Fuchsia and instead filters each of them individually.

Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760
Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2
Reviewed-on: https://chromium-review.googlesource.com/1096483
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568112}
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/allocator/partition_allocator/address_space_randomization_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_proxy_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/files/file_util_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/metrics/field_trial_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/observer_list_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/process/process_util_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/synchronization/condition_variable_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/sys_info_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/threading/platform_thread_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/process_memory_dump_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/base/trace_event/trace_category_unittest.cc
[modify] https://crrev.com/62c715550ee24d8b24ef1069819719c2d3abafb0/testing/buildbot/filters/fuchsia.base_unittests.filter

Sign in to add a comment