New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 810073 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

mash: MemoryTracingBrowserTest.TestHeapProfilingPseudo crashes in mash_browser_tests

Project Member Reported by jamescook@chromium.org, Feb 7 2018

Issue description

mash_browser_tests (browser_tests --mash) started crashing around https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/26694

I don't see any obvious culprit CLs. Maybe danakj's https://chromium.googlesource.com/chromium/src/+/bd63605c0b5cbcd45dd8320143b2d511f3112995 ?

[24651:24722:0207/093620.315899:ERROR:crash_handler_host_linux.cc(437)] Failed to write crash dump for pid 24995
Cannot upload crash dump: failed to open
Failed to save crash dump: failed to open
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x000003ec0c3c base::debug::StackTrace::StackTrace()
#1 0x000004512282 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f321a945cb0 <unknown>
#3 0x000005c01331 cc::(anonymous namespace)::ZeroCopyGpuBacking::SharedMemoryGuid()
#4 0x000005c09b3a cc::ResourcePool::PoolResource::OnMemoryDump()
#5 0x000005c098c6 cc::ResourcePool::OnMemoryDump()
#6 0x000003f43553 base::trace_event::MemoryDumpManager::InvokeOnMemoryDump()
#7 0x000003f43112 base::trace_event::MemoryDumpManager::ContinueAsyncProcessDump()
#8 0x000003ec13f5 base::debug::TaskAnnotator::RunTask()
#9 0x000003f79329 base::internal::IncomingTaskQueue::RunTask()
#10 0x000003ee280b base::MessageLoop::RunTask()
#11 0x000003ee2ba3 base::MessageLoop::DeferOrRunPendingTask()
#12 0x000003ee2e36 base::MessageLoop::DoWork()
#13 0x000003ee4ef9 base::MessagePumpLibevent::Run()
#14 0x000003ee2109 base::MessageLoop::Run()
#15 0x000003f0d3a9 base::RunLoop::Run()
#16 0x00000454b186 content::MessageLoopRunner::Run()
#17 0x000004549af9 content::TestNavigationObserver::Wait()
#18 0x000003fb035c ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete()
#19 0x000000e7972e (anonymous namespace)::MemoryTracingBrowserTest::PerformDumpMemoryTestActions()
#20 0x000000e7a5a6 (anonymous namespace)::MemoryTracingBrowserTest_TestHeapProfilingPseudo_Test::RunTestOnMainThread()
#21 0x000004511fd5 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#22 0x000003ff476c ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#23 0x000003ff350d ChromeBrowserMainParts::PreMainMessageLoopRun()
#24 0x000001995a38 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#25 0x000002749f01 content::BrowserMainLoop::PreMainMessageLoopRun()
#26 0x000002b89115 content::StartupTaskRunner::RunAllTasksNow()
#27 0x0000027484bd content::BrowserMainLoop::CreateStartupTasks()
#28 0x00000274c9d3 content::BrowserMainRunnerImpl::Initialize()
#29 0x000002746092 content::BrowserMain()
#30 0x000003e8d9c2 content::ContentMainRunnerImpl::Run()
#31 0x00000618579b service_manager::Main()
#32 0x000003e8bfa4 content::ContentMain()
#33 0x000004511c3f content::BrowserTestBase::SetUp()
#34 0x000003fad1ec InProcessBrowserTest::SetUp()
#35 0x000001d16951 testing::Test::Run()
#36 0x000001d17520 testing::TestInfo::Run()
#37 0x000001d17a07 testing::TestCase::Run()
#38 0x000001d1ef37 testing::internal::UnitTestImpl::RunAllTests()
#39 0x000001d1eb87 testing::UnitTest::Run()
#40 0x000003fc1842 base::TestSuite::Run()
#41 0x000003eb4af9 ChromeTestSuiteRunner::RunTestSuite()
#42 0x000003eb4a70 (anonymous namespace)::MusTestLauncherDelegate::RunTestSuite()
#43 0x000004546d6d content::LaunchTests()
#44 0x000003eb4fc4 LaunchChromeTests()
#45 0x000003eb4806 RunMashBrowserTests()
#46 0x000003eb46b7 main

 
Owner: danakj@chromium.org
Status: Started (was: Untriaged)
Yeah find-it already found the same CL and commented on it: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYmQ2MzYwNWMwYjVjYmNkNDVkZDgzMjAxNDNiMmQ1MTFmMzExMjk5NQw
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d138a797a5f64350edd0f16f0cd26aebb6d3d188

commit d138a797a5f64350edd0f16f0cd26aebb6d3d188
Author: James Cook <jamescook@chromium.org>
Date: Wed Feb 07 18:53:55 2018

cros: Disable more mash_browser_tests on Mojo FYI bot

A couple of tests have regressed while I've been waiting to put these
tests on the main waterfall. Just disable them for now.

TBR=sky@chromium.org

Bug:  810073 ,  810071 
Test: mash_browser_tests
Change-Id: I219ce3ce192f12801f99d28545429b229c6103fd
Reviewed-on: https://chromium-review.googlesource.com/907370
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535079}
[modify] https://crrev.com/d138a797a5f64350edd0f16f0cd26aebb6d3d188/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Cc: vmp...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c201ec3f0edf8d50fffd582a31ee4eb42b1713c

commit 2c201ec3f0edf8d50fffd582a31ee4eb42b1713c
Author: danakj <danakj@chromium.org>
Date: Thu Feb 08 18:25:36 2018

Fix flakiness when dumping memory with ZeroCopyRasterBufferProvider

The GpuBacking in a PoolResource is allocated before running the raster
task, but the GpuMemoryBuffer is set on the backing after. If memory
dump happens in between, it would crash trying to read the null
GpuMemoryBuffer. Until the GpuMemoryBuffer is set, we can treat the
memory as not allocated (from the compositor thread's perspective
at the least). So change ResourcePool code to handle this case.

R=vmpstr@chromium.org

Bug:  730660 ,  810073 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7b5add1f741c8596432f070e8c6038c69612540c
Reviewed-on: https://chromium-review.googlesource.com/906672
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535447}
[modify] https://crrev.com/2c201ec3f0edf8d50fffd582a31ee4eb42b1713c/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/2c201ec3f0edf8d50fffd582a31ee4eb42b1713c/cc/resources/resource_pool.cc
[modify] https://crrev.com/2c201ec3f0edf8d50fffd582a31ee4eb42b1713c/cc/resources/resource_pool.h

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ca7db72cfbd04fcdd03b17ab17aadf3f67465d

commit d0ca7db72cfbd04fcdd03b17ab17aadf3f67465d
Author: danakj <danakj@chromium.org>
Date: Thu Feb 08 21:56:18 2018

Re-enable MemoryTracingBrowserTest.TestHeapProfilingPseudo

The crash is fixed by 2c201ec3f0edf8d50fffd582a31ee4eb42b1713c.

R=jamescook@chromium.org, sky@chromium.org
TBR=sky

Bug:  810073 
Change-Id: I7ffc521c77608e04fc5cc7ce0500502ae86c877f
Reviewed-on: https://chromium-review.googlesource.com/909629
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535534}
[modify] https://crrev.com/d0ca7db72cfbd04fcdd03b17ab17aadf3f67465d/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Sign in to add a comment