New issue
Advanced search Search tips

Issue 810069 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Enable Fuchsia package rules for Chromecast builds

Project Member Reported by kmarshall@chromium.org, Feb 7 2018

Issue description

Enable package rules for Chromecast builds once the Fuchsia loader and packaging rules support dynamic libraries etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/184e90959572c3ac388c33e9bb180df3f1943ce2

commit 184e90959572c3ac388c33e9bb180df3f1943ce2
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Feb 07 21:09:06 2018

Fuchsia: disable packaging for Chromecast builds.

Chromecast builds include a number of shared libraries, but Fuchsia's
shared library support from within a package is still undefined,
in addition to the packaging script's handling of libraries.


Bug:  810069 
Change-Id: I5b6a9f4597d1f760710f907e56ac97ac2c99c9e2
Reviewed-on: https://chromium-review.googlesource.com/907329
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535141}
[modify] https://crrev.com/184e90959572c3ac388c33e9bb180df3f1943ce2/build/config/fuchsia/rules.gni
[modify] https://crrev.com/184e90959572c3ac388c33e9bb180df3f1943ce2/testing/test.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/433099ab6d2573c767305dae70a297d90fe82208

commit 433099ab6d2573c767305dae70a297d90fe82208
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jun 14 03:12:28 2018

Fuchsia: Enable packages in chromecast builds.

Fuchsia packages were not generated with is_chromecast=true. The problem
with library loading has been fixed, so there is no reason not to
generate packages anymore.

TBR=dpranke@chromium.org

Bug:  810069 
Change-Id: I5ab66414bab4c6e9eab8c5dd12360656ba5e7d44
Reviewed-on: https://chromium-review.googlesource.com/1099995
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567107}
[modify] https://crrev.com/433099ab6d2573c767305dae70a297d90fe82208/build/config/fuchsia/rules.gni
[modify] https://crrev.com/433099ab6d2573c767305dae70a297d90fe82208/testing/test.gni

Status: Fixed (was: Untriaged)

Sign in to add a comment