New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 810058 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

AcceleratedStaticBitmapImage does unnecessary texture mailbox consumes.

Project Member Reported by junov@chromium.org, Feb 7 2018 
AcceleratedStaticBitmapImage::PaintImageForCurrentFrame currently forces the TextureHolder to be a SkiaTextureHolder.  This is not necessary when we still have a reference to the original SkImage and it is from the same thread./
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482

commit 7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482
Author: Justin Novosad <junov@chromium.org>
Date: Fri Feb 09 18:36:52 2018

Prevent StaticBitmapImage from teetering between mailbox and skia

This change prevents StaticBitmapImage from switching from mailbox
back to skia representation in cases where it started in skia mode
on the same thread. This prevents cansume/produce churn.

BUG= 810058 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia91ad00f4cf935b9a584832ec1d133e0967651ba
Reviewed-on: https://chromium-review.googlesource.com/907114
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535760}
[modify] https://crrev.com/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h
[add] https://crrev.com/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImageTest.cpp
[modify] https://crrev.com/7b9a494a9ef6fc75b6c9cb4f5e91dcd1234f7482/third_party/WebKit/Source/platform/graphics/CanvasResourceProvider.cpp

Comment 2 by junov@chromium.org, Feb 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment