New issue
Advanced search Search tips

Issue 810027 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NavigationControllerTest.ShowRendererURLAfterFailUntilModified doesn't exercise the code it's supposed to test

Project Member Reported by jochen@chromium.org, Feb 7 2018

Issue description

I suspect that https://codereview.chromium.org/232463007/ (which added this test) wants to exercise NavigatorImpl::DiscardPendingEntryIfNeeded however, since there's no navigation handle, DiscardPendingEntryIfNeeded is invoked with expected_pending_entry_id == 0, so it early returns.
 

Sign in to add a comment