"ExtensionViewTests/ExtensionViewLoadApiTest.LoadAPILoadOtherExtension/0" is flaky |
|||||
Issue description"ExtensionViewTests/ExtensionViewLoadApiTest.LoadAPILoadOtherExtension/0" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdFeHRlbnNpb25WaWV3VGVzdHMvRXh0ZW5zaW9uVmlld0xvYWRBcGlUZXN0LkxvYWRBUElMb2FkT3RoZXJFeHRlbnNpb24vMAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 7 2018
mcnee@ - Are you the right person to look at this?
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2de9f646c3195ecafa58de5d2647d9916087ff9b commit 2de9f646c3195ecafa58de5d2647d9916087ff9b Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Wed Feb 07 17:20:54 2018 Disable flaky test: ExtensionViewLoadApiTest.LoadAPILoadOtherExtension Bug: 810007 Change-Id: Icb803332944ca548493f8d92ff33022697f3d85a TBR: wjmaclean@chromium.org Reviewed-on: https://chromium-review.googlesource.com/906791 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#535036} [modify] https://crrev.com/2de9f646c3195ecafa58de5d2647d9916087ff9b/chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc
,
Feb 7 2018
This test (along with QueuedLoadAPILoadOtherExtension) are also causing failures on MSAN bots (https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests). Hopefully this can help debug the issue. Thanks!
,
Feb 7 2018
Only the old /0 parameterized version of these tests are flaky. The current /1 version is fine. I'll just disable the /0 version.
,
Feb 7 2018
,
Feb 8 2018
Please also see https://bugs.chromium.org/p/chromium/issues/detail?id=810357 It's being disable here https://chromium-review.googlesource.com/c/chromium/src/+/908559 (with all parameters) - feel free to cancel that if you want to address only /1
,
Feb 8 2018
Does extensionview use BrowserPlugin or OOPIF these days?
,
Feb 8 2018
It's all OOPIF these days. Just MimeHandlerViewGuest is still on BrowserPlugin, and ekaramad@ is close to switching it over. mcnee@ is removing the BrowserPlugin version for this test I believe.
,
Feb 8 2018
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f18a65f086aca6917b13e365c30938a4c64e43e7 commit f18a65f086aca6917b13e365c30938a4c64e43e7 Author: Kevin McNee <mcnee@chromium.org> Date: Thu Feb 08 17:28:06 2018 Remove BrowserPlugin parameterization of ExtensionViewTests. ExtensionViewTests now only run for the GuestViewCrossProcessFrames enabled case. Tests that were disabled for flaking in the BrowserPlugin case are reenabled. Bug: 533069, 810007 , 810071 Change-Id: Id7cb90333db0faa1650c603f3870425bc7b5f574 Reviewed-on: https://chromium-review.googlesource.com/907180 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#535421} [modify] https://crrev.com/f18a65f086aca6917b13e365c30938a4c64e43e7/chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc [modify] https://crrev.com/f18a65f086aca6917b13e365c30938a4c64e43e7/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter
,
Feb 8 2018
ExtensionViewTests now only test the OOPIF implementation. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by anthonyvd@chromium.org
, Feb 7 2018