New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 809989 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2018
Cc:
nzolghadr@chromium.org
█ fsam...@chromium.org
sadrul@chromium.org
█ briander...@chromium.org
dtapu...@chromium.org
jonr...@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 775030



Sign in to add a comment

Remove latency info from content/browser/renderer_host

Project Member Reported by kylec...@chromium.org, Feb 7 2018 
With VizDisplayCompositor renderer CompositorFrames aren't delivered to the browser and the code in content/browser/renderer_host/* can't update LatencyInfo.

I believe LatencyInfo works fine with VizDisplayCompositor from  crbug.com/771357 . There should be no reason we can't tear out any latency info code from the following functions.

RenderWidgetHostImpl::SubmitCompositorFrame()
DelegatedFrameHost::SubmitCompositorFrame()

It would be better if the viz implementation was always used to ensure there are no bugs and reduce code duplication.

Comment 1 by jonr...@chromium.org, Feb 7 2018

Cc: dtapu...@chromium.org
+dtapuska@ for comments on how render_host/input is using LatencyInfo.

I am aware of some tests which rely on LatencyInfo for their testing, such as issue 791557. These tests already are dealing with races due to there being two paths from which they can receive LatencyInfo.

But if we are planning to remove all access to LatencyInfo in the browser process they will need to be revisited.

Comment 2 by sadrul@chromium.org, Feb 7 2018

Cc: briander...@chromium.org nzolghadr@chromium.org tdres...@chromium.org
We are thinking of changing how LatencyInfo works (see [1]), which I think will help with this. /cc some folks involved in that discussion.

[1] https://docs.google.com/document/d/1Gtaw7g7PgvSrTH2sbK-POslMrUYtJbcnMbk75JrBO20/edit

Comment 3 by dtapu...@chromium.org, Feb 7 2018 

The main thing the render host input latency tracker does is calculate end-to-end latency measurements. The design doc quoted still has that as an open issue.

Comment 4 by sadrul@chromium.org, Feb 7 2018 

end-to-end should not be an issue (are you referring to the comment about using Now())?

Comment 5 by dtapu...@chromium.org, Feb 7 2018 

No I was referring to the UMA comment.

Comment 6 by samans@chromium.org, May 11 2018

Status: Fixed (was: Available)
We no longer modify LatencyInfo in SubmitCompositorFrame. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1019389
https://chromium-review.googlesource.com/c/chromium/src/+/1040866
►

Sign in to add a comment