New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809971 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 800653
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Build failure for Chrome without WebRTC

Project Member Reported by eladalon@chromium.org, Feb 7 2018

Issue description

gn args:
target_os = "linux"
dcheck_always_on = true
enable_webrtc = false

Build failure:
In file included from ../../chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:23:
In file included from ../../content/public/browser/desktop_capture.h:9:
../../third_party/webrtc/modules/desktop_capture/desktop_capture_options.h:13:10: fatal error: 'rtc_base/constructormagic.h' file not found
#include "rtc_base/constructormagic.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

 

Comment 1 by guidou@chromium.org, Feb 12 2018

Cc: phoglund@chromium.org
Maybe there needs to be a bot somewhere that keeps this working.

Comment 3 by guidou@chromium.org, Feb 12 2018

There used to be a bug for adding such a bot, but I don't know what happened to it.
I looked through our bug lists and I can't find any bug for that either, so I'll file one.
Components: -Blink>GetUserMedia>Desktop Blink>WebRTC
 Issue 754589  has been merged into this issue.

Comment 9 by guidou@chromium.org, Mar 12 2018

Mergedinto: 800653
Status: Duplicate (was: Untriaged)

Sign in to add a comment