New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 809970 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Javascript clearing after mistakenly detecting page navigation

Reported by daalexbo...@gmail.com, Feb 7 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
1. send a GET request to https://accounts.google.com/o/oauth2/iframe

What is the expected behavior?
The javascript console will clear , as the returned html from the above URL makes it think it is navigating away from the current page

What went wrong?
Persisting logs across webpages will show that the console believes it is navigating away from the current page, resulting in the console being wrongfully cleared.

Did this work before? Yes 

Chrome version: 64.0.3282.140  Channel: stable
OS Version: OS X 10.13.2
Flash Version: 

Sorry that I couldnt provide any other information, as I found this in the company that I work, and dont want to divulge too much private information.
 
causing_console_to_clear_crop.png
207 KB View Download
aha.png
15.7 KB View Download
Another footnote, this behaviour does not occur in the latest Firefox, and began happening in Chrome up to a month ago, not sure what version specifically.
Labels: Needs-Bisect Needs-Triage-M64
 Issue 809965  has been merged into this issue.
Cc: vamshi.k...@techmahindra.com
Labels: Triaged-ET Needs-Feedback
Thanks for filing the issue!

Checked the issue on reported chrome version 64.0.3282.140 and on the latest canary 66.0.3342.0 using Mac 10.13.1 with the steps mentioned below.
1. Launched Chrome
2. Navigated to the URL given in Comment#0
3. Inspect->Network tab->Reloading the page->Clicked on the link->Headers
We are able to see the result similar to that of the attachment in C#0. 
Note: Attaching the screenshot from M60(60.0.3072.0), where similar result is seen.

@Reporter: Could you please have a look at the screenshot provided with this comment and let us know if the issue is there, your confirmation helps us to triage the issue in a better way.
809970.png
659 KB View Download
I probably could have made this clearer... The issue is not what's in the response, but instead stems from performing this request from inside another web-page. A script on my webpage is performing a request to this URL in order to get data to use in the current page, but the JavaScript console treats it as page navigation and clears the console.
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "vamshi.kommuri@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: dgozman@chromium.org manoranj...@chromium.org sc00335...@techmahindra.com
 Issue 809947  has been merged into this issue.
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable M-65 Pri-1
This is due to out-of-process iframe, regressed from M64. We should merge the fix to M65.
Cc: pbomm...@chromium.org gov...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e44555895b1c2fb682e33ffdaf9860dbe33ea45

commit 4e44555895b1c2fb682e33ffdaf9860dbe33ea45
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Feb 09 22:44:18 2018

[DevTools] Fix console problems with oopif

- Do not clear console on iframe navigation;
- Do not print "Navigated to ..." message on iframe navigation;
- Do not reset all UIMessages on iframe navigation.

Bug:  809970 
Change-Id: I591872eae4d4276a9362180a53d7a6dce2dd56d5
Reviewed-on: https://chromium-review.googlesource.com/909864
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535860}
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation-expected.txt
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-console-preserves-log-on-frame-navigation.js
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages-expected.txt
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-presentation-console-messages.js
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/empty.html
[add] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/resources/error.html
[modify] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
[modify] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
[modify] https://crrev.com/4e44555895b1c2fb682e33ffdaf9860dbe33ea45/third_party/WebKit/Source/devtools/front_end/main/Main.js

Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
Actually, there is no need to merge this to 65.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD -M-65 M-66

Sign in to add a comment