New issue
Advanced search Search tips

Issue 809943 link

Starred by 1 user
Status: Fixed
Owner:
sushr...@microsoft.com
Closed: Jan 18
Cc:
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 809920



Sign in to add a comment

Clamp calc() values after font-style: oblique calc(...)

Project Member Reported by drott@chromium.org, Feb 7 2018 
Compare: Two failing cases in 
MS WPT variation test wpt/css/css-fonts/variations/font-style-parsing.html

FAIL Font-style: 'oblique' followed by calc is valid even if it must be clamped (no computation) assert_equals: Font-style: 'oblique' followed by calc is valid even if it must be clamped (no computation) expected true but got false
FAIL Font-style: 'oblique' followed by calc is valid even if it must be clamped (with computation) assert_equals: Font-style: 'oblique' followed by calc is valid even if it must be clamped (with computation) expected true but got false
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f77fc256295595a396718d74964f38f595f469

commit 91f77fc256295595a396718d74964f38f595f469
Author: Sushanth Rajasankar <sushraja@microsoft.com>
Date: Thu Jan 17 20:00:14 2019

Clamp out of range calc() values after font-style: oblique calc(...)

This fixes the bug referenced [here.]
(https://bugs.chromium.org/p/chromium/issues/detail?id=809943)

Values specified in a calc() function after an oblique now clamp to the
range of [-90, 90].

https://www.w3.org/TR/css-fonts-4/ - Restricts values to -90-90
https://drafts.csswg.org/css-values-3/#calc-range - Requires that the
results of Calc be clamped.

Bug:  809943 
Change-Id: I474f034fc87018bf983c89fba52ed4a09994f924
Reviewed-on: https://chromium-review.googlesource.com/c/1410177
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Sushanth Rajasankar <Sushraja@microsoft.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623808}
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.cc
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.h
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/renderer/platform/fonts/font_selection_types.h
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/web_tests/external/wpt/css/css-fonts/variations/at-font-face-descriptors-expected.txt
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/web_tests/external/wpt/css/css-fonts/variations/at-font-face-descriptors.html
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/web_tests/external/wpt/css/css-fonts/variations/font-parse-numeric-stretch-style-weight-expected.txt
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/web_tests/external/wpt/css/css-fonts/variations/font-style-parsing-expected.txt
[modify] https://crrev.com/91f77fc256295595a396718d74964f38f595f469/third_party/blink/web_tests/external/wpt/css/css-fonts/variations/font-style-parsing.html

Comment 2 by drott@chromium.org, Jan 18 (5 days ago)

Owner: sushr...@microsoft.com
Status: Fixed (was: Assigned)

Comment 3 by drott@chromium.org, Jan 18 (5 days ago)

Cc: drott@chromium.org
►

Sign in to add a comment