Returning computed style for font-style has issues with oblique angles |
||
Issue descriptionhttps://codepen.io/anon/pen/aqBbPL?editors=1111 and MS WPT test for variations: external/wpt/css/css-fonts/variations/font-style-interpolation.html font-style: oblique -12deg; does not seem to be correctly returned when asking for the computed style for an element that is styled like that.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/755a9214dc9116a826f8881851c07e352004a6c5 commit 755a9214dc9116a826f8881851c07e352004a6c5 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Apr 04 14:12:32 2018 Serialize 'oblique' computed values for 'font-style' Handling of 'oblique' values were missing in ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'. Because of this the return value needs to be widened to CSSValue. Bug: 809935, 809938 Change-Id: I1de846595ed955455d57ab9f6ea45326e502a65b Reviewed-on: https://chromium-review.googlesource.com/995273 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548044} [modify] https://crrev.com/755a9214dc9116a826f8881851c07e352004a6c5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/755a9214dc9116a826f8881851c07e352004a6c5/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp [modify] https://crrev.com/755a9214dc9116a826f8881851c07e352004a6c5/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.h
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5979b690c2cb44fd079f8606e431d22c1c754f52 commit 5979b690c2cb44fd079f8606e431d22c1c754f52 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Apr 04 14:39:58 2018 Revert "Serialize 'oblique' computed values for 'font-style'" This reverts commit 755a9214dc9116a826f8881851c07e352004a6c5. Reason for revert: Mid-flight collision with 162e9dda47d694596620b69c5fb23cc7f0f87126 - will update and reland. Original change's description: > Serialize 'oblique' computed values for 'font-style' > > Handling of 'oblique' values were missing in > ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'. > Because of this the return value needs to be widened to CSSValue. > > Bug: 809935, 809938 > Change-Id: I1de846595ed955455d57ab9f6ea45326e502a65b > Reviewed-on: https://chromium-review.googlesource.com/995273 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#548044} TBR=fs@opera.com,drott@chromium.org,futhark@chromium.org Change-Id: I379a152245f16fc792c8bfc55a2d8b127ba30820 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809935, 809938 Reviewed-on: https://chromium-review.googlesource.com/995695 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548052} [modify] https://crrev.com/5979b690c2cb44fd079f8606e431d22c1c754f52/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5979b690c2cb44fd079f8606e431d22c1c754f52/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp [modify] https://crrev.com/5979b690c2cb44fd079f8606e431d22c1c754f52/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.h
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4b3b75eab4e728cf5072c52691ac84150d321a commit 7e4b3b75eab4e728cf5072c52691ac84150d321a Author: Fredrik Söderquist <fs@opera.com> Date: Wed Apr 04 18:57:06 2018 Reland "Serialize 'oblique' computed values for 'font-style'" Handling of 'oblique' values were missing in ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'. Because of this the return value needs to be widened to CSSValue. Expectations for css/css-fonts/variations/font-shorthand.html updated. TBR=drott@chromium.org Bug: 809935, 809938 Change-Id: I753324776ba080820bc5c4a14e8aff6237ee5d12 Reviewed-on: https://chromium-review.googlesource.com/995793 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#548143} [modify] https://crrev.com/7e4b3b75eab4e728cf5072c52691ac84150d321a/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/7e4b3b75eab4e728cf5072c52691ac84150d321a/third_party/WebKit/LayoutTests/external/wpt/css/css-fonts/variations/font-shorthand-expected.txt [modify] https://crrev.com/7e4b3b75eab4e728cf5072c52691ac84150d321a/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp [modify] https://crrev.com/7e4b3b75eab4e728cf5072c52691ac84150d321a/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.h
,
Apr 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by f...@opera.com
, Apr 4 2018